• Join
  • Sign In with my.TI Login
Texas Instruments
  • Products
  • Applications
  • Tools & Software
  • Support & Community
  • Sample & Buy
  • About TI
Sample & Purchase Cart Sample & Purchase Cart
  • Search
  • Advanced
TI E2E™ Community
  • Support Forums
  • Blogs
  • Groups
  • Videos
  • 简体中文
  • More ...
TI Home » TI E2E Community » Support Forums » Microcontrollers » MSP430™ Microcontrollers » MSP430 Ultra-Low Power 16-bit Microcontroller Forum » Float multiplication with 1.0 doubles the result
Share
MSP430™ Microcontrollers
  • Forum
  • Announcements
  • E2E Wiki
Options
  • Subscribe via RSS
MSP430 Resources
  • MSP430 Product Folder
  • MSP-EXP430G2 - MSP430 LaunchPad Value Line Development kit
  • MSP430 Getting Started Guide
  • MSP430 Microcontroller Projects
  • More Resources >
  • Float multiplication with 1.0 doubles the result

    Float multiplication with 1.0 doubles the result

    This question is answered
    JustGreg
    Posted by JustGreg
    on May 16 2012 08:34 AM
    Expert2560 points

    Hi!

     

    I've a strange coding issue with multiplication of floats in IAR. Here is the code snippet:

     

     unsigned int TEST (FS *fs){



     float x0, x1, x2;


    x0 = 1.0 * fs->x;
    x1 = -2.0 * fs->x_1;
    x2 = 1.0 * fs->x_2;


    return 0;
    }

    The fs structure contains unsigned ints containing 10 bit ADC values. For any value of member x, the  x0 = 1.0 * fs->x; row yields 2*x  value in the debugger. For example  x=377, then x0=756.0. 

     

    The debugger correctly translates x0 as a float. What is the problem here?

      


    Report Abuse
    • Reply
    You have posted to a forum that requires a moderator to approve posts before they are publicly available.
    All Replies
    • old_cow_yellow
      Posted by old_cow_yellow
      on May 17 2012 19:19 PM
      Guru26595 points

      What do you get if you do not do the float multiply?

      That is, if you try "x0 = fs->x;" instead of "x0 = 1.0*fs->x;", what is the result of x0?

      Report Abuse
      • Reply
      You have posted to a forum that requires a moderator to approve posts before they are publicly available.
    • JustGreg
      Posted by JustGreg
      on May 18 2012 10:16 AM
      Expert2560 points
      problem.jpg

      Hi OCY,

       

      thank you for your help. Please check the following screenshot, it contains both the problem and your tip. 


      Report Abuse
      • Reply
      You have posted to a forum that requires a moderator to approve posts before they are publicly available.
    • old_cow_yellow
      Posted by old_cow_yellow
      on May 19 2012 00:30 AM
      Verified Answer
      Verified by JustGreg
      Guru26595 points

      Yes, I see.

      But I tried to do the same and the results are correct as expected. The compiler you used may have a bug. Or you somehow tricked it.

      By the way, the chip you used has fixed point MAC hardware. Using fixed point DSP will be fast. Using floating point is not so good.

      Report Abuse
      • Reply
      You have posted to a forum that requires a moderator to approve posts before they are publicly available.
    • JustGreg
      Posted by JustGreg
      on May 22 2012 06:36 AM
      Expert2560 points

      Hi OCY,

       

      I'm going to port the whole project into CCS to check if this is a compiler issue.  In fact, I'm working on simple 2nd order HP filter using the MPY32 hardware and just wanted calculate some FP multiplications to verify my hardware multiplier code.

       

       


      Report Abuse
      • Reply
      You have posted to a forum that requires a moderator to approve posts before they are publicly available.
    TI E2E™ Community
    • Support Forums
    • Blogs
    • Videos
    • Groups
    • Site Support & Feedback
    • Settings
    TI E2E™ Community Groups
    • TI University Program
    • Make the Switch
    • Microcontroller Projects
    • Motor Drive & Control
    Other Communities
    • Deyisupport
    • Designsomething.org
    • beagleboard.org
    • TI on Element 14
    • TI on TechXchangeSM
    Other Technical & Support Resources
    • WEBENCH® Design Center
    • Product Information Centers
    • Technical Documents
    • TI Design Network
    • TI Technical Articles
    • TI Training

    All content and materials on this site are provided "as is". TI and its respective suppliers and providers of content make no representations about the suitability of these materials for any purpose and disclaim all warranties and conditions with regard to these materials, including but not limited to all implied warranties and conditions of merchantability, fitness for a particular purpose, title and non-infringement of any third party intellectual property right. TI and its respective suppliers and providers of content make no representations about the suitability of these materials for any purpose and disclaim all warranties and conditions with respect to these materials. No license, either express or implied, by estoppel or otherwise, is granted by TI. Use of the information on this site may require a license from a third party, or a license from TI.

    Content on this site may contain or be subject to specific guidelines or limitations on use. All postings and use of the content on this site are subject to the Terms of Use of the site; third parties using this content agree to abide by any limitations or guidelines and to comply with the Terms of Use of this site. TI, its suppliers and providers of content reserve the right to make corrections, deletions, modifications, enhancements, improvements and other changes to the content and materials, its products, programs and services at any time or to move or discontinue any content, products, programs, or services without notice.

    Follow Us Texas Instruments on Facebook Texas Instruments on Twitter Texas Instruments on LinkedIn Texas Instruments on Google+
    TI Worldwide | Contact Us | my.TI Login | Site Map | Corporate Citizenship | mobile m.ti.com (Mobile Version)

    TI is a global semiconductor design and manufacturing company. Innovate with 100,000+ analog ICs and
    embedded processors, along with software, tools and the industry’s largest sales/support staff.

    © Copyright 1995-2013 Texas Instruments Incorporated. All rights reserved.
    Trademarks | Privacy Policy | Terms of Use