CC2538: 2 bugs are still appearing in zcl.c file of z-stack 3.0.2

Hi Aries,

Since reporting is now defined in Base Device Behavior specification, now the z-stack bdb implementation also supports the access to attributes with callbacks. Take a look to bdb_RepReport() in bdb_reporting.c, the is a function named bdb_RepFindAttrEntry() that is called to find the attribute record even if the access requires a callback or not and then sends the report with zcl_SendReportCmd() once the attribute was found.

Can you elaborate on point number 2? I cannot see the issue here.

but  zcl_SendReportCmd()  have no ability to access to attributes with callbacks. zcl_SendReportCmd() should be fixed like this.

ZStatus_t zcl_SendReportCmd( uint8 srcEP, afAddrType_t *dstAddr,
                             uint16 clusterID, zclReportCmd_t *reportCmd,
                             uint8 direction, uint8 disableDefaultRsp, uint8 seqNum )
{
  uint16 dataLen = 0;
  uint8 *buf;
  ZStatus_t status;
  uint8 i;

  // calculate the size of the command
  for ( i = 0; i < reportCmd->numAttr; i++ )
  {
    zclReport_t *reportRec = &(reportCmd->attrList[i]);

    dataLen += 2 + 1; // Attribute ID + data type

    // Attribute Data
    //dataLen += zclGetAttrDataLength( reportRec->dataType, reportRec->attrData );
    if( reportRec->attrData )
    {
      dataLen += zclGetAttrDataLength( reportRec->dataType, reportRec->attrData );
    }
    else
    {
      dataLen += zclGetAttrDataLengthUsingCB( srcEP, clusterID, reportRec->attrID );
    }
  }

  buf = zcl_mem_alloc( dataLen );
  if ( buf != NULL )
  {
    // Load the buffer - serially
    uint8 *pBuf = buf;

    for ( i = 0; i < reportCmd->numAttr; i++ )
    {
      zclReport_t *reportRec = &(reportCmd->attrList[i]);

      *pBuf++ = LO_UINT16( reportRec->attrID );
      *pBuf++ = HI_UINT16( reportRec->attrID );
      *pBuf++ = reportRec->dataType;

      //pBuf = zclSerializeData( reportRec->dataType, reportRec->attrData, pBuf );
      if ( reportRec->attrData != NULL )
      {
        // Copy attribute data to the buffer to be sent out
        pBuf = zclSerializeData( reportRec->dataType, reportRec->attrData, pBuf );
      }
      else
      {
        uint16 dataLen;
        // Read attribute data directly into the buffer to be sent out
        zclReadAttrDataUsingCB( srcEP, clusterID, reportRec->attrID, pBuf, &dataLen );
        pBuf += dataLen;
      }
    }

    status = zcl_SendCommand( srcEP, dstAddr, clusterID, ZCL_CMD_REPORT, FALSE,
                              direction, disableDefaultRsp, 0, seqNum, dataLen, buf );
    zcl_mem_free( buf );
  }
  else
  {
    status = ZMemError;
  }

  return ( status );
}

the number 2 issue is the under code in fuction "zcl_event_loop" in zcl.c

      if ( *msgPtr == AF_INCOMING_MSG_CMD )
      {
        zcl_ProcessMessageMSG( (afIncomingMSGPacket_t *)msgPtr );
      }
      else
      {
        taskID = zcl_getExternalFoundationHandler( (afIncomingMSGPacket_t *)msgPtr );
        
        if ( taskID != TASK_NO_TASK )
        {
          // send it to another task to process.
          osal_msg_send( taskID, msgPtr );
          dealloc = FALSE;
        }
      }

zcl_SendReportCmd() already holds the attribute data in "reportCmd" in a struct of type zclReportCmd_t. Attribute reporting is now part of BDB state machine so zcl_SendReportCmd() is used only to send the report buffer given by BDB state machine, not to solve the list of attributes to be reported.

typedef struct

{
  uint8       numAttr;       // number of reports in the list
  zclReport_t attrList[];    // attribute report list
} zclReportCmd_t;

You can take a look in to Sample Temperature Sensor at zclSampleTemperatureSensor_Init() where bdb_RepAddAttrCfgRecordDefaultToList() is used to set the default reporting configuration, then BDB reporting state machine solves everything related to attribute reporting. Also look at ZigBee Application Architecture, ZigBee Alliance document and Base Device Behavior Specification.

For number 2, are you talking about to use the endpoint directly instead of msgPtr? however the return of the function is not affected by this.

In function bdb_RepReport() in "bdb_Reporting.c", pReportCmd in type zclReportCmd_t was send by zcl_SendReportCmd. The member "attrList[i].attrData" of pReportCmd is a data pointer type that access to buffer "gAttrDataValue".  "gAttrDataValue" can only carry one Attribute value, but if there was more than one attribute in a cluster should be reported, the error will happen.

You are right. The issue will cause you to have the same data pointer for all attributes.