TM4C129XNCZAD: Why doesn't TANK ID appear 3 times on the screen?

Hi,

  I see the below line where you use g_SystemInfo + 5 as the pointer to the Widget structure. 

CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.

 Isn't g_SystemInfo + 5 pointing to the below structure? 

CanvasStruct(g_psPanels + 4, g_SystemInfo + 6, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 125), 100, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),

While g_SystemInfo + 4 would point to the below?

CanvasStruct(g_psPanels + 4, g_SystemInfo + 5, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 100), 100, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0), // This was the last populated line before v2.16.

Can you show a picture of your LCD screen. It will be easier to see what is going on?

I want to inform you that I'm on vacation and will not be able to fully respond until next Wednesday. 

My question is about what happens on the lines g_SystemInfo + 5, g_SystemInfo + 6, and g_SystemInfo + 7.  The number 1 appears on those lines, but the text TANK ID: does not appear 3 times.  I am including a picture.

Thanks.

I think the picture did not get added.  Let me try again.

What I was saying is that you have the below three lines of code to print TANK ID. 

CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.
CanvasTextSet(g_SystemInfo + 6, TankIDBuf);
CanvasTextSet(g_SystemInfo + 7, TankIDBuf);

Let's look at the last line which is CanvasTextSet(g_SystemInfo + 7, TankIDBuf); where you reference the 7th element of the g_SystemInfo[] structure. Isn't the 7th element corresponding to the below canvas structure? In this structure the text is """, not "TANK ID:". 

CanvasStruct(g_psPanels + 4, 0, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 100), (BG_MIN_Y + 100) , 200, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),

Why don't you for experiment move the three TANK ID statements to the top of the LCD. Can you see all three or only one of them?

I think we are making progress, but I just don't understand it all yet.  I know how to use printf, and I know how to use sprintf.  How do I get something on the next line of the display?  How do I put something at the top of the display?

Why don't you try below and what do you see? I will also suggest you refer to the examples in C:\ti\TivaWare_C_Series-2.2.0.295\examples\boards\dk-tm4c129x\lang_demo and C:\ti\TivaWare_C_Series-2.2.0.295\examples\boards\dk-tm4c129x\grlib_demo.

FROM: 

CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.
CanvasTextSet(g_SystemInfo + 6, TankIDBuf);
CanvasTextSet(g_SystemInfo + 7, TankIDBuf);

TO:

CanvasTextSet(g_SystemInfo + 4, TankIDBuf); // This was the last line before v2.16.
CanvasTextSet(g_SystemInfo + 5, TankIDBuf);
CanvasTextSet(g_SystemInfo + 6, TankIDBuf);

Also change the below.

FROM: // In your original code snippet above.

CanvasStruct(g_psPanels + 4, g_SystemInfo + 5, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 100), 100, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0), // This was the last populated line before v2.16.
CanvasStruct(g_psPanels + 4, g_SystemInfo + 6, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 125), 100, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 7, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 150), 100, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),
CanvasStruct(g_psPanels + 4, 0, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 100), (BG_MIN_Y + 100) , 200, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),

TO:

CanvasStruct(g_psPanels + 4, g_SystemInfo + 5, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 100), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0), // This was the last populated line before v2.16.
CanvasStruct(g_psPanels + 4, g_SystemInfo + 6, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 125), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 7, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 150), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),

CanvasStruct(g_psPanels + 4, 0, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 100), (BG_MIN_Y + 100) , 200, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),

When I made the changes suggested, TANK ID: went away completely, so that's worse than before.  What I'm trying to understand is why TANK ID: does not show up on all 3 lines.

Can you show your code again. Your screen does not seem to match your code, not just the three TANK ID lines. 

Which line of code is supposed to display "SYSTEM INFO MENU"

Which line of code is supposed to display "SOFTWARE REV 9.99". Your SoftwareRev[] has the string for SOFTWARE REV 2.16"

Which line of code is supposed to display "DATE: March 26, 2024". Your SoftwareRev[] has the string for "DATE: MAR/11/2024",

Which line of code is supposed to display "COPYRIGHT SII-2024". It is nowhere to be found in your pasted code. 

This declaration is in my variables file, now updated with a new date.

char *SoftwareRev[] = 
{
        "SOFTWARE REV 9.99", 
         "DATE: April 2, 2024", 
          " ", 
          "COPYRIGHT SII-2024" 

};

Then we have

void OnSystemInfoBtnPress(tWidget *psWidget)
{
     g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
     CanvasTextSet(g_SystemInfo + 0, SoftwareRev[0]);
     CanvasTextSet(g_SystemInfo + 1, SoftwareRev[1]);
     CanvasTextSet(g_SystemInfo + 2, SoftwareRev[2]);
     CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);
     CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.

     DrawBaseMenu();
     PlayClick(); // Play the key click sound

}

Mark Sheats said:

void OnSystemInfoBtnPress(tWidget *psWidget)
{
     g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
     CanvasTextSet(g_SystemInfo + 0, SoftwareRev[0]);
     CanvasTextSet(g_SystemInfo + 1, SoftwareRev[1]);
     CanvasTextSet(g_SystemInfo + 2, SoftwareRev[2]);
     CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);
     CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.

     DrawBaseMenu();
     PlayClick(); // Play the key click sound

}

Thanks for the updated code. But where are the lines of code to print the 2nd and 3rd "TANK ID"? I only see in the code where you call  CanvasTextSet(g_SystemInfo + 5, TankIDBuf) once. 

Sorry, I had commented them out to go back to a normal display.

void OnSystemInfoBtnPress(tWidget *psWidget)
{
// User_Command = TEST_MENU;
// Display_Password_Screen();
g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
CanvasTextSet(g_SystemInfo + 0, SoftwareRev[0]);
CanvasTextSet(g_SystemInfo + 1, SoftwareRev[1]);
CanvasTextSet(g_SystemInfo + 2, SoftwareRev[2]);
CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);
CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.
// CanvasTextSet(g_SystemInfo + 6, TankIDBuf);
// CanvasTextSet(g_SystemInfo + 7, TankIDBuf);

But back to this test case would be

void OnSystemInfoBtnPress(tWidget *psWidget)
{
// User_Command = TEST_MENU;
// Display_Password_Screen();
g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
CanvasTextSet(g_SystemInfo + 0, SoftwareRev[0]);
CanvasTextSet(g_SystemInfo + 1, SoftwareRev[1]);
CanvasTextSet(g_SystemInfo + 2, SoftwareRev[2]);
CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);
CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.
CanvasTextSet(g_SystemInfo + 6, TankIDBuf);
CanvasTextSet(g_SystemInfo + 7, TankIDBuf);

Since there is a 1 in TankIDBuf, that always shows, as in the picture, but Tank ID: only shows up one time.

With the following code, I would have thought it would appear 3x.

tCanvasWidget g_SystemInfo[] =
{
CanvasStruct(g_psPanels + 4, g_SystemInfo + 1, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 5), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT , ClrBlack, ClrWhite, ClrWhite,g_psFontCmss20b, "", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 2, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 25), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b,"", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 3, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 50), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 4, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 75), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrYellow, g_psFontCmss20b, "", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 5, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 100), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0), // This was the last populated line before v2.16.
CanvasStruct(g_psPanels + 4, g_SystemInfo + 6, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 125), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 7, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 150), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID: ", 0, 0),
CanvasStruct(g_psPanels + 4, 0, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 100), (BG_MIN_Y + 100) , 200, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),
};

Hi,

  I can't really spot anything in your code that will suggest why two lines of TANK ID are missing in the display. What I'm not clear is why you are starting the first TANK ID display using CanvasTextSet(g_SystemInfo + 5, TankIDBuf) with g_SystemInfo + 5 rather than g_SystemInfo + 4. If you look at your  g_SystemInfo structure, the line with the first TANK ID should be g_SystemInfo + 4 unless I'm missing something. 

  I can only suggest you do some experiments to diagnose the problem.

 Experiment 1:

   Only call two TANK ID like below. Do you see  the second TANK ID missing?

void OnSystemInfoBtnPress(tWidget *psWidget)
{
// User_Command = TEST_MENU;
// Display_Password_Screen();
g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
CanvasTextSet(g_SystemInfo + 0, SoftwareRev[0]);
CanvasTextSet(g_SystemInfo + 1, SoftwareRev[1]);
CanvasTextSet(g_SystemInfo + 2, SoftwareRev[2]);
CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);
CanvasTextSet(g_SystemInfo + 5, TankIDBuf); // This was the last line before v2.16.
CanvasTextSet(g_SystemInfo + 6, TankIDBuf);
// CanvasTextSet(g_SystemInfo + 7, TankIDBuf); // Comment out this line

Experiment 2:

Change the first  4 elements of g_SystemInfo as follows. I want to know what is the effect when you display the first 4 lines on the display. I will expect the display to show something like below. What does it actually show?

  TANK ID: SOFTWARE REV 9.99
  TANK ID: DATE: April 2, 2024
  TANK ID:       
  TANK ID: COPYRIGHT SII-2024

FROM:

CanvasStruct(g_psPanels + 4, g_SystemInfo + 1, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 5), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT , ClrBlack, ClrWhite, ClrWhite,g_psFontCmss20b, "", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 2, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 25), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b,"", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 3, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 50), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 4, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 75), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrYellow, g_psFontCmss20b, "", 0, 0),

TO:

CanvasStruct(g_psPanels + 4, g_SystemInfo + 1, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 5), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT , ClrBlack, ClrWhite, ClrWhite,g_psFontCmss20b, "TANK ID:", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 2, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 25), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b,"TANK ID", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 3, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 50), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrWhite, g_psFontCmss20b, "TANK ID", 0, 0),
CanvasStruct(g_psPanels + 4, g_SystemInfo + 4, 0, &g_sKentec320x240x16_SSD2119, (BG_MIN_X + 5), (BG_MIN_Y + 75), 280, 25, CANVAS_STYLE_TEXT | CANVAS_STYLE_TEXT_LEFT, ClrBlack, ClrWhite, ClrYellow, g_psFontCmss20b, "TANK ID", 0, 0),

Experiment 3:

With the above g_SystemInfo changed, move the TANK ID call to the first lines in your OnSystemInfoBtnPress. What do you see on the display. Do you still miss two TANK ID?

void OnSystemInfoBtnPress(tWidget *psWidget)
{
// User_Command = TEST_MENU;
// Display_Password_Screen();
g_ui32Panel = SYSTEM_INFO_SCREEN; // Here we print the system info screen out line by line
CanvasTextSet(g_SystemInfo + 0, TankIDBuf);
CanvasTextSet(g_SystemInfo + 1, TankIDBuf);
CanvasTextSet(g_SystemInfo + 2, TankIDBuf);
CanvasTextSet(g_SystemInfo + 3, SoftwareRev[3]);