3 Bugs Found in motorware_1_01_00_11

1. I think our code in _11 and _12 is correct.

Positive feedback (5.2.2.1) - for example the DRV8312 based kits:

bias -= OFFSET_getOffset(obj->offsetHandle_I[cnt]);

  pAdcData->I.value[0] = -value;

Negative feedback (5.2.2.2) - for example the HVMTR kit:

bias += OFFSET_getOffset(obj->offsetHandle_I[cnt]);

pAdcData->I.value[0] = value;

2. Let me look into this one

3. I think this is accomplished by the NonIntTriggersSOC being set in the AdcCalConversion, but let me double check.

Criss,

Since I am using DRV8312 chips in my board, I used the reference code for the DRV8312 Kit as the starting point for my code.

1- Since the code is right for the HVRMTR Kit, I think you should update the manual to the additional required difference if running 5.2.2.2 as done inside the HVRMTR code. I would save people like me running our hardware a a little time.

For (2) and  (3) reported above,  please assume that I am using the code for the DRV8312 as basis of my ported code.

Thanks

Saed

Saed,

1. the code is correct for all inverters. I do agree that in 5.2.2 we need to mention that if you use the bias -= you also need to use the -value when you save the current.  We do this in the DRV8312 code.  This has been captured to update next opportunity.

2 & 3 I have our ADC guys looking at it....

Saed,

Thanks for pointing these out.  Still looking at #3.

We have confirmed #2.

ADC_disableInt() in adc.c error 

Saed's fix will work, or replace the giant compound statement with something simpler like:

uint16_t clearValue = (intNumber & 0x1) ? (1 << 13) : (1 << 5); //different bit cleared if high or low interrupt in register

Saed,

On #3 I don't think there is an error.

There may be code missing to do what YOU want to do (add more ADC SOC channels), but what we have done is fine.

The SOCs are all all initialized in the HAL_AdcCalConversion, with the last section clearing the SOC trigger on each channel:

ADC_setupSocTrigSrc(obj->adcHandle, ADC_SocNumber_15, ADC_NoIntTriggersSOC);

And then in HAL_setupAdcs we configure the ADC SOCs we want to use...in this case just the currents and voltages for the motor control.

If you want to add additional ADC SOCs here, with different trigger sources, you can.

Am I misunderstanding what you want to do?

Saed,

You're right, it looks like that was cleaned up in _12.

If you run MotorWare.exe there is a Revision History, but it doesn't mention this one specifically.  I believe starting in _13 we are going to post a more thorough listing of changes.

We need to look more at this topic though, it looks lke there are some things we can/should do to clean up the HAL (DRV) usage of the ADC drivers.  Hopefully you'll see an update in _13.

Saed,

here is a complete list for _12, we should start providing this in _13