SIMPLELINK-MSP432-SDK: SPI DMA driver doesn't disable module when calling SPIMSP432DMA_close()

Alvaro Muro

Hi,

I'm using a MSP432P4111 with SDK 3.40.1.02 and Code Composer Version: 10.1.0.00010.

I noticed that SPI DMA driver (SPIMSP432DMA.c) doesn't disable the SPI module when calling SPIMSP432DMA_close(). I see no calls to MAP_SPI_disableModule(hwAttrs->baseAddr) to set UCSWRST register bit.

In other drivers such as I2C this bit is set when closing the driver in order to disable the module.

Should my application code disable it or is this done at a different place I didn't see yet?

Many thanks for your attention,

Álvaro

over 3 years ago

0 James Evans over 3 years ago

TI__Mastermind 49692 points

Hi Alvaro,

The intent of the SPIMSP432DMA_close() function may have been to just close the DMA but leave the SPI enabled. If you'd like to disable the SPI module itself, you could try using the SPI_close() function.

Regards,

James

0 Alvaro Muro over 3 years ago in reply to James Evans

Prodigy 235 points

Thanks James,

I am calling SPI_close() function, which calls SPIMSP432DMA_close().

/*
 *  ======== SPI_close ========
 */
void SPI_close(SPI_Handle handle)
{
    handle->fxnTablePtr->closeFxn(handle);
}

0 James Evans over 3 years ago in reply to Alvaro Muro

TI__Mastermind 49692 points

Hi Alvaro,

I see that now. I'm not sure why the MAP_SPI_disableModule() function is not called by SPIMSP432DMA_close(). I suspect this may be a bug, so I'll go ahead and report it. Thanks for pointing this out.

Regards,

James

0 Alvaro Muro over 3 years ago in reply to James Evans

Prodigy 235 points

Hi James,

Thanks, OK, I will then call MAP_SPI_disableModule() from my application code.

Kind regards,

Álvaro

Arm-based microcontrollers

Arm-based microcontrollers forum

SIMPLELINK-MSP432-SDK: SPI DMA driver doesn't disable module when calling SPIMSP432DMA_close()