I need to use RSSI(LQI) but something wrong

Can you show me the source code which has this compile error?

void zb_HandleKeys( uint8 shift, uint8 keys )
{
uint8 startOptions;
uint8 logicalType;
afIncomingMSGPacket_t *pkt;
uint8 msgLqi = pkt->LinkQuality;

if ( keys & HAL_KEY_SW_6 )
{
if ( myAppState == APP_INIT )
{
// 在”保持“狀態，按下SW6, 該設備將作為一個協調器。
zb_ReadConfiguration( ZCD_NV_LOGICAL_TYPE, sizeof(uint8), &logicalType );
if ( logicalType != ZG_DEVICETYPE_ENDDEVICE )
{
logicalType = ZG_DEVICETYPE_COORDINATOR;
zb_WriteConfiguration(ZCD_NV_LOGICAL_TYPE, sizeof(uint8), &logicalType);
}

// Do more configuration if necessary and then restart device with auto-start bit set
// write endpoint to simple desc...dont pass it in start req..then reset

zb_ReadConfiguration( ZCD_NV_STARTUP_OPTION, sizeof(uint8), &startOptions );
startOptions = ZCD_STARTOPT_AUTO_START;
zb_WriteConfiguration( ZCD_NV_STARTUP_OPTION, sizeof(uint8), &startOptions );
zb_SystemReset();

}
else
{
/*
// Initiate a binding   (light)
zb_AllowBind( myAllowBindTimeout );
*/

// Send the command to toggle light   (switch)
if( msgLqi > 130)
{
zb_SendDataRequest( 0xFFFE, TOGGLE_LIGHT_CMD_ID, 0,
(uint8 *)NULL , myAppSeqNumber, 0, 0 );
}

}
}
if ( keys & HAL_KEY_SW_3 )
{
if ( myAppState == APP_INIT )
{
// 在“保持”狀態，按下SW3, 該設備將作為一個路由器。
zb_ReadConfiguration( ZCD_NV_LOGICAL_TYPE, sizeof(uint8), &logicalType );
if ( logicalType != ZG_DEVICETYPE_ENDDEVICE )
{
logicalType = ZG_DEVICETYPE_ROUTER;
zb_WriteConfiguration(ZCD_NV_LOGICAL_TYPE, sizeof(uint8), &logicalType);
}

zb_ReadConfiguration( ZCD_NV_STARTUP_OPTION, sizeof(uint8), &startOptions );
startOptions = ZCD_STARTOPT_AUTO_START;
zb_WriteConfiguration( ZCD_NV_STARTUP_OPTION, sizeof(uint8), &startOptions );
zb_SystemReset();
}
else
{
zb_BindDevice( TRUE, TOGGLE_LIGHT_CMD_ID, NULL );
}
}
/* if ( keys & HAL_KEY_SW_1 )
{

}

if ( keys & HAL_KEY_SW_2 )
{

}
*/

--------------------------------------------------------------------------------------

I want to use msgLqi to calculate the distance, but it show me the warning .

These code is in the simpleapp light experiment.

Can you give so suggest?  thx~

The problem is on the following two lines.
afIncomingMSGPacket_t *pkt;
uint8 msgLqi = pkt->LinkQuality;

You only claim a afIncomingMSGPacket_t pointer pkt and assign pkt->LinkQuality to msgLqi but you don't assign value to pkt->LinkQuality.

Can you show me how to write the code to assign value to pkt->LinkQuality?
I try some ways but no success.

afIncomingMSGPacket_t data is only available in zclXXX_event_loop so you need to assign it there.

If I assign this , the LQI value continue refresh?
Because I want immediate LQI value to control light.
Do I need to send packet to router?

If you update LQI from zclXXX_event_loop, it is the LQI of latest received message.

Can you show me how to assign pkt->LinkQuality in zclXXX_event_loop ?
I try haed but it's not useful . plz = (

Use SampleLight as example, you can add the following codes in red.

afIncomingMSGPacket_t pkt;

uint16 zclSampleLight_event_loop( uint8 task_id, uint16 events )

{

 afIncomingMSGPacket_t *MSGpkt;

 (void)task_id;  // Intentionally unreferenced parameter

 if ( events & SYS_EVENT_MSG )

 {

   while ( (MSGpkt = (afIncomingMSGPacket_t *)osal_msg_receive( zclSampleLight_TaskID )) )

   {

     pkt.LinkQuality=MSGpkt->LinkQuality;

     switch ( MSGpkt->hdr.event )

     {

I write pkt.LinkQuality = pkt->LinkQuality;
it shows me => error : expression must have struct or union type
what is this mean?

You should use "afIncomingMSGPacket_t pkt;" instead of "afIncomingMSGPacket_t *pkt;".

sorry, I have some trouble  can you please explain about these...


    while ( (MSGpkt = (afIncomingMSGPacket_t *)osal_msg_receive( zcl_TaskID )) )

--> 

a value of type "struct <unnamed> *" cannot be assigned to an entity of type "struct <unnamed>" 

      switch ( MSGpkt->hdr.event )

-->

expression must have arithmetic or pointer type 

expression must have pointer type 

      osal_msg_deallocate( (uint8 *)MSGpkt );

-->

invalid type conversion 

What is your modification?

afIncomingMSGPacket_t pkt;
uint16 zclSampleLight_event_loop( uint8 task_id, uint16 events )
{
afIncomingMSGPacket_t MSGpkt;

if ( events & SYS_EVENT_MSG )
{
while ( (MSGpkt = (afIncomingMSGPacket_t *)osal_msg_receive( zcl_TaskID )) )
{
switch ( MSGpkt->hdr.event )
{
case KEY_CHANGE:
break;

default:
break;
}


osal_msg_deallocate( (uint8 *)MSGpkt );
}

// return unprocessed events
return (events ^ SYS_EVENT_MSG);
}

if ( events & MY_REPORT_RSSI_EVT )
{

return ( events ^ MY_REPORT_RSSI_EVT );
}

// Discard unknown events
return 0;
}

This is a fundamental C pointer problem. You have to change "afIncomingMSGPacket_t MSGpkt;" to "afIncomingMSGPacket_t *MSGpkt;".

afIncomingMSGPacket_t *pkt;
uint16 zclSampleLight_event_loop( uint8 task_id, uint16 events )
{
afIncomingMSGPacket_t *MSGpkt;

if ( events & SYS_EVENT_MSG )
{
while ( (MSGpkt = (afIncomingMSGPacket_t *)osal_msg_receive( zcl_TaskID )) )
{


************* pkt.LinkQuality=MSGpkt->LinkQuality;*****************
switch ( MSGpkt->hdr.event )
{
case KEY_CHANGE:
break;

case AF_INCOMING_MSG_CMD:
SampleApp_MessageMSGCB( MSGpkt );
break;

default:
break;
}


// Release the memory
osal_msg_deallocate( (uint8 *)MSGpkt );
}

// return unprocessed events
return (events ^ SYS_EVENT_MSG);
}

if ( events & MY_REPORT_RSSI_EVT )
{

return ( events ^ MY_REPORT_RSSI_EVT );
}

// Discard unknown events
return 0;
}


---------------------------------------------------------------------------


pkt.LinkQuality=MSGpkt->LinkQuality;
It says expression must have struct or union type
How can I do? I don't understand that .

Again, this is pointer issue. You have to change "afIncomingMSGPacket_t *pkt;" to "afIncomingMSGPacket_t pkt;" since you use pkt.LinkQuality not pkt->LinkQuality.

Sorry, can you explain clearly
I don't understand the relationship of both

This is about C programming and out of scope of this E2E forum. I suggest you can read some C programming book to understand the problem better.

OK! I can solve the question of the zclSampleLight_event_loop .
Then how can I get the LQI value in " void zb_ReceiveDataIndication"

Which Z-Stack and example do you have this zb_ReceiveDataIndication?

ZStack-1.4.2-1.1.0 and in simpleApp ,I want to use LQI to control light in this simpleApp

Sorry, I have no ideal . Can you give me a example ?
How can I get LQI Value in SAPI_ProcessEvent?

Add the following code in red to SAPI_ProcessEvent.

afIncomingMSGPacket_t pkt;

UINT16 SAPI_ProcessEvent( byte task_id, UINT16 events )

{

 osal_event_hdr_t *pMsg;

 afIncomingMSGPacket_t *pMSGpkt;

 afDataConfirm_t *pDataConfirm;

 if ( events & SYS_EVENT_MSG )

 {

   pMsg = (osal_event_hdr_t *) osal_msg_receive( task_id );

   while ( pMsg )

   {

     switch ( pMsg->event )

     {

       case ZDO_CB_MSG:

         SAPI_ProcessZDOMsgs( (zdoIncomingMsg_t *)pMsg );

         break;

       case AF_DATA_CONFIRM_CMD:

         // This message is received as a confirmation of a data packet sent.

         // The status is of ZStatus_t type [defined in ZComDef.h]

         // The message fields are defined in AF.h

         pDataConfirm = (afDataConfirm_t *) pMsg;

         SAPI_SendDataConfirm( pDataConfirm->transID, pDataConfirm->hdr.status );

         break;

       case AF_INCOMING_MSG_CMD:

         pMSGpkt = (afIncomingMSGPacket_t *) pMsg;

         pkt.LinkQuality=pMSGpkt->LinkQuality;

         SAPI_ReceiveDataIndication( pMSGpkt->srcAddr.addr.shortAddr, pMSGpkt->clusterId,

                                   pMSGpkt->cmd.DataLength, pMSGpkt->cmd.Data);

         break;

Entry "ha_ClusterConvertTable" in module OSAL_Tasks
What is this mean?

This seems an obsolete data structure used in obsolete Z-Stack. I don't have such old Z-Stack to check so I cannot give you comments.