TMS320F28335:Misra 10.3 Problem - DELAY_US(A)

Youn jin

Part Number: TMS320F28335
Other Parts Discussed in Thread: C2000WARE

Hi all,

Checking MISRA C:2012 in test code.
I'm having a problem with the library function DELAY_US, asking for help.

// DO NOT MODIFY THIS LINE.
#define DELAY_US(A) DSP28x_usDelay(((((long double) A * 1000.0L) / (long double)CPU_RATE) - 9.0L) / 5.0L)
extern void DSP28x_usDelay(Uint32 Count);

A long double type variable is calculated and becomes a Uint32 Count.
Violating MISRA_C:2012 10.3 with this issue.
Any solution for this?

Add to,

Should I put an unsigned int variable or a long double variable at position A?

over 4 years ago

0 JohnS over 4 years ago

TI__Guru**** 162885 points

Our compiler expert is out until Tuesday. He can take a look when he returns.

Regards,

John

+1 George Mock over 4 years ago

TI__Guru**** 251110 points

I presume this code ...

Youn jin said:
// DO NOT MODIFY THIS LINE.
#define DELAY_US(A) DSP28x_usDelay(((((long double) A * 1000.0L) / (long double)CPU_RATE) - 9.0L) / 5.0L)
extern void DSP28x_usDelay(Uint32 Count);

... comes from C2000Ware. While I don't know for certain, it is likely that C2000Ware header files are not tested or documented to build MISRA clean.

One solution to consider is to add a cast that makes the conversion from long double to Uint32 explicit ...

#define DELAY_US(A) DSP28x_usDelay((Uint32) (((((long double) A * 1000.0L) / (long double)CPU_RATE) - 9.0L) / 5.0L))

Thanks and regards,

-George

0 Youn jin over 4 years ago in reply to George Mock

Prodigy 20 points

As per your advice, I modified the code as follows :

#define DELAY_US(A) DSP28x_usDelay((Uint32)((((((long double) A * 1000.0L) / (long double)CPU_RATE) - 9.0L))/5.0L))

The problem Misra 10.3 is solved. By the way, can I fix this code that says "DO NOT MODIFY THIS LINE"?

Thanks!

0 George Mock over 4 years ago in reply to Youn jin

TI__Guru**** 251110 points

Youn jin said:
can I fix this code that says "DO NOT MODIFY THIS LINE"?

Since this question is specific to C2000Ware, I cannot answer it. Please start a new thread in the C2000 device forum. Or, if you prefer, I can notify those experts about this thread.

Thanks and regards,

-George

0 Youn jin over 4 years ago in reply to George Mock

Prodigy 20 points

I start a new thread in the C2000 device forum. Thank you!

C2000™︎ microcontrollers

C2000 microcontrollers forum

TMS320F28335:Misra 10.3 Problem - DELAY_US(A)