TMS320F28P550SJ: ADC_enableSampleCAPReset() in the drilverlib does not seem correct?

Wayne Huang

Genius 16835 points

Part Number: TMS320F28P550SJ
Other Parts Discussed in Thread: C2000WARE

Tool/software:

Hi champs,

I am asking this for our customer.

The user found by using the driverlib API in C2000ware V5.04 like below

ADC_enableSampleCAPReset(ADCB_BASE, ADC_SOC_NUMBER1);

But the result was incorrect because the upper 16-bit part (TRIGSEL etc.) was modified as zero unexpectedly.

If the user uses bit-field format like below, then it works.

AdcbRegs.ADCSOC1CTL.bit.SAMPCAPRESETDISABLE = 0;

Would you please help look into ADC_enableSampleCAPReset() and ADC_disableSampleCAPReset()?

For example, does it make sense to define below as 0x200U rather than 0x00000200 in uint32_t?

#define ADC_SOC0CTL_SAMPCAPRESETDISABLE 0x200U // SOC0 Sample Cap Reset Select

over 1 year ago

0 Nilesh Khanna over 1 year ago

TI__Intellectual 2270 points

HI Wayne,

Wayne Huang said:
C2000ware V5.04

Let me check with the SDK version and get back to you.

BR,

Nilesh

0 Wayne Huang over 1 year ago in reply to Nilesh Khanna

TI__Genius 16835 points

Hi Nilesh,

FYI.

I tried to modify codes as below and it works.

ADC_enableSampleCAPReset(uint32_t base, ADC_SOCNumber socNumber)
{
    uint32_t ctlRegAddr;

    //
    // Check the arguments.
    //
    ASSERT(ADC_isBaseValid(base));

    //
    // Calculate address for the SOC control register.
    //
    ctlRegAddr = base + ADC_SOCxCTL_OFFSET_BASE + ((uint32_t)socNumber * 2U);

    //
    // Enable the sample capacitor reset after each conversion.
    //
    EALLOW;
    HWREG(ctlRegAddr) &= ~((uint32_t)ADC_SOC0CTL_SAMPCAPRESETDISABLE);
    EDIS;
}

+1 Masood Raza over 1 year ago in reply to Wayne Huang

TI__Prodigy 340 points

Hi, Wayne. Yes, this is a valid issue. It will be fixed in the next release of C2000ware.

Thanks and regards,
Masood Raza

C2000™︎ microcontrollers

C2000 microcontrollers forum

TMS320F28P550SJ: ADC_enableSampleCAPReset() in the drilverlib does not seem correct?