This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

28335 register definition structures: DSP2833x_Spi.h

There seems to be some inconsistencies in the SPI register definitions.

SPIFFRX.bit.RXFIFORESET is the RX FIFO reset.

But SPIFFTX.bit.TXFIFO is the TX FIFO reset... shouldn't this be called TXFIFORESET?

Or even better, please make them consistent with the I2C FIFO reset bits (called RXFFRST and TXFFRST).

 

// TI File $Revision: /main/3 $
// Checkin $Date: April 17, 2008   11:08:27 $
//###########################################################################
//
// FILE:   DSP2833x_Spi.h
//
// TITLE:  DSP2833x Device SPI Register Definitions.
//
//###########################################################################
// $TI Release: DSP2833x/DSP2823x C/C++ Header Files V1.31 $
// $Release Date: August 4, 2009 $
//###########################################################################

[...]

struct  SPIFFTX_BITS {       // bit    description
   Uint16 TXFFIL:5;          // 4:0    Interrupt level
   Uint16 TXFFIENA:1;        // 5      Interrupt enable
   Uint16 TXFFINTCLR:1;      // 6      Clear INT flag
   Uint16 TXFFINT:1;         // 7      INT flag
   Uint16 TXFFST:5;          // 12:8   FIFO status
   Uint16 TXFIFO:1;     // 13     FIFO reset
   Uint16 SPIFFENA:1;        // 14     Enhancement enable
   Uint16 SPIRST:1;          // 15     Reset SPI
};

  • Jason,

    Thank you for pointing this out.  I absolutely agree the name could be much more descriptive.  This module has been around for a long time and the name came from legacy to be compatible with other software.  I will take the feedback you've provided back to the team. 

    Regards,

    Lori