BQ25790: Need a Linux Backport Guide for BQ25790

Dear Jack,

I am looking into this issue and will get back to you next week.

Thanks,

Mike Emanuel

Hi Michael

Thanks for quick response.

We also would like to know how to test driver via command line interface at least. i.e cat command..  

Also hope to get a generic porting guide for Analog Product's Linux Driver. even the product has the relevant device driver for certain kernel version. . 

Hello,

Will update next week!

Thanks,

Mike Emanuel

Dear Jack

We had used the driver on linux4.19 and it works. Can you show me what problem did you meet?

Jack,

We await your feedback.

Thanks,

Mike Emanuel

Hi Michael 

Thanks for your kind reply.

Customer observed driver failed to report issue with below log.

power_supply bq25790-battery: driver failed to report `(null)' property: -22

They said that the kernel version is 4.1 without mentioning debugging environment. I am checking details.

Please also let us know details how to verify the functionality. 

Here is attachment for their code modified for their compilation. Please look into the code if they made appropriate changes.

Thanks

linux.zip

Regards, 

Jack 

Hi Michael

Thanks for your kind reply.

Customer need the driver file for Kernel 4.1 version. There're maybe a lot of changes btw 4.1. and 4.19. I observed mutex handling regarding first uevent of power supply  was not properly done before Kernel 4.1.3 version.

Suppopsed the followings are the relevant post.

• https://linux.kernel.narkive.com/z7E5M2NY/rfc-rft-v2-1-2-power-supply-fix-null-pointer-dereference-during-bq27x00-battery-probe
• https://elixir.bootlin.com/linux/v4.1.3/source/drivers/power/power_supply_core.c

Thanks.

Dear Jack

I still don't understand what actual problem did they meet. Maybe the "driver failed to report `(null)' property: -22" log can be ignored.

Dear Honghui

Customer has an kernel panic issue when they observed the log message mentioned above. Thanks

Dear Michael and Honghui Duan 

Their kernel version is 4.1.15. 

Customer reported the kernel panic issue could be resolved by following what you said. 

And DTS/DTSI is configured as below. then the interrupt working looks fine.

&i2c1 {

           clock_frequency = <100000>;

           pinctrl-names = "default";

           pinctrl-0 = <&pinctrl_i2c1>;

           status = "okay";

           bq25790@6b {

                     compatible = "ti,bq25790";

                     reg = <0x6b>;

                     ti,irq-gpio = <&gpio2 12 GPIO_ACTIVE_LOW>;

           };

};

In addition, they found a difference btw kernel 4.4 and kernel 5.x driver of bq25790_charger.c.

Please let me know what could be appropriate solution for 4.1.15 kernel condition.

static int bq25790_charger_get_property(struct power_supply *psy,

                                          enum power_supply_property psp,

                                          union power_supply_propval *val)

{

~~~~~~~

           case POWER_SUPPLY_PROP_HEALTH:

                     if (state.fault_1 & (BQ25790_OTG_OVP | BQ25790_VSYS_OVP))           // kernel 4.4

                     //if (state.fault_1 && (BQ25790_OTG_OVP | BQ25790_VSYS_OVP))       // kernel 5.x

                                val->intval = POWER_SUPPLY_HEALTH_OVERVOLTAGE;

                     else

                                val->intval = POWER_SUPPLY_HEALTH_GOOD;

Please find attachment of their modified code. We need your feedback on the modification for Kernel 4.1.15 version. linux-driver.zip

Please give feedback on the queries below. 

- Code Review (attached linux-driver.zip) : Customer's backport from 5.9 to 4.1.15.

- DTS/DTSI Review : Plz see above blue.

- Recommendation about Bit-operator and Logical And Operator : Plz see above yellow background.

- How to check if the driver works

Thanks.

Regards, 

Jack 

Dear Jack,

We will be getting back to you shortly.

Thanks,

Mike Emanuel

Dear Jack

- Code Review (attached linux-driver.zip) : Customer's backport from 5.9 to 4.1.15.

It seems OK for me.

- DTS/DTSI Review : Plz see above blue.

You can reference: github.com/.../kona-hdk-overlay-bq25790.dts

- Recommendation about Bit-operator and Logical And Operator : Plz see above yellow background.

Please use the line with //kernel 4.4

- How to check if the driver works

You've already make sure the interrupt works, so the driver works.

Dear

Is there any command-line interface to check values what BQ updated? i.e. cat /sys/....

Thanks.

Regards, 

Jack

Dear Honghui

Thanks for your kind answer.

Thank you Honghui for you assistance!

Jack, glad you found you answer!

Thank you too

You're welcome!