AWR2944P: undeclared identifier 'CAN_UNINIT' and 'CAN_READY'

Hello Saswat,

According to autosar specification only below types should be part of Can_GeneralTypes.h. So Can_DriverStateType should be added in your driver code for example we have added in Can_Priv.h not in Can_GeneralTypes.h 

Please refer the below image 

Can you please check.

BR,

Prashant Singh Tomar

Hello Prashant,

Understood we will take review these changes and give feedback by next week.

Also regarding the null pointer, I need a quick feedback from you:

Since this is a build error that occurs only on customer end and cannot be reproduced on ours, Please let us know in which file of theirs the NULL_PTR macro is defined (provide the full path)

One more clarity needed is that even in our declarations of NULL_PTR MACRO, we have provided the guard macro to not define it again if its already defined, like below
 
#ifndef NULL_PTR
#define NULL_PTR ((void *)0)
#endif

Please check with your team if your team if their base plugin also has the same guard macro and if not if they can add the guard to resolve this issue? 

Regards,
Saswat Kumar

Hello Prashant,

Can I get an answer by today on this as today is the last day I can take any changes.

Regards,
Saswat Kumar

Hello Saswat,

Sorry for the late reply — I was on leave.

Actually, hal_stdtypes.h is included first, where NULL_PTR is defined. After that, Compiler_Common.h is included from the base plugin, where it checks whether NULL_PTR is already defined. If it is, it throws an error and then attempts to define NULL_PTR.

I also checked internally, and as per AUTOSAR guidelines, NULL_PTR should be defined in this manner.

Please refer to the image below:

BR,

Prashant Singh Tomar

Hello Prashant,

For our examples we definitely need this NULL_PTR declaration or else our examples will crash, the only thing we can do is move it from hal_stdtypes.h to compiler.h . Is your compiler_common,h the same as compiler.h or is it a separate file, can you shed some light on what it is actually?
What do you recommend because we need it for our usability and the only way I see is if you can omit it from your software currently.

Regards,
Saswat Kumar

Hello Saswat,

Yes, we can implement this workaround.

BR,

Prashant Singh Tomar

Hello Prashant,

Then is it okay to assume that you will remove the function or that we need to move from hal_stdtypes.h to compiler .h?

Regards,
Saswat Kumar

Hello Saswat,

Yes we are fine with this workaround.

BR,

Prashant Singh Tomar

Hello Prashant,

Just trying to confirm which is the workaround
This is the one right: You are going to remove the function right?

Regards,
Saswat Kumar

Hello Saswat,

For us, we don’t need NULL_PTR in hal_stdtypes.h as it is already defined in Compiler_Common.h. Removing it from hal_stdtypes.h resolved our issue.

In your earlier comment, you mentioned that you need it for your examples. In that case, it would be better to move the definition from hal_stdtypes.h to compiler.h.

BR,
Prashant Singh Tomar