If() condition works in CCSV3.3 but not in CCSV5

Hi,

Is "Is_connected(i)" an array?

Regards,

Gautam

Is_connected() is a function, taking 32bit interger as an input, returning a 32 bits integer as an output.

Thanks.

Honghui

Guatam,

In the function "Is_connected()", I have this return statement on a global integer array[ ] , for example ,

{ ;;;  return (array[5] & (1<< shift)); }

This does not work on if(! Is_connected(i))  

 I changed this return statement as

{ int x; ;;;  x = array[5] & (1<<shift); return x;}

Then it works with if (! Is_connect(i))

Does return statement not directly working on array?  What is your means of "Is_connected(i) " an array ?

Honghui

honghui Qi said:

I have codes run correctly in CCSV3.3 but failed in CCSV5. Do not know why.

Which target processor are you working with? What was the version of compiler tools used with CCS 3.3 and what is the version used wtih CCSv5? What is the exact version of CCSv5?

honghui Qi said:

This if statement does not work as expected, when Is_connected() return a non zero integer, if(! Is_connected(i)) will assert the if condition true.

My first suggestion would be to compare the assembly code generated by the two versions and confirm if the compiler is generating incorrect code. for that line of C code? Are you compilng with optimization turned on?
Depending on the version of compiler tools you are using there may be a newer version you could try out as well.

The processor is the F28335, the CCS details are as follows

CCSV3.3.82.13, code generation tools v5.2.6, BIOS 5.33.06

CCSV 5.5.0.00077, compiler version is Ti v6.2.0, DSP/BIOS version 5.42.1.09

No optimization used at all in either case. 

As you suggested, I compared assembly codes,  The last statements (mainly return statement) are almost the same, only one MOV T, *-SP[6] is out of order (I have difficult to cut and paste the codes here). As in the place to call the function, they are different as follows.

in CCSV5 if(! IS_Connected(id))

0644   MOVL ACC, *-SP[4]

7670&221   LCR IS_Connected

ED04    SBF C$L24, NEQ

In CCS3.3, if(!Is_Connected(id))

0644    MOVL ACC, *-SP[4]

7670FC09   LCR Is_Connected

FF58    TEST   ACC

ED04    SBF   4, NEQ

Hope these give you some insight about it.

I have a way to fix it, but I still do not understand it, why this does not work as expected, why my fix make it works.

Honghui

The important question here is whether the code is actually executing incorrectly (ie is it executing parts of the "if" condition that it shouldn't be) or is it just the debugger giving the impression that the execution path is incorrect.

Take a look at the assembly instructions a few instructions prior to the ones you show above. You may be running into the behabior described in these related threads:

http://e2e.ti.com/support/development_tools/code_composer_studio/f/81/p/3431/12177.aspx#12177
http://e2e.ti.com/support/development_tools/code_composer_studio/f/81/p/104696/681164.aspx#681164
http://e2e.ti.com/support/development_tools/code_composer_studio/f/81/p/245623/860054.aspx#860054

If this does not explain the behavior you see and the code is actually executing incorrectly then we would need a small cutdown test case that we can use to reproduce the issue.

Thanks for your reply.

It is not the same problem as you quoted, the problem is the code is actually executing incorrectly, i.e, it execute parts of the if condition that it should not be.  Because of the problem, I debug through and find the problem is on this if statement and debug outcome explained the problem I have when it is free running.

As for the instructions  prior to the ones I showed in the previous post, since this instrunction if()  is the first instruction in another function call, I guess it does some house keeping job before call this function, as follows

FE10        ADDB         SP, #16
30f387:   A046        MOVL         *-SP[6], XAR5
30f388:   1E44        MOVL         *-SP[4], ACC
30f389:   A842        MOVL         *-SP[2], XAR4

260         if(!Is_Connected(id))
30f38a:   0644        MOVL         ACC, *-SP[4]
30f38b:   7670F221    LCR          Is_Connected
30f38d:   ED04        SBF          C$L24, NEQ
261          return(0);
30f38e:   0200        MOVB         ACC, #0
30f38f:   FFEF0222    B            C$L40, UNC
265         SWI_disable();
        C$L24:
30f391:   767175AD    LCR          _SWI_disable

Honghui