CCS/MSP-EXP430F5529LP: Error #18: expected a ")"

Jacob Mercado

Tool/software: Code Composer Studio

#include <msp430.h>
// lab 14: interrupt


void REDblink();
void GREENblink();
void DelayMS();
#define LED_RED BIT0;
#define LED_GREEN BIT7;
#define BUTTON  BIT1;

#pragma vector = PORT1_VECTOR
    __interrupt void Port_1(void){
        if (P1IFG & BUTTON){
            GREENblink();
            P1OUT ^=LED_RED;
            P1IFG &= ~BUTTON;
        }
    }

void main(void){
    WDTCTL = WDTPW | WDTHOLD;
    P1DIR |= LED_RED;
    P4DIR |= LED_GREEN;

    P1REN |= BUTTON;
    P1IES |= BUTTON;
    P1IFG &= ~BUTTON;
    P1IE |= BUTTON;
    _BIS_SR(GIE);
    while (1){
        REDblink();
        DelayMS(500);
        }

    }


void DelayMS(unsigned int ms){
    volatile unsigned int d;
    for (d=ms*100; d>0; d--);
}

void REDblink(){
    P1DIR |= 0x01;
    P1OUT |= 0x01;
    DelayMS(500);
    P1OUT &= 0x00;
}

void GREENblink(){
    P4DIR |= 0x80;
    P4OUT |= 0x80;
    DelayMS(500);
    P4OUT = 0x00;
}

Hi all,

So in my lab that I've been working on recently I keep encountering "Error #18: expected a ")" in line 14 of my code even though me and several of my classmates and lab instructor have tried looking over my code and weren't able to understand why I keep getting this error. I attached the code below.

Thanks.

over 8 years ago

0 George Mock over 8 years ago

TI__Guru**** 252740 points

Here is line 14 ...

        if (P1IFG & BUTTON){

My guess is that some msp430 header file is corrupted, and either P1IFG or BUTTON is incorrect somehow. To see this, build with the option --gen_preprocessor_listing and inspect the resulting .rl file. Please read more about that option in the MSP430 compiler manual. In the .rl file, you can see this line before and after macro expansion. I suspect the problem will be obvious at that point.

Thanks and regards,

-George

0 Sasha Slijepcevic over 8 years ago

TI__Mastermind 37985 points

It could be also that ';' characters at the end of the replacement sequences for macros are creating some unexpected code.

0 Archaeologist over 8 years ago

TI__Guru* 84285 points

You should not have semicolons at the end of \#define preprocessor directives. Remove the semicolons from the definitions of LED_RED, LED_GREEN, and BUTTON. It doesn't appear to me that this is the cause of your problem, but it is a common mistake.

0 Archaeologist over 8 years ago in reply to George Mock

TI__Guru* 84285 points

Oop, yes, , the extra semicolon noted by Sasha is messing up the statement "if (P1IFG & BUTTON)" noted by George. Removing the semicolons should fix the problem.

Code Composer Studio™︎

Code Composer Studio forum

CCS/MSP-EXP430F5529LP: Error #18: expected a ")"