CC2652R7: ZStack bug leading to race condition on commissioning with no networks

Hello Kenny,

Thank you for your in-depth report of this issue.  Another E2E user has reported the same behavior alongside TI's own internal observations.  There is a 15.4-Stack low-level issue which is being further investigated, meanwhile you can:

• Use SimpleLink F2 SDK v7.41 which does not demonstrate the behavior
• Configure the Watchdog or a clock timeout to reset the device
• Try the workaround used by the relevant E2E post (unconfirmed by TI)

Regards,
Ryan

Hi Ryan,

Thanks for the quick replies.

Is there any issue with the queues not being cleared with that workaround?

We fixed it by putting a binary semaphore around the app send->wait for response, and clear app queue code sections like so, but if there are no consequences to removing it completely, then we'll just do that

///////////////////////////////////////////////////
///////////////////////////////////////////////////
// app_main.c
///////////////////////////////////////////////////
///////////////////////////////////////////////////

uint8_t app_task_id = 0xff;
...
void app_initialize()
{
...
    app_task_id = OsalPort_registerTask(Task_self(), h_app_loop_sem, &app_task_events);
...
}

///////////////////////////////////////////////////
///////////////////////////////////////////////////
// osal_task_clear_fix.h
///////////////////////////////////////////////////
///////////////////////////////////////////////////

#ifndef APPLICATION_OSAL_TASK_CLEAR_FIX_H_
#define APPLICATION_OSAL_TASK_CLEAR_FIX_H_

#ifdef __cplusplus
extern "C" {
#endif

#define TASK_CLEAR_FIX

#ifdef TASK_CLEAR_FIX

extern uint8_t app_task_id;

uint8_t OsalPort_getTaskId(void* taskHndl);

void osal_task_clear_fix_init();
void osal_task_clear_fix_pend();
void osal_task_clear_fix_post();

#endif // #ifdef TASK_CLEAR_FIX

#ifdef __cplusplus
}
#endif

#endif /* APPLICATION_OSAL_TASK_CLEAR_FIX_H_ */


///////////////////////////////////////////////////
///////////////////////////////////////////////////
// osal_task_clear_fix.c
///////////////////////////////////////////////////
///////////////////////////////////////////////////

#include "osal_task_clear_fix.h"
#include <ti/sysbios/knl/Semaphore.h>
#include <ti/sysbios/BIOS.h>

static Semaphore_Struct app_wait_for_rsp_sem;
static Semaphore_Handle h_app_wait_for_rsp_sem = NULL;

void osal_task_clear_fix_init()
{
    Semaphore_Params params;
    Semaphore_Params_init(&params);
    params.mode = ti_sysbios_knl_Semaphore_Mode_BINARY;
    Semaphore_construct(&app_wait_for_rsp_sem, 1, &params);
    h_app_wait_for_rsp_sem = Semaphore_handle(&app_wait_for_rsp_sem);
}


void osal_task_clear_fix_pend()
{
    if (h_app_wait_for_rsp_sem) {
        Semaphore_pend(h_app_wait_for_rsp_sem, BIOS_WAIT_FOREVER);
    }
}

void osal_task_clear_fix_post()
{
    if (h_app_wait_for_rsp_sem) {
        Semaphore_post(h_app_wait_for_rsp_sem);
    }
}
```

///////////////////////////////////////////////////
///////////////////////////////////////////////////
// [SDK FILE] osal_port.c
///////////////////////////////////////////////////
///////////////////////////////////////////////////

// ============================= EDIT BEGIN =============================
#include "osal_task_clear_fix.h"
// ============================= EDIT END =============================

void OsalPort_clearTaskQueues( void )
{
    uint8_t  i;
    uint8_t *pMsg;

    for(i = 0; i < taskCnt; i++)
    {
        // ============================= EDIT BEGIN =============================
#ifdef TASK_CLEAR_FIX
        // app_task_id is statically init to 0xff and
        // is set after the semaphore is initalized.
        if (i == app_task_id) {
            osal_task_clear_fix_pend();
        }
#endif
        // ============================= EDIT END =============================

      while((pMsg = OsalPort_msgReceive(i)) != NULL)
      {
          OsalPort_msgDeallocate(pMsg);
      }
      
      // ============================= EDIT BEGIN =============================
#ifdef TASK_CLEAR_FIX
      // app_task_id is statically init to 0xff and
      // is set after the semaphore is initalized.
      if (i == app_task_id) {
          osal_task_clear_fix_post();
      }
#endif
      // ============================= EDIT END =============================

    }
}



// ============================= EDIT BEGIN =============================
uint8_t OsalPort_getTaskId(void* taskHndl)
{
    for(uint8_t taskIdx = 0; taskIdx < taskCnt; taskIdx++)
    {
        if (taskTbl[taskIdx].taskHndl == taskHndl) {
            return taskIdx;
        }
    }
    return 0xff;
}
// ============================= EDIT END =============================


///////////////////////////////////////////////////
///////////////////////////////////////////////////
// [SDK FILE] zstackapi.c
///////////////////////////////////////////////////
///////////////////////////////////////////////////

// ============================= EDIT BEGIN =============================
#include "osal_task_clear_fix.h"
// ============================= EDIT END =============================
static zstack_ZStatusValues sendReqDefaultRsp(uint8_t appServiceTaskId,
                                              zstack_CmdIDs cmdID, void *pReq,
                                              int msgSize)
{
    zstack_ZStatusValues status = zstack_ZStatusValues_ZMemError;
    uint8_t msgStatus;

    //Make sure allocate space enought for the msg, even
    //if the message does not have payload
    if(msgSize < sizeof(zstackmsg_genericReq_t))
    {
      msgSize = sizeof(zstackmsg_genericReq_t);
    }

    zstackmsg_genericReq_t *pMsg =
        (zstackmsg_genericReq_t *)OsalPort_msgAllocate(msgSize);

    // Make sure the allocation was successful
    if(pMsg != NULL)
    {
        // Fill in the message header
        pMsg->hdr.event = cmdID;
        pMsg->hdr.status = 0;
        pMsg->hdr.srcServiceTask = appServiceTaskId;

        // Update the messges's request field
        pMsg->pReq = pReq;

        // ============================= EDIT BEGIN =============================
#ifdef TASK_CLEAR_FIX
        // Do any other tasks call this fn?
        bool is_app_task = OsalPort_getTaskId(Task_self()) == app_task_id;
        if (is_app_task) {
            osal_task_clear_fix_pend();
        }
#endif
        // ============================= EDIT END =============================

        // Send the message
        msgStatus = OsalPort_msgSend( stackServiceTaskId, (uint8_t*) pMsg );

        // Was the message sent successfully
        if(msgStatus == OsalPort_SUCCESS)
        {
            bool gotRsp = false;

            // Return status
            zstackmsg_genericReq_t *pCmdStatus = NULL;

            while(!gotRsp)
            {
                // Wait for the response message
                OsalPort_blockOnEvent(Task_self());

                pCmdStatus = (zstackmsg_genericReq_t*)OsalPort_msgFindDequeue(appServiceTaskId, pMsg->hdr.event);

                if(pCmdStatus)
                {
                  gotRsp = true;
                }
            }
            // ============================= EDIT BEGIN =============================
#ifdef TASK_CLEAR_FIX
            if (is_app_task) {
                osal_task_clear_fix_post();
            }
#endif
            // ============================= EDIT END =============================

             // setup return of
            status = (zstack_ZStatusValues)pCmdStatus->hdr.status;
        }

        // pCmdStatus is the same as pMsg
        OsalPort_msgDeallocate( (uint8_t*)pMsg);
    }

    // function status
    return(status);
}