CC2530: Z-Stack 3.0.1 - ZCL Read/Report

static ZStatus_t App_OnJoinNetworkRequests( void )
{
  ZStatus_t astatus = App_SendAnnounce(); // send report

  uint16 attrid[] = 
  {
    0x0008,
    0x0009,
    0x000a
  };
 

  zclReadCmd_t *readCmd = zcl_mem_alloc( sizeof ( zclReadCmd_t )  + sizeof( uint16 ) * 3 );
  if ( readCmd != NULL )
  {
    readCmd->numAttr = 3; // Atrribute ID

    for ( size_t i = 0; i < 3; i++ )
    {
      readCmd->attrID[i] = attrid[i];
    }
  }

  ZStatus_t status;
  status = zcl_SendRead( MYAPP_ENDPOINT, &IdentifyDstAddr, MY_CLUSTER_ID, readCmd,
                     ZCL_FRAME_CLIENT_SERVER_DIR, FALSE, 0); // have also used bdb_getZCLFrameCounter() for last argument. No difference


  zcl_mem_free(readCmd);
  
    return ( status );
}

IdentifyDstAddr.addrMode = (afAddrMode_t)Addr16Bit;
IdentifyDstAddr.endPoint = 0;
IdentifyDstAddr.addr.shortAddr = 0xFFFC;

I get 0x2 which is :

#define INVALIDPARAMETER          0x02

I stepped through and it fails here:

// Validate broadcasting
  if ( ( dstAddr->addrMode == afAddr16Bit     ) ||
       ( dstAddr->addrMode == afAddrBroadcast )    )
  {
    // Check for valid broadcast values
    if( ADDR_NOT_BCAST != NLME_IsAddressBroadcast( dstAddr->addr.shortAddr )  )
    {
      // Force mode to broadcast
      dstAddr->addrMode = afAddrBroadcast;
    }
    else
    {
      // Address is not a valid broadcast type
      if ( dstAddr->addrMode == afAddrBroadcast )
      {
        return afStatus_INVALID_PARAMETER;
      }
    }
  }

I think it fails here

Hi Ben Abs,

You also need to register you new endpoint. Take a look to afRegister() function, you will need to declare a endPointDesc_t structure for your new endpoint.

Regards,

I didn't declare a new endpoint for my app. only the destination endpoint has changed.
but regardless, the endpoint is already registered in the init function unless I'm misunderstanding you

I tested unicast to ZC which works now but I tried the same thing with sending a report using zcl_SendReportCmd() which doesn't work.
status returns ZSuccess.

I'm trying report to these 2 addresses 

DstAddr1.addrMode = (afAddrMode_t)Addr16Bit;
DstAddr1.endPoint = 0x5;
DstAddr1.addr.shortAddr = 0x0000;


DstAddr2.addrMode = (afAddrMode_t)AddrBroadcast;
DstAddr2.endPoint = 0x5;
DstAddr2.addr.shortAddr = 0xFFFC;

but the image is only for DstAddr1

It says the payload is fragmented but I never get payload 2/3 or 3/3

sending with broadcast returns 0x02 from here:

    if (len > afDataReqMTU( &mtu ) )
    {
      if (apsfSendFragmented)
      {
        stat = (*apsfSendFragmented)( &req );
      }
    }

EDIT: I have 15 attributes to report and I've just tested with 3 attributes and it works fine. testing with 7 attributes showed 1/2 payloads but never sent payload 2/2 so I think its the fragmentation

Hi Ben Abs,

Please share the function you are using and the buffer that you are trying to send.

Regards,

when the message is fragmented, the application doesn't send the second part of the message.
also two different attributes are getting reported as one as I stated above. this happens even if I only report one of those two attributes.
how long do I need to wait between calls to sendreportcmd?

I would suggest to have 100ms between ZCL send report.

Jose Maria Alvarez said:

Hi Ben Abs,

First of all I need to know which is the result that you want to get by sending this message so share an example of the string that you need to get as a result. The first problem with your function as YK says is that you cannot send messages with a for loop because if you send all the messages as fast as you can to the stack the network layer can be busy with other stuff and then trow away some of your messages. Other issue in your function is that you shouldn't use zcl_SendReportCmd() to send this messages because this function serializes the data internally for all the attributes in zclReportCmd_t.

I have been able to get the string sent properly with a fixed length. I wasn't including the length in the string which I assumed caused some problems. i.e. I was sending

uint8 App_ProductString[30] = { 'p','r','o','d','u','c','t','_','s','t','r','i','n','g','-','B','E','N'};    

instead of 

uint8 App_ProductString[30] = { '\x12','p','r','o','d','u','c','t','_','s','t','r','i','n','g','-','B','E','N'};    

also why is it an issue to have the data serialised ?

Jose Maria Alvarez said:

I don't get this part of your code but it looks like you are filling reportCmd->attrList[j] = attributes[i]. This ends with zcl_SendReportCmd() sending reportCmd variable NUM_ATTRIBUTES times with the complete list of attributes each time. I'm not sure if this is you want to get so please clarify.

My recommendation is to use zcl_SendCommand() to send the frames and send just one attribute at time specially if you are sending strings of unknown length to avoid the requirement of fragmentation.

the code is meant to send a report of NUM_MAX_IN_REPORT attributes NUM_ATTRIBUTES/NUM_MAX_IN_REPORT times.

it's not very good but it was what I needed to break the attribute reports up into smaller chunks for now.
I'm now trying to use a timer of 100ms to separate the calls to zcl_SendReportCmd() like YK suggested but I haven't been able to find a way yet.

sending all the attributes separately, wouldn't that clog the network up? 

a periodic event looks like it'd be good repeatedly sending the same attributes.

but I don't need to do that for now I was able to send all the mandatory attributes in one packet (it only used to fail because I wasn't formatting my messages properly)

Thanks for all your help.