AM335x watchdog

Wim De Witte

Intellectual 300 points

using watchdog 5.12; and latest official kernel 3.2.0-psp04.06.00.07

Everytime the counter is loaded via the ioctl; following kernel warning appears:

"omap_hwmod: wd_timer2: _wait_target_disable failed"

It seems harmless, because the watchdog is working.

Question is why the function _omap4_disable_module is called every time the watchdog is updated?

Best regards,

Wim

over 13 years ago

0 Afzal MOHAMMED over 13 years ago

TI__Prodigy 635 points

Hi Wim,

This is a known issue, with no effect on watchdog functionality.

Due to higher priority commitments, this issue could not yet be looked into, we will look into the issue at the earliest.

Regards

Afzal

0 Wim De Witte over 13 years ago in reply to Afzal MOHAMMED

Intellectual 300 points

thanks, I made a small, ugly, patch to work around this annoying warning:

thanks,

Wim

--- linux/arch/arm/mach-omap2/omap_hwmod.c.orig   2012-06-12 16:13:11.166367276 +0200
+++ linux/arch/arm/mach-omap2/omap_hwmod.c   2012-06-12 16:15:56.319482962 +0200
@@ -781,6 +781,8 @@
                          oh->prcm.omap4.clkctrl_offs);
}

+#define WD_FILTER   "wd_timer2"
+
/**
* _omap4_disable_module - enable CLKCTRL modulemode on OMAP4
* @oh: struct omap_hwmod *
@@ -807,10 +809,10 @@
            oh->prcm.omap4.clkctrl_offs);

    v = _omap4_wait_target_disable(oh);
-   if (v)
-       pr_warn("omap_hwmod: %s: _wait_target_disable failed\n",
-               oh->name);
-
+   if (v) {
+       if (!strcmp(oh->name, WD_FILTER))
+           pr_warn("omap_hwmod: %s: _wait_target_disable failed\n", oh->name);
+   }
    return 0;
}

0 Afzal MOHAMMED over 13 years ago in reply to Wim De Witte

TI__Prodigy 635 points

Hi Wim,

Attached patch should fix the issue without hacks.

Regards

Afzal

0 Afzal MOHAMMED over 13 years ago in reply to Afzal MOHAMMED

TI__Prodigy 635 points

Hi Wim,

Seems attachment didn't get attached, attaching again

Regards

Afzal

Processors

Processors forum

AM335x watchdog