DP83TC813S-Q1: ethernet phy DP83TC813SRHFRQ1 support in kernel 6.6.40

rohit kumar

Part Number: DP83TC813S-Q1

Tool/software:

Hello,
I am uising the DP83TC813SRHFRQ1 in out design and we found the linux driver at

https://github.com/TexasInstruments/ti-ethernet-software/blob/v2024.04/linux_drivers/dp83tc812.c

but while compiling it for kernel 6.6.40 (xilinx kernel) i am getting following error:

| CC [M] /work/dp83tc813/1.0/dp83tc812.o
| /work/dp83tc813/1.0/dp83tc812.c:709:18: error: 'struct phy_driver' has no member named 'ack_interrupt'; did you mean 'handle_interrupt'?
| 709 | .ack_interrupt = DP83TC812_ack_interrupt, \
| | ^~~~~~~~~~~~~
| /work/dp83tc813/1.0/dp83tc812.c:724:9: note: in expansion of macro 'DP83TC812_PHY_DRIVER'
| 724 | DP83TC812_PHY_DRIVER(DP83TC812_CS2_0_PHY_ID, "TI DP83TC812CS2.0"),
| | ^~~~~~~~~~~~~~~~~~~~
| /work/dp83tc813/1.0/dp83tc812.c:709:18: error: 'struct phy_driver' has no member named 'ack_interrupt'; did you mean 'handle_interrupt'?
| 709 | .ack_interrupt = DP83TC812_ack_interrupt, \
| | ^~~~~~~~~~~~~
| /work/dp83tc813/1.0/dp83tc812.c:725:9: note: in expansion of macro 'DP83TC812_PHY_DRIVER'
| 725 | DP83TC812_PHY_DRIVER(DP83TC813_CS2_0_PHY_ID, "TI DP83TC813CS2.0"),
| | ^~~~~~~~~~~~~~~~~~~~
| /work/dp83tc813/1.0/dp83tc812.c:709:18: error: 'struct phy_driver' has no member named 'ack_interrupt'; did you mean 'handle_interrupt'?
| 709 | .ack_interrupt = DP83TC812_ack_interrupt, \
| | ^~~~~~~~~~~~~
/work/dp83tc813/1.0/dp83tc812.c:726:9: note: in expansion of macro 'DP83TC812_PHY_DRIVER'
| 726 | DP83TC812_PHY_DRIVER(DP83TC814_CS2_0_PHY_ID, "TI DP83TC814CS2.0"),
| | ^~~~~~~~~~~~~~~~~~~~

can you help me here.

1 month ago

0 Evan Mayhew 1 month ago

TI__Mastermind 24988 points

Hi Rohit,

This error is due to mismatch in Linux versions. Referring to phy.h in v6.6.40, there is another handle name used for interrupts:
https://elixir.bootlin.com/linux/v6.6.40/source/include/linux/phy.h (line 964)

Please also see a similar issue and resolution here:
https://e2e.ti.com/support/interface-group/interface/f/interface-forum/1311159/dp83tc812s-q1-dp83tc812s-drivers

I recommend following a similar approach to interrupt definition as DP83TC720 driver found here, removing all instances of ack_interrupt:
https://github.com/TexasInstruments/ti-ethernet-software/blob/main/linux_drivers/dp83tg720.c

Thank you,
Evan

0 rohit kumar 1 month ago in reply to Evan Mayhew

Prodigy 10 points

Hello Evan,

can you also help me / guide me to corresponding device tree entry for the same?

0 Evan Mayhew 1 month ago in reply to rohit kumar

TI__Mastermind 24988 points

Hi Rohit,

There is no device tree change required here, please use same entry.

Thank you,
Evan

0 rohit kumar 1 month ago in reply to Evan Mayhew

Prodigy 10 points

Hello Evan,
can you point me to a sample device tree?

0 Evan Mayhew 1 month ago in reply to rohit kumar

TI__Mastermind 24988 points

Please allow me 1-2 days to confirm correct device tree entry for 813 on v6.6.

Thank you,
Evan

0 Evan Mayhew 1 month ago in reply to Evan Mayhew

TI__Mastermind 24988 points

Hi Rohit,

This driver does not have any feature-specific device tree bindings - please reference basic entry with reg <x> for PHY address:

  
    mdio0 {
      #address-cells = <1>;
      #size-cells = <0>;
      ethphy0: ethernet-phy@0 {
        reg = <0>;
      };
    };

(example to detect PHY at address 0)

Thank you,
Evan

Interface

Interface forum

DP83TC813S-Q1: ethernet phy DP83TC813SRHFRQ1 support in kernel 6.6.40