This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

TM4C1294NCPDT: ul not always means: unsigned long 32 bit

Part Number: TM4C1294NCPDT

Good Evening!

I think that not all "ul" mean "unsigned int 32-bit" in file "TivaWare_C_Series-2.2.0.295/third_party/lwip-1.4.1/ports/tiva-tm4c129/netif/tiva-tm4c129.c". I propose to reverse changes according to patch:

------------------------------------------------------------------------------

--- orig/tiva-tm4c129.c    2022-07-04 13:39:26.977320128 +0200
+++ fixed/tiva-tm4c129.c    2022-07-05 01:12:08.842076073 +0200
@@ -21,7 +21,7 @@
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS FOR A PARTICui32AR PURPOSE ARE DISCLAIMED. IN NO EVENT
+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT
  * SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
  * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
@@ -87,7 +87,7 @@
 #endif
 
 /**
- * If necessary, set the defaui32t number of transmit and receive DMA descriptors
+ * If necessary, set the default number of transmit and receive DMA descriptors
  * used by the Ethernet MAC.
  *
  */
@@ -328,7 +328,7 @@
   ui16Val = EMACPHYRead(EMAC0_BASE, PHY_PHYS_ADDR, EPHY_MISR1);
 
   /**
-   * Set MAC filtering options.  We receive all broadcast and mui32ticast
+   * Set MAC filtering options.  We receive all broadcast and multicast
    * packets along with those addressed specifically for us.
    */
   EMACFrameFilterSet(EMAC0_BASE, (EMAC_FRMFILTER_HASH_AND_PERFECT |
@@ -473,8 +473,8 @@
  *
  * @param psNetif the lwip network interface structure for this ethernetif
  * @param p the MAC packet to send (e.g. IP packet including MAC addresses and type)
- * @return ERR_OK if the packet coui32d be sent
- *         an err_t value if the packet coui32dn't be sent
+ * @return ERR_OK if the packet could be sent
+ *         an err_t value if the packet couldn't be sent
  */
 static err_t
 tivaif_transmit(struct netif *psNetif, struct pbuf *p)
@@ -846,7 +846,7 @@
 
           pDescList->pDescriptors[pDescList->ui32Read].Desc.pvBuffer1 = 0;
 
-          /* Update the stats to show we coui32dn't allocate a pbuf. */
+          /* Update the stats to show we couldn't allocate a pbuf. */
           DRIVER_STATS_INC(RXNoBufCount);
           LINK_STATS_INC(link.memerr);
 
@@ -874,7 +874,7 @@
  *
  * @param psNetif the lwip network interface structure for this ethernetif
  * @return ERR_OK if the loopif is initialized
- *         ERR_MEM if private data coui32dn't be allocated
+ *         ERR_MEM if private data couldn't be allocated
  *         any other err_t on error
  */
 err_t
@@ -952,7 +952,7 @@
 #endif
 
             /* In this case we drop through since we may need to reconfigure
-             * the MAC depending upon the speed and half/fui32l-duplex settings.
+             * the MAC depending upon the speed and half/full-duplex settings.
              */
         }
         else
@@ -986,10 +986,10 @@
             ui32Config |= EMAC_CONFIG_100MBPS;
         }
 
-        /* Are we in fui32l- or half-duplex mode? */
+        /* Are we in full- or half-duplex mode? */
         if(ui16Status & EPHY_STS_DUPLEX)
         {
-            /* Fui32l duplex. */
+            /* Full duplex. */
             ui32Config |= EMAC_CONFIG_FULL_DUPLEX;
         }
         else

------------------------------------------------------------------------------

  • Hi,

      Again, thanks for your findings. This file was created a long time ago. I guess the mistakes were introduced during the search and replace process. Although no current plan to release another TivaWare version in the near term. However, I will create an internal ticket to track this so it will be addressed if we do release another version.