TMS570LC4357: Question about HL_errata_SSWF021_45.C

Hi Mark,

In _errata_SSWF021_45_both_plls() function, both PLL1 and PLL2 are disabled by calling disable_plls(SYS_CLKSRC_PLL1 | SYS_CLKSRC_PLL2).

In _errata_SSWF021_45_pll1(uint32 count) function, only PLL1 is disabled by calling  disable_plls(SYS_CLKSRC_PLL1).

In _errata_SSWF021_45_pll2(uint32 count) function, only PLL1 is disabled by calling  disable_plls(SYS_CLKSRC_PLL2).

Additionally:  The bit descriptions in Table 2-33 in SPUN563A (TMS570LC43x TRM) look incorrect.   These bits should disable the clock sources NOT ENABLE them, correct?

Correct I copied the wrong second instruction.   But this does not answer my question.   I am questioning the error code.  It is destroyed by the call to disable_plls.  Please look at that part of the question.

The question should be restated as:

regarding line 123 (and similarly lines 194 & 264):     failCode = disable_plls(SYS_CLKSRC_PLL1 | SYS_CLKSRC_PLL2);

Doesn't this throw away errors in the slip-detect loop directly above it?

Shouldn't it instead be:    failCode |= disable_plls(SYS_CLKSRC_PLL1  | SYS_CLKSRC_PLL2);    ?

Question not answered - Pls see additional responses

Hi Mark,

You are correct. 

failCode |= disable_plls(SYS_CLKSRC_PLL1  | SYS_CLKSRC_PLL2); should be used in the workaround.