Tool/software:
Hi,
The issue is with the example ospi_flash_io.c .
In this example, we are testing the read write two times. if I try to use memcpy for reading from flash both the time, the code goes into abort handler.
Code works fine if I enable DAC mode everytime I use memcpy.
Note : application uses memcpy at higher layers so I need the support for memcpy.
Observations
I have to call OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]) every time I use memcpy if there is Flash_write() api used in the middle.
Code which works
/*
* Copyright (C) 2021-24 Texas Instruments Incorporated
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the
* distribution.
*
* Neither the name of Texas Instruments Incorporated nor the names of
* its contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <kernel/dpl/DebugP.h>
#include "ti_drivers_open_close.h"
#include "ti_board_open_close.h"
#include "string.h"
#define APP_OSPI_FLASH_OFFSET_BASE (0x200000U)
#define APP_OSPI_DATA_SIZE (2048)
uint8_t gOspiTxBuf[APP_OSPI_DATA_SIZE];
/* read buffer MUST be cache line aligned when using DMA, we aligned to 128B though 32B is enough */
uint8_t gOspiRxBuf[APP_OSPI_DATA_SIZE] __attribute__((aligned(128U)));
void ospi_flash_io_fill_buffers(void);
int32_t ospi_flash_io_compare_buffers(void);
void ospi_flash_io_main(void *args)
{
int32_t status = SystemP_SUCCESS;
uint32_t offset;
uint32_t blk, page;
Flash_Attrs *flashAttrs;
/* Open OSPI Driver, among others */
Drivers_open();
// gFlashConfig[CONFIG_FLASH0].skipHwInit = TRUE;
/* Open Flash drivers with OSPI instance as input */
status = Board_driversOpen();
DebugP_assert(status==SystemP_SUCCESS);
flashAttrs = Flash_getAttrs(CONFIG_FLASH0);
//OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
/* Fill buffers with known data,
* find block number from offset,
* erase block, write the data, read back from a specific offset
* and finally compare the results.
*/
offset = APP_OSPI_FLASH_OFFSET_BASE;
ospi_flash_io_fill_buffers();
Flash_offsetToBlkPage(gFlashHandle[CONFIG_FLASH0], offset, &blk, &page);
status = Flash_eraseBlk(gFlashHandle[CONFIG_FLASH0], blk);
if(status != SystemP_SUCCESS)
{
DebugP_log("Block Erase Failed at 0x%X offset !!!", offset);
}
if(SystemP_SUCCESS == status)
{
status = Flash_write(gFlashHandle[CONFIG_FLASH0], offset, gOspiTxBuf, APP_OSPI_DATA_SIZE);
}
else
{
DebugP_log("Flash Write of %d bytes failed at 0x%X offset !!!", APP_OSPI_DATA_SIZE, offset);
}
if(SystemP_SUCCESS == status)
{
//status = Flash_read(gFlashHandle[CONFIG_FLASH0], offset, gOspiRxBuf, APP_OSPI_DATA_SIZE);
OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
memcpy(&gOspiRxBuf[0],(unsigned char *)(offset + 0x60000000),APP_OSPI_DATA_SIZE);
status = SystemP_SUCCESS;
}
if(SystemP_SUCCESS == status)
{
status |= ospi_flash_io_compare_buffers();
}
offset = APP_OSPI_FLASH_OFFSET_BASE + (flashAttrs->blockSize*2);
ospi_flash_io_fill_buffers();
Flash_offsetToBlkPage(gFlashHandle[CONFIG_FLASH0], offset, &blk, &page);
status = Flash_eraseBlk(gFlashHandle[CONFIG_FLASH0], blk);
if(status != SystemP_SUCCESS)
{
DebugP_log("Block Erase Failed at 0x%X offset !!!", offset);
}
if(SystemP_SUCCESS == status)
{
status = Flash_write(gFlashHandle[CONFIG_FLASH0], offset, gOspiTxBuf, APP_OSPI_DATA_SIZE);
}
else
{
DebugP_log("Flash Write of %d bytes failed at 0x%X offset !!!", APP_OSPI_DATA_SIZE, offset);
}
if(SystemP_SUCCESS == status)
{
// status = Flash_read(gFlashHandle[CONFIG_FLASH0], offset, gOspiRxBuf, APP_OSPI_DATA_SIZE);
OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
memcpy(&gOspiRxBuf[0],(unsigned char *)(offset + 0x60000000),APP_OSPI_DATA_SIZE);
status = SystemP_SUCCESS;
}
if(SystemP_SUCCESS == status)
{
status |= ospi_flash_io_compare_buffers();
}
if(SystemP_SUCCESS == status)
{
DebugP_log("All tests have passed!!\r\n");
}
else
{
DebugP_log("Some tests have failed!!\r\n");
}
Board_driversClose();
Drivers_close();
}
void ospi_flash_io_fill_buffers(void)
{
uint32_t i;
for(i = 0U; i < APP_OSPI_DATA_SIZE; i++)
{
gOspiTxBuf[i] = i % 256;
gOspiRxBuf[i] = 0U;
}
}
int32_t ospi_flash_io_compare_buffers(void)
{
int32_t status = SystemP_SUCCESS;
uint32_t i;
for(i = 0U; i < APP_OSPI_DATA_SIZE; i++)
{
if(gOspiTxBuf[i] != gOspiRxBuf[i])
{
status = SystemP_FAILURE;
DebugP_logError("OSPI read data mismatch !!!\r\n");
break;
}
}
return status;
}
Code which doesn't work
/*
* Copyright (C) 2021-24 Texas Instruments Incorporated
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the
* distribution.
*
* Neither the name of Texas Instruments Incorporated nor the names of
* its contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <kernel/dpl/DebugP.h>
#include "ti_drivers_open_close.h"
#include "ti_board_open_close.h"
#include "string.h"
#define APP_OSPI_FLASH_OFFSET_BASE (0x200000U)
#define APP_OSPI_DATA_SIZE (2048)
uint8_t gOspiTxBuf[APP_OSPI_DATA_SIZE];
/* read buffer MUST be cache line aligned when using DMA, we aligned to 128B though 32B is enough */
uint8_t gOspiRxBuf[APP_OSPI_DATA_SIZE] __attribute__((aligned(128U)));
void ospi_flash_io_fill_buffers(void);
int32_t ospi_flash_io_compare_buffers(void);
void ospi_flash_io_main(void *args)
{
int32_t status = SystemP_SUCCESS;
uint32_t offset;
uint32_t blk, page;
Flash_Attrs *flashAttrs;
/* Open OSPI Driver, among others */
Drivers_open();
// gFlashConfig[CONFIG_FLASH0].skipHwInit = TRUE;
/* Open Flash drivers with OSPI instance as input */
status = Board_driversOpen();
DebugP_assert(status==SystemP_SUCCESS);
flashAttrs = Flash_getAttrs(CONFIG_FLASH0);
OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
/* Fill buffers with known data,
* find block number from offset,
* erase block, write the data, read back from a specific offset
* and finally compare the results.
*/
offset = APP_OSPI_FLASH_OFFSET_BASE;
ospi_flash_io_fill_buffers();
Flash_offsetToBlkPage(gFlashHandle[CONFIG_FLASH0], offset, &blk, &page);
status = Flash_eraseBlk(gFlashHandle[CONFIG_FLASH0], blk);
if(status != SystemP_SUCCESS)
{
DebugP_log("Block Erase Failed at 0x%X offset !!!", offset);
}
if(SystemP_SUCCESS == status)
{
status = Flash_write(gFlashHandle[CONFIG_FLASH0], offset, gOspiTxBuf, APP_OSPI_DATA_SIZE);
}
else
{
DebugP_log("Flash Write of %d bytes failed at 0x%X offset !!!", APP_OSPI_DATA_SIZE, offset);
}
if(SystemP_SUCCESS == status)
{
//status = Flash_read(gFlashHandle[CONFIG_FLASH0], offset, gOspiRxBuf, APP_OSPI_DATA_SIZE);
//OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
memcpy(&gOspiRxBuf[0],(unsigned char *)(offset + 0x60000000),APP_OSPI_DATA_SIZE);
status = SystemP_SUCCESS;
}
if(SystemP_SUCCESS == status)
{
status |= ospi_flash_io_compare_buffers();
}
offset = APP_OSPI_FLASH_OFFSET_BASE + (flashAttrs->blockSize*2);
ospi_flash_io_fill_buffers();
Flash_offsetToBlkPage(gFlashHandle[CONFIG_FLASH0], offset, &blk, &page);
status = Flash_eraseBlk(gFlashHandle[CONFIG_FLASH0], blk);
if(status != SystemP_SUCCESS)
{
DebugP_log("Block Erase Failed at 0x%X offset !!!", offset);
}
if(SystemP_SUCCESS == status)
{
status = Flash_write(gFlashHandle[CONFIG_FLASH0], offset, gOspiTxBuf, APP_OSPI_DATA_SIZE);
}
else
{
DebugP_log("Flash Write of %d bytes failed at 0x%X offset !!!", APP_OSPI_DATA_SIZE, offset);
}
if(SystemP_SUCCESS == status)
{
// status = Flash_read(gFlashHandle[CONFIG_FLASH0], offset, gOspiRxBuf, APP_OSPI_DATA_SIZE);
//OSPI_enableDacMode(gOspiHandle[CONFIG_FLASH0]);
memcpy(&gOspiRxBuf[0],(unsigned char *)(offset + 0x60000000),APP_OSPI_DATA_SIZE);
status = SystemP_SUCCESS;
}
if(SystemP_SUCCESS == status)
{
status |= ospi_flash_io_compare_buffers();
}
if(SystemP_SUCCESS == status)
{
DebugP_log("All tests have passed!!\r\n");
}
else
{
DebugP_log("Some tests have failed!!\r\n");
}
Board_driversClose();
Drivers_close();
}
void ospi_flash_io_fill_buffers(void)
{
uint32_t i;
for(i = 0U; i < APP_OSPI_DATA_SIZE; i++)
{
gOspiTxBuf[i] = i % 256;
gOspiRxBuf[i] = 0U;
}
}
int32_t ospi_flash_io_compare_buffers(void)
{
int32_t status = SystemP_SUCCESS;
uint32_t i;
for(i = 0U; i < APP_OSPI_DATA_SIZE; i++)
{
if(gOspiTxBuf[i] != gOspiRxBuf[i])
{
status = SystemP_FAILURE;
DebugP_logError("OSPI read data mismatch !!!\r\n");
break;
}
}
return status;
}
