AM2434: EtherNet/IP assembly Set CB not called during Idle state

Hi Jan,

The initialization function "createAsmOutput" appears to be implemented correctly. Your set callback implementation is also mostly correct, though there is one minor issue: you should read the data length from "pConsumeBuffer->u16uActData" member rather than "pConsumeBuffer->u16uMaxData", which only indicates the maximum available size in the pConsumeBuffer->p8uDataBuf.

Hello Pourya,

Run mode is recieved without issue. For idle, my observations are that callback is only called when I switch from recaverable fault to connection established while PLC is in idle state. 

For my state machine I only have simple output swiching. Is there any function I should call for API to know current state? 

Here is state machine I have implemented:

static IMI_DEVICE_SmStates_t processState(IMI_DEVICE_SmStates_t state, IMI_DEVICE_ConnectionEvent_t event) {
	if (event == IMI_DEVICE_CONNECTION_ESTABLISHED_IO) {
		return IMI_DEVICE_SM_RUN_IO;
	}

	if (event == IMI_DEVICE_CONNECTION_ESTABLISHED_EXP) {
		if (state == IMI_DEVICE_SM_RUN_IO) {
			return IMI_DEVICE_SM_IDLE;
		}
		return IMI_DEVICE_SM_RUN_EXP;
	}

	if (event == IMI_DEVICE_CONNECTION_DELETED) {
		return IMI_DEVICE_SM_IDLE;
	}

	if (event == IMI_DEVICE_CONNECTION_TIMEDOUT) {
		return IMI_DEVICE_SM_RECOVERABLEFAULT;
	}

	return IMI_DEVICE_SM_UNRECOVERABLEFAULT;
}

DEVICE_SmStates_t IMI_DEVICE_getDeviceState(void) {
	return connPathIDstate[0];
}

void DEVICE_receiveConnectionEvent(uint16_t connPathID, IMI_DEVICE_ConnectionEvent_t connectionEvent) {
	switch (connPathID) {
		case 1:
			connPathIDstate[0] = processState(connPathIDstate[0], connectionEvent);
			break;
		case 2:
			connPathIDstate[1] = processState(connPathIDstate[1], connectionEvent);
			break;
		case 3:
			connPathIDstate[2] = processState(connPathIDstate[2], connectionEvent);
			break;
		case 4:
			connPathIDstate[3] = processState(connPathIDstate[3], connectionEvent);
			break;
		default:
			break;
	}
}

void DEVICE_taskRun(EI_API_CIP_NODE_T* pCipNode) {
	stateNow = IMI_DEVICE_getDeviceState();
	switch (stateNow) {
		case DEVICE_SM_RECOVERABLEFAULT:
			for (i = 0; i < MAX_SOLENOID_BYTES * 8; i++) {
				DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapFaultAction);
				if (val) {
					DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapFaultValue);
					DEVICE_setABBitMapBit(i, val, ab_BitMapSolenoidValue);
				}
			}
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
		case DEVICE_SM_IDLE:
			for (i = 0; i < MAX_SOLENOID_BYTES * 8; i++) {
				DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapIdleAction);
				if (val) {
					DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapIdleValue);
					DEVICE_setABBitMapBit(i, val, ab_BitMapSolenoidValue);
				}
			}
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
		case DEVICE_SM_READY:
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
		case DEVICE_SM_RUN_IO:
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
		case DEVICE_SM_RUN_EXP:
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
		default:
			for (i = 0; i < MAX_SOLENOID_BYTES * 8; i++) {
				DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapFaultAction);
				if (val) {
					DEVICE_getABBitMapBit(i, (bool*)&val, ab_BitMapFaultValue);
					DEVICE_setABBitMapBit(i, val, ab_BitMapSolenoidValue);
				}
			}
			WriteDataToValves(ab_BitMapSolenoidValue, MAX_SOLENOID_BYTES);
			break;
	}
}

Thank you for help.

Best regards, 

Jan

Hi Jan,

Let's first focus on the callback functionality before examining the state machine.

Hello Pourya,

My prinf shows that Idle state is not received in callback (it never enters callback according to printf before any conditions are checked) 

Run state is recieved and I can read sucessfuly read data send by PLC.

Thank you for help.

Best regards, 

Jan

Hi Jan,

In this case, I need additional information to properly diagnose the issue. Please provide:

1. A Wireshark log capturing the communication between the PLC and your device (use a network TAP to capture the packets being exchanged)

2. The Assembly Instance IDs for both the O→T and T→O connections

3. If available, the EDS file for your device

Hello Pourya,

Here are screenshots with wireshark logs

Run mode: 

Idle mode:

My new printf are independent of state: 

static EI_API_CIP_EAssemb_Return_Code_t cbSetCustomMapAsmOut(EI_API_CIP_SAssemMapData_t* pAttrMapData, const EI_API_CIP_STransferBuffer_t* pConsumeBuffer) {
	EI_API_CIP_EAssemb_Return_Code_t retValue = ASSEMB_SERVICE_NO_RESPONSE;
	uint16_t dataLen;

	OSAL_printf("ASM data set\r\n");
	
	if (DEVICE_PROFILE_CIP_CLASS_ID_SOLENOID != pAttrMapData->classId) {
		return retValue;
	}

	if (pAttrMapData->instanceId > 0) {
		if (k_INST_ATTR_ID_SOLENOID_VALUE == pAttrMapData->attributeId)
		{
			OSAL_printf("ASM data set ID = 0x%X, Idle data 0x%X\r\n", pAttrMapData->instanceId, pConsumeBuffer->p8uDataBuf[0]);
			if(pConsumeBuffer->p8uDataBuf[0] == 0) //Idle state
			{
				OSAL_printf("Idle Detected\r\n");
				if(ConnectionIdle == false)
				{
					// change state from run to idle
					IMI_DEVICE_receiveConnectionEvent(pAttrMapData->attributeId, IMI_DEVICE_CONNECTION_DELETED);
				}
				ConnectionIdle = true;
				retValue = ASSEMB_SERVICE_RESPONSE_OK;
			}
			else
			{
				if(ConnectionIdle == true)
				{
					// change state from idle to run
					IMI_DEVICE_receiveConnectionEvent(pAttrMapData->attributeId, IMI_DEVICE_CONNECTION_ESTABLISHED_IO);
				}
				ConnectionIdle = false;

				dataLen = pConsumeBuffer->u16uActData;
				if (dataLen > MAX_SOLENOID_BYTES) {
					dataLen = MAX_SOLENOID_BYTES;
				}
				OSAL_MEMORY_memcpy(ab_BitMapSolenoidValue, pConsumeBuffer->p8uDataBuf + 4, dataLen); // +4 for header
				retValue = ASSEMB_SERVICE_RESPONSE_OK;
			}
		}
	}
	return retValue;
}

Thank you for help.

Best regards, 

Jan

Hello Pourya,

Here are screenshots with wireshark logs

Run mode: 

Idle mode:

My new printf are independent of state: 

static EI_API_CIP_EAssemb_Return_Code_t cbSetCustomMapAsmOut(EI_API_CIP_SAssemMapData_t* pAttrMapData, const EI_API_CIP_STransferBuffer_t* pConsumeBuffer) {
	EI_API_CIP_EAssemb_Return_Code_t retValue = ASSEMB_SERVICE_NO_RESPONSE;
	uint16_t dataLen;

	OSAL_printf("ASM data set\r\n");
	
	if (DEVICE_PROFILE_CIP_CLASS_ID_SOLENOID != pAttrMapData->classId) {
		return retValue;
	}

	if (pAttrMapData->instanceId > 0) {
		if (k_INST_ATTR_ID_SOLENOID_VALUE == pAttrMapData->attributeId)
		{
			OSAL_printf("ASM data set ID = 0x%X, Idle data 0x%X\r\n", pAttrMapData->instanceId, pConsumeBuffer->p8uDataBuf[0]);
			if(pConsumeBuffer->p8uDataBuf[0] == 0) //Idle state
			{
				OSAL_printf("Idle Detected\r\n");
				if(ConnectionIdle == false)
				{
					// change state from run to idle
					IMI_DEVICE_receiveConnectionEvent(pAttrMapData->attributeId, IMI_DEVICE_CONNECTION_DELETED);
				}
				ConnectionIdle = true;
				retValue = ASSEMB_SERVICE_RESPONSE_OK;
			}
			else
			{
				if(ConnectionIdle == true)
				{
					// change state from idle to run
					IMI_DEVICE_receiveConnectionEvent(pAttrMapData->attributeId, IMI_DEVICE_CONNECTION_ESTABLISHED_IO);
				}
				ConnectionIdle = false;

				dataLen = pConsumeBuffer->u16uActData;
				if (dataLen > MAX_SOLENOID_BYTES) {
					dataLen = MAX_SOLENOID_BYTES;
				}
				OSAL_MEMORY_memcpy(ab_BitMapSolenoidValue, pConsumeBuffer->p8uDataBuf + 4, dataLen); // +4 for header
				retValue = ASSEMB_SERVICE_RESPONSE_OK;
			}
		}
	}
	return retValue;
}

edit: added eds file

Thank you for help.

Best regards, 

Jan

Hi Jan,

Please ensure that the ForwardOpen request for the connection is captured in Wireshark (maybe start the Wireshark capture first then reset the device to make sure everything is captured), as this contains crucial information I need to diagnose the issue.

Could you please re-upload the Wireshark logs?

Best regards,
Pourya

Hello Pourya,

sorry for incomplete data, here are new logs.

 RunMode.zip 

Thank you for help.

Best regards, 

Jan

Hello Pourya,

you are right, after I used Hilsher tool, I managed to test it correctly. But is there any way to get information about dropped packets from stack to detect this state from PLC?

Thank you for help.

Best regards, 

Jan