Some compiler errors while working with thw Watt-Hour Meter Using the MSP430F47197

That solved my problems. 

Thanks. 

Edgar Camacho said:

That solved my problems. 

I think you mean, "that silenced the errors" ?

The reason those checks are there is because the code has been specifically verified to work with those particular compiler versions; or, conversely, it has not  been verified to work with any other compiler versions.

Simply suppressing the warning does not mean that everything will "just work" and be OK - you should check carefully that any changes is your compiler version don't break anything which the code relies upon...

Andy Neil said:

I think you mean, "that silenced the errors" ?

Chester Gillon said:

The section of code in isr_compat.h which reported "#error Compiler not recognised." with IAR 5.50 was conditional compilation to define an ISR macro in a way which allowed the rest of the code to be same for multiple compilers (MSPGCC, Quadravox, IAR, Rowley Crossworks, Code Composer Essentials). IAR 5 defines an interrupt service function with the same syntax as IAR 4.

Sometimes the difference is not what you do but why you do it. One can do the right thing for the wrong reason. So without knowing the reason, even the apparently right solution will leave a stale taste and the feeling of possible danger. :)

Jens-Michael Gross said:

this analysis of the reason and influence of this compiler check was missing from the fix. Without it, the proposed fix was indeed only "silencing the error". With it, it is an extension of the original code.

Indeed.

Unfortunately, the analysis was given only after the OP had applied the change - so, if  the OP doesn't bother to check back to this thread, he may just have made the change without understanding the justification behind it...

Andy Neil said:

Unfortunately, the analysis was given only after the OP had applied the change

Chester Gillon said:

Based upon the isr_compat.h source file in which the error occurs, the example code in slaa409a was written to support either V1.xx, V2.xx, V3.xx, or V4.xx of the IAR compiler. Hence, the V5.50 IAR compiler is reported as not recognised.

What happens if you change the following in C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h from:

#elif defined(__IAR_SYSTEMS_ICC__) && (((__TID__ >> 8) & 0x7f) == 43) && (__VER__ < 500)
 /* This is V2.xx, V3.xx, or V4.xx of the IAR compiler. */

 To:

#elif defined(__IAR_SYSTEMS_ICC__) && (((__TID__ >> 8) & 0x7f) == 43) && (__VER__ < 600)
 /* This is V2.xx, V3.xx, V4.xx or V5.xx of the IAR compiler. */

(I haven't got IAR at the moment to try this) 

[/quote]

Cool! But get another error as follows!

identifier XCAP18PF is undefined!

And I changed it to  XCAP11PF according to the following thread.

http://e2e.ti.com/support/microcontrollers/msp430/f/166/t/199111.aspx

Edgar Camacho said:

Hi,

I want to implement a Three-Phase Electronic Watt-Hour Meter Using the MSP430F47197.

The IAR Embedded Workbench for MSP430, v. 5.50, Evaluation version was downloaded and  I wanted to load the project “emeter-toolkit-47197.ewp” and then do a "rebuild all" as specified in the datasheet of the MSP430F47197.

I got the following errors. 

Building configuration: emeter-toolkit-47197 - Debug
Updating build tree...

47 file(s) deleted.
Updating build tree...
LCD-internal.c

Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCD-module.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCD-sim.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCDdec16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCDdec32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCDdecu16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

LCDdecu32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

accum48.s43
bin2bcd16.s43
bin2bcd32.s43
dc_filter.s43
dds.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

debounce.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

div48.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

div_sh48.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_clr.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_memcpy.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_replace16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_replace32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_secure.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_write_int16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_write_int32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

flash_write_int8.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

hex2ASCII.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_char.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_dec16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_dec32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_decu16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_decu32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_hex16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_hex32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

host_str.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

iiceeprom.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

imul16.s43
isqrt32.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

isqrt32i.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

isqrt64.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

mul48.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

q1_15_mul.s43
q1_15_mulq.s43
q1_15_mulr.s43
rand16.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

rtc.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

rtc_data.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82
Error while running C/C++ compiler

setdco.c
Fatal Error[Pe035]: #error directive: Compiler not recognised.
C:\Documents and Settings\Edgar\Mis documentos\Texas\slaa409\Source\emeter-toolkit\isr_compat.h 82

Error while running C/C++ compiler
shift48.s43

Total number of errors: 37
Total number of warnings: 0

How can I fix this?

Irrespective of what you explained about the errors, does this code accumulate the KwH?! even though I have a consumer of energy but this code does not accumulate the kwh. (I mean Slaa409)

Please disregard my previous post! It works fine! :)