else if statement is not evaluated even if the condition is true

Hi Rohan!

When do you expect the else clause to be executed? In this case here

if( state == 1 )
{　
  // Do something

  state = 2;
}
else if( state == 2 )
{
  // Do something else
}

the else clause will only be executed the next round the program cycles through this if clause and when state is still set to 2. When state was 1 and the program executes the if clause and sets state to 2, then the else clause will not be executed although state is now 2 because the if clause was already executed. If you have

if( Condition A )
{
  // Option A
}
else if( Condition B )
{
  // Option B
}
else if( Condition C )
{
  // Option C
}
else
{
  // For all other conditions
}

there is always only one clause that will be executed.

I don't know if this is what you are asking about, so if not, please specify your problem in more detail.

Dennis

In other words: if you want the second if to be executed in the same loop iteration, remove the else.

In other words: if you want the second if to be executed in the same loop iteration, remove the else.

Perhaps you haven't noticed the surrounding while (1) { ... } loop. The 'else if' branch should at least execute in the second cycle of this loop. And the state variable is defined as volatile, so it doesn't look like an optimization issue.

f. m. said:

Perhaps you haven't noticed the surrounding while (1) { ... } loop.

Of course we did:

Dennis Eichmann said:

executed the next round the program cycles

Clemens Ladisch said:

executed in the same loop iteration

But no one knows what happens between two cycles. This looks more like a very small portion of the code. In addition no one knows what

receivedChar = dequeue( &REC_q );

does. Maybe it causes

if( !isEmpty( &REC_q ) )

to return FALSE the next cycle.

Dennis

I assume the OP had been debugging through several cycles. He should have noticed if it didn't enter the if(!isEmpty(&REC_q) condition - and tell us.

In theory, it should be sufficient to check whether the state variable is affected by any other operation (beside the state = 2; assignment).

I am sending two screenshots as attachment to show what problem I am getting.

First screenshot - First iteration when the code enters (state == 1) and changes value of state = 2;

Second screenshot - Second iteration the code enters (state == 2) and returns abruptly to main 'if' loop, without entering the else if loop.

The variables with their values and locations can be seen in the top right corner. I hope if that helps in answering the question.

Thanks,

Rohan L

Hi Rohan!

Rohan Lele said:

I am a little reluctant to share the whole project due to confidential reasons.

If you don't want to share it with everyone in the web, I can offer you the possibility to send it to me as a private message. Although I'm at the Embedded World exhibition at the moment, I do have a MSP-EXP430FR4133 LaunchPad in the car.

Rohan Lele said:

Even then, let me know if you can help with the information I have provided

Unfortunately not, otherwise I would have told you how to solve the problem.

Dennis

All the evaluations of dependent multiple conditional statements are done first, only then according code block executed . So changing variable which is already evaluated will do nothing to execution flow because it is already set. As an illustration here's plain C example printing just "state: 1" but not "state: 3"

#include <stdio.h>

void main(void) {
  int state = 1;

  if (state == 1) {
    printf("state: 1\n");
    state = 3;
  } else if (state == 3) {
    printf("state: 3\n");
  }
}

My guess is that there is } at the wrong place, as you are using if and more else if inside the master else if

Use switch & case and code gets cleaner

and even allows for instant fall-through if needed by putting break inside the end bracket

case 4: if (door.openonreturn){  
           door.openonreturn = door.open = 0;                  
           door.state = 2; break;}
                                                               // instant fall-through if not
case 5: ...