CCS/MSP430F5359: Calling function inside interrupt

kary

Part Number: MSP430F5359

Tool/software: Code Composer Studio

Hello, i tired calling function inside timer interrupt by passing a value like: FourSec_Counter(USER_2); the compiler is not happy with it and suggest me to inline it how can i do it? or what maybe the possible solution?

over 6 years ago

0 James Evans over 6 years ago

TI__Mastermind 49692 points

Hello Kary,

Rather than calling lengthy functions in ISRs, it's better to do as much as possible in main() to keep the ISRs short and quick. If you're triggering a four second counter in your ISR, I can see why there would be a compiler warning. Instead, I would recommend starting a four second timer from main(), and then use a timer ISR to trigger when four seconds have passed.

Regards,

James

0 kary over 6 years ago in reply to James Evans

Expert 1165 points

how to inline a function though?

0 Bruce McKenney over 6 years ago in reply to kary

Guru 99155 points

To answer your question: Declare your function with the "inline" keyword, something like:
> static inline void SomeFunction(void) {somestuff;}
Of course it doesn't have to be "void" but I do recommend it be "static" unless there's a strong reason not to.

As to the bigger question(s): (1) [Personal opinion:] You should take the ULP advice with a grain of salt. It tries to be helpful, but I often disagree with the advice. (2) As James says, if you're doing a lot of work in an ISR, you should consider moving that work into main().

0 kary over 6 years ago in reply to Bruce McKenney

Expert 1165 points

when i call that function it's just like regular function call or i need to use inline too?

0 Bruce McKenney over 6 years ago in reply to kary

Guru 99155 points

Call it the way you would an ordinary function.

0 kary over 6 years ago in reply to Bruce McKenney

Expert 1165 points

after inlining also it is showing some problem

0 Bruce McKenney over 6 years ago in reply to kary

Guru 99155 points

What problem is it showing?

0 kary over 6 years ago in reply to Bruce McKenney

Expert 1165 points

function declaration:

static inline void FourSec_Counter(unsigned int UP_DIM)

0 Bruce McKenney over 6 years ago in reply to kary

Guru 99155 points

These are not Errors (nor Warnings), rather they are "Advice". You can safely ignore them; you can even disable them in the Build Settings. I don't know why they're still appearing after you "inline"d the function.

Are these the only messages you're getting?

0 kary over 6 years ago in reply to Bruce McKenney

Expert 1165 points

I splitted the screen so that you can see the function declaration and function, is there anything i'm doing wrong?

0 Bruce McKenney over 6 years ago in reply to kary

Guru 99155 points

I recommend you ignore (and/or disable) the ULP advice, since it's evidently incorrect.

Are there any true compiler warnings or errors? Is your program functioning correctly?

0 Keith Barkley over 6 years ago

Guru 42085 points

ETA:

Never mind, I did not see the break. There are many reasons the compiler won't inline if you ask for it, can you show the whole function?

0 Tomasz Kocon over 6 years ago

Guru 26200 points

Hello Kary,

please provide us with CCS, TI compiler versions and your project optimization settings like below:

0 kary over 6 years ago in reply to Tomasz Kocon

Expert 1165 points

**Attention** This is a public forum

MSP low-power microcontrollers

MSP low-power microcontroller forum

CCS/MSP430F5359: Calling function inside interrupt