TDA4VM: TDA4VM: YOCTO build modifies PACKAGE_CLASSES in local.conf from ipk to deb/rpm format but failed

Kevin Peng

Part Number: TDA4VM
Other Parts Discussed in Thread: DRA829

Hi TI Experts,

The reason of posing this E2E is that most software packages of customer's OS System are .deb / .rpm format. (the default in local.conf is ipk).

They want to use these packages without repackaging. However, if just directly changes PACKAGE_CLASSES = "package_ipk" to "package_rpm" or "package_deb", there will be the following errors.

update-alternatives: Error: not linking /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/rootfs/usr/bin/dpkg-deb to /bin/busybox.nosuid since /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/rootfs/usr/bin/dpkg-deb exists and is not a link

ERROR: tisdk-base-image-1.0-r0 do_rootfs: Postinstall scriptlets of ['busybox'] have failed. If the intention is to defer them to first boot,

then please place them into pkg_postinst_ontarget_${PN} ().

Deferring to first boot via 'exit 1' is no longer supported.

Details of the failure are in /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/temp/log.do_rootfs.

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/temp/log.do_rootfs.122280

ERROR: Task (/workdir/sources/meta-arago/meta-arago-distro/recipes-core/images/tisdk-base-image.bb:do_rootfs) failed with exit code '1'

BTW, the method in the following link also tried but not work (PACKAGE_CLASSES ?= "package_ipk package_rpm")

https://e2e.ti.com/support/processors-group/processors/f/processors-forum/779099/linux-am5728-processor-sdk-linux-05_02_00_10---package_rpm-yocto-build-error/2881062?tisearch=e2e-sitesearch&keymatch=PACKAGE_CLASSES#2881062

It seems a patch is needed in TDA4VM to help customer complete this task?

Could you provide some suggestions on this?

Thanks a lot!

Kevin

over 2 years ago

0 liu zhe over 2 years ago

Prodigy 10 points

complement：

1, I set the PACKAGE_CLASSES = "package_deb" in the local.conf and build the yocto ,I got the error:

ERROR: tisdk-base-image-1.0-r0 do_rootfs: Postinstall scriptlets of ['busybox'] have failed. If the intention is to defer them to first boot,

then please place them into pkg_postinst_ontarget_${PN} ().

Deferring to first boot via 'exit 1' is no longer supported.

Details of the failure are in /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/temp/log.do_rootfs.

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/tisdk-base-image/1.0-r0/temp/log.do_rootfs.122280

ERROR: Task (/workdir/sources/meta-arago/meta-arago-distro/recipes-core/images/tisdk-base-image.bb:do_rootfs) failed with exit code '1'

2, I set the PACKAGE_CLASSES = "package_rpm" in the local.conf and build the yocto ,I got the error:

ERROR: cryptodev-module-1.10-r0.arago1 do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/cryptodev-module/1.10-r0.arago1/temp/run.BUILDSPEC.178' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/cryptodev-module/1.10-r0.arago1/temp/log.do_package_write_rpm.178

ERROR: Task (/workdir/sources/oe-core/meta/recipes-kernel/cryptodev/cryptodev-module_1.10.bb:do_package_write_rpm) failed with exit code '1'

ERROR: trusted-firmware-a-2.8+gitAUTOINC+2fcd408bb3-r0 do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/trusted-firmware-a/2.8+gitAUTOINC+2fcd408bb3-r0/temp/run.BUILDSPEC.175' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/trusted-firmware-a/2.8+gitAUTOINC+2fcd408bb3-r0/temp/log.do_package_write_rpm.175

ERROR: Task (/workdir/sources/meta-arm/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.1.bb:do_package_write_rpm) failed with exit code '1'

ERROR: ti-img-rogue-driver-1.15.6133109-r0b do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/ti-img-rogue-driver/1.15.6133109-r0b/temp/run.BUILDSPEC.195' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/ti-img-rogue-driver/1.15.6133109-r0b/temp/log.do_package_write_rpm.195

ERROR: Task (/workdir/sources/meta-ti/recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb:do_package_write_rpm) failed with exit code '1'

ERROR: u-boot-ti-staging-1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18 do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/u-boot-ti-staging/1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18/temp/run.BUILDSPEC.181' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/u-boot-ti-staging/1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18/temp/log.do_package_write_rpm.181

ERROR: Task (/workdir/sources/meta-ti/recipes-bsp/u-boot/u-boot-ti-staging_2021.01.bb:do_package_write_rpm) failed with exit code '1'

ERROR: mc:k3r5:u-boot-ti-staging-1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18 do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm_k3r5-linux-gnueabi/u-boot-ti-staging/1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18/temp/run.BUILDSPEC.230' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm_k3r5-linux-gnueabi/u-boot-ti-staging/1_2021.01+gitAUTOINC+62a9e51344-r33_psdkla_18/temp/log.do_package_write_rpm.230

ERROR: Task (mc:k3r5:/workdir/sources/meta-ti/recipes-bsp/u-boot/u-boot-ti-staging_2021.01.bb:do_package_write_rpm) failed with exit code '1'

ERROR: linux-ti-staging-rt-5.10.162+gitAUTOINC+02a1d48fd7-r0b.arago1_psdkla_1.4 do_package_write_rpm: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:

File: 'exec_func_python() autogenerated', lineno: 2, function: <module>

0001:

*** 0002:do_package_rpm(d)

0003:

File: '/workdir/sources/oe-core/meta/classes/package_rpm.bbclass', lineno: 712, function: do_package_rpm

0708:

0709: # Build the rpm package!

0710: d.setVar('BUILDSPEC', cmd + "\n" + cleanupcmd + "\n")

0711: d.setVarFlag('BUILDSPEC', 'func', '1')

*** 0712: bb.build.exec_func('BUILDSPEC', d)

0713:

0714: if d.getVar('RPM_SIGN_PACKAGES') == '1':

0715: bb.build.exec_func("sign_rpm", d)

0716:}

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 254, function: exec_func

0250: with bb.utils.fileslocked(lockfiles):

0251: if ispython:

0252: exec_func_python(func, d, runfile, cwd=adir)

0253: else:

*** 0254: exec_func_shell(func, d, runfile, cwd=adir)

0255:

0256: try:

0257: curcwd = os.getcwd()

0258: except:

File: '/workdir/sources/bitbake/lib/bb/build.py', lineno: 455, function: exec_func_shell

0451: with open(fifopath, 'r+b', buffering=0) as fifo:

0452: try:

0453: bb.debug(2, "Executing shell function %s" % func)

0454: with open(os.devnull, 'r+') as stdin, logfile:

*** 0455: bb.process.run(cmd, shell=False, stdin=stdin, log=logfile, extrafiles=[(fifo,readfifo)])

0456: finally:

0457: os.unlink(fifopath)

0458:

0459: bb.debug(2, "Shell function %s finished" % func)

File: '/workdir/sources/bitbake/lib/bb/process.py', lineno: 184, function: run

0180:

0181: if pipe.returncode != 0:

0182: if log:

0183: # Don't duplicate the output in the exception if logging it

*** 0184: raise ExecutionError(cmd, pipe.returncode, None, None)

0185: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)

0186: return stdout, stderr

Exception: bb.process.ExecutionError: Execution of '/workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/linux-ti-staging-rt/5.10.162+gitAUTOINC+02a1d48fd7-r0b.arago1_psdkla_1.4/temp/run.BUILDSPEC.184' failed with exit code 1

ERROR: Logfile of failure stored in: /workdir/build/arago-tmp-external-arm-glibc/work/j7_evm-linux/linux-ti-staging-rt/5.10.162+gitAUTOINC+02a1d48fd7-r0b.arago1_psdkla_1.4/temp/log.do_package_write_rpm.184

ERROR: Task (/workdir/sources/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.10.bb:do_package_write_rpm) failed with exit code '1'

Summary: 6 tasks failed:

/workdir/sources/oe-core/meta/recipes-kernel/cryptodev/cryptodev-module_1.10.bb:do_package_write_rpm

/workdir/sources/meta-arm/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.1.bb:do_package_write_rpm

/workdir/sources/meta-ti/recipes-bsp/powervr-drivers/ti-img-rogue-driver_1.15.6133109.bb:do_package_write_rpm

/workdir/sources/meta-ti/recipes-bsp/u-boot/u-boot-ti-staging_2021.01.bb:do_package_write_rpm

mc:k3r5:/workdir/sources/meta-ti/recipes-bsp/u-boot/u-boot-ti-staging_2021.01.bb:do_package_write_rpm

/workdir/sources/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.10.bb:do_package_write_rpm

Summary: There were 6 ERROR messages shown, returning a non-zero exit code.

0 Karthik Ramanan over 2 years ago in reply to liu zhe

TI__Guru** 113810 points

Hi,

For the TDA4VM, there is no support for rpm.

While you mentioned a starting point for such an enablement, there are additional changes required. This is not planned. Therefore, at the moment there are no suggestions to help you move this further.

We will keep you appraised on any further plans to add rpm/deb package support, in the meantime, please continue to use the default IPK.

Regards
Karthik

0 Kevin Peng over 2 years ago in reply to Karthik Ramanan

TI__Expert 3772 points

Hi Karthik,

Thanks for your clear explanation.

One more thing related to Yocto build support is that do we have a roadmap to support 32 bit program for Jacinto Yocto multilib? Currently if just modify the following lines, there will be some errors.

require conf/multilib.conf

MULTILIBS = "multilib:lib32"

ERROR: OE-core's config sanity checker detected a potential misconfiguration.

Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).

Following is the list of potential problems / advisories:

Toolchain tunings invalid:

No tuning found for lib32 multilib.

Kind Regards,

Kevin

0 Karthik Ramanan over 2 years ago in reply to Kevin Peng

TI__Guru** 113810 points

Kevin,

Regarding the 32bit multilib question, I need more information:

Is this request also related to TDA4VM or is it related to a different SoC?
Which SDK are you using currently?
Can you provide details on why you are specifically looking for 32bit multilib support? It would help me to assess further.

Regards
Karthik

0 Kevin Peng over 2 years ago in reply to Karthik Ramanan

TI__Expert 3772 points

Hi Karthik,

Thanks for your reply!

Let me introduce the background. My industry customer previously used some Sitara chips like am57, am6x and so on. The old SDK of these Sitara chips has some 32-bit programs. Now my customer becomes the leading customer to apply Jacinto chips in industry. They considered both DRA829 & TDA4AP for different applications. Their entire system consists both of Jacinto & Sitara chips. It is hard for them to convert the previous 32-bit programs to run in a 64-bit environment. Hence they would prefer that our Jacinto Industry SDK could also support 32-bit multilib.

From my point of view, there will be more industry customers apply our Jacinto products in the future, this could be discussed further if we can consider it in our roadmap.

Thanks,

Kevin

Processors

Processors forum

TDA4VM: TDA4VM: YOCTO build modifies PACKAGE_CLASSES in local.conf from ipk to deb/rpm format but failed