This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

AM625: PMIC: TPS6521904 binding issue

Part Number: AM625
Other Parts Discussed in Thread: TPS65219

Hello experts!

We are doing PMIC binding for our custom HW.

Used TPS6521904 and below is binding which we add in our dts.

After adding tps65219 kernel binding we are facing issue.

-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Log data follows:
| DEBUG: Executing python function externalsrc_compile_prefunc
| NOTE: linux-ti-staging-rt: compiling from external source tree /home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/workspace/sources/linux-ti-staging-rt
| DEBUG: Python function externalsrc_compile_prefunc finished
| DEBUG: Executing shell function do_compile
| NOTE: KBUILD_BUILD_TIMESTAMP: Tue May 2 05:02:10 UTC 2023
| NOTE: make 1 HOSTCC=gcc -isystem/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/include -O2 -pipe -L/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -L/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,--enable-new-dtags -Wl,-rpath-link,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -Wl,-rpath-link,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,-rpath,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -Wl,-rpath,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,-O1 -Wl,--allow-shlib-undefined -Wl,--dynamic-linker=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/sysroots-uninative/x86_64-linux/lib/ld-linux-x86-64.so.2 HOSTCPP=gcc -E HOSTCXX=g++ -isystem/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/include -O2 -pipe -L/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -L/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,--enable-new-dtags -Wl,-rpath-link,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -Wl,-rpath-link,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,-rpath,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/usr/lib -Wl,-rpath,/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native/lib -Wl,-O1 -Wl,--allow-shlib-undefined -Wl,--dynamic-linker=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/sysroots-uninative/x86_64-linux/lib/ld-linux-x86-64.so.2 Image CC=aarch64-poky-linux-gcc -fuse-ld=bfd -fmacro-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b=/usr/src/debug/linux-ti-staging-rt/5.10.158+git999-r0b -fdebug-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b=/usr/src/debug/linux-ti-staging-rt/5.10.158+git999-r0b -fdebug-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot= -fdebug-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/recipe-sysroot-native= -fdebug-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work-shared/am62xx-onecontrol-lrd/kernel-source=/usr/src/kernel -fdebug-prefix-map=/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work-shared/am62xx-onecontrol-lrd/kernel-build-artifacts=/usr/src/kernel LD=aarch64-poky-linux-ld.bfd LOADADDR=0x80008000 DTC_FLAGS=-@
| make[1]: *** No rule to make target '1'. Stop.
| /home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/workspace/sources/linux-ti-staging-rt/Makefile:185: recipe for target '__sub-make' failed
| make: *** [__sub-make] Error 2
| ERROR: oe_runmake failed
| WARNING: /home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/temp/run.do_compile.24104:1 exit 1 from 'exit 1'
| ERROR: Execution of '/home/aws-suma/builds/build-lrd-am62xx-onecontrol-lrd-5.10-rt-test/tmp/work/am62xx_onecontrol_lrd-poky-linux/linux-ti-staging-rt/5.10.158+git999-r0b/temp/run.do_compile.24104' failed with exit code 1
ERROR: Task (/home/aws-suma/builds/yocto/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.10.bb:do_compile) failed with exit code '1'
NOTE: Tasks Summary: Attempted 3986 tasks of which 3980 didn't need to be rerun and 1 failed.

Summary: 1 task failed:
/home/aws-suma/builds/yocto/meta-ti/recipes-kernel/linux/linux-ti-staging-rt_5.10.bb:do_compile
Summary: There were 2 ERROR messages shown, returning a non-zero exit code.

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Is that fine to give only tps65219 name ?

below is data for binding we added on our custom DTS.

        tps65219: pmic@30 {

            compatible = "ti,tps65219";

            reg = <0x30>;

            buck1-supply = <&vcc_3v3_sys>;

            buck2-supply = <&vcc_3v3_sys>;

            buck3-supply = <&vcc_3v3_sys>;

            ldo1-supply = <&vcc_3v3_sys>;

            ldo2-supply = <&buck2_reg>;

            ldo3-supply = <&vcc_3v3_sys>;

            ldo4-supply = <&vcc_3v3_sys>;

 

            pinctrl-0 = <&pmic_irq_pins_default>;

 

            interrupt-parent = <&gic500>;

            interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;

            interrupt-controller;

            #interrupt-cells = <1>;

 

            regulators {

                buck1_reg: buck1 {

                    regulator-name = "VDD_CORE";

                    regulator-min-microvolt = <750000>;

                    regulator-max-microvolt = <750000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

 

                buck2_reg: buck2 {

                    regulator-name = "VCC1V8";

                    regulator-min-microvolt = <1800000>;

                    regulator-max-microvolt = <1800000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

 

                buck3_reg: buck3 {

                    regulator-name = "VDD_LPDDR4";

                    regulator-min-microvolt = <1200000>;

                    regulator-max-microvolt = <1200000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

 

                ldo1_reg: ldo1 {

                    regulator-name = "VDDSHV_SD_IO_PMIC";

                    regulator-min-microvolt = <33000000>;

                    regulator-max-microvolt = <33000000>;

                };

 

                ldo2_reg: ldo2 {

                    regulator-name = "VDDAR_CORE";

                    regulator-min-microvolt = <850000>;

                    regulator-max-microvolt = <850000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

 

                ldo3_reg: ldo3 {

                    regulator-name = "VDDA_1V8";

                    regulator-min-microvolt = <18000000>;

                    regulator-max-microvolt = <18000000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

 

                ldo4_reg: ldo4 {

                    regulator-name = "VDD_PHY_2V5";

                    regulator-min-microvolt = <25000000>;

                    regulator-max-microvolt = <25000000>;

                    regulator-boot-on;

                    regulator-always-on;

                };

            };

        };

    };

is that fine or we need to add on u-boot DTS as well ?

Anything we missed here?

Thanks,

Suraj.

  • Hi Suraj,

    | make[1]: *** No rule to make target '1'. Stop.

    I am not sure why make target '1' is here, but I seems to be the main issue.

    Do you see this error if not add the PMIC device tree node?

    below is data for binding we added on our custom DTS.

    Is this snippet all the PMIC node you added to DTS? It seems the closing brackets is imbalanced with the open brackets. At the end it should be 3 closing brackets, not 4.

    is that fine or we need to add on u-boot DTS as well ?

    Yes. Kernel DTS has nothing to do with U-Boot DTS.

  • Hi Bin, 

    below is answer for your questions.

    Do you see this error if not add the PMIC device tree node? -----> No not seen this error. Once we add pmic then only gettings.

    Is this snippet all the PMIC node you added to DTS?  -------------> yes all this snippet added to DTS. That 4th bracket is for i2c0 we used.

    Is that I did any wrong on bindings ? 

    Do we need to add extra on that ? 

  • Hi Bin,

    Got some progress!

    We tried on SDK so worked some how and got beloow error.

    DTC     arch/arm64/boot/dts/ti/onecontrol.dtb
    arch/arm64/boot/dts/ti/onecontrol.dts:602.18-662.3: ERROR (phandle_references): /bus@f0000/i2c@20000000/pmic@30: Reference to non-existent node or label "pmic_irq_pins_default"

    ERROR: Input tree has errors, aborting (use -f to force output)
    scripts/Makefile.lib:328: recipe for target 'arch/arm64/boot/dts/ti/onecontrol.dtb' failed
    make[1]: *** [arch/arm64/boot/dts/ti/onecontrol.dtb] Error 2
    Makefile:1370: recipe for target 'ti/onecontrol.dtb' failed
    make: *** [ti/onecontrol.dtb] Error 2

    Anything missing for this irq-default-pins ?

    Thanks,

    Suraj.