• State Resolved
  • Locked Locked
  • Replies 2 replies
  • Subscribers 97 subscribers
  • Views 193 views
  • Users 0 members are here
Support feedback
Options
Options
Related

This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

OCTVO-3P-AM335X: Issues with AM335X and Marvel 88E1215 Phy

Jeff Coffman
Prodigy 10 points
Part Number: OCTVO-3P-AM335X

Hello,

I have a custom design which uses an Octavo SIP and it is interfaced to a Marvell 88E1215,to magnetics to RJ45.  I can read and set phy registers over mdio, bring the eth interface up and set ip address but thats about it.  I cannot seems to send data in or out.  I can detect link activity on the port.

My pinmux is as follows, as the phy is connected to the second emac via RGMII2.

	rgmii_switch_pins_default: rgmii_switch_pins_default {
		pinctrl-single,pins = <
			AM33XX_IOPAD(0x840, PIN_OUTPUT | MUX_MODE2) /* (R13) gpmc_a0.rgmii2_tctl */
			AM33XX_IOPAD(0x844, PIN_INPUT | MUX_MODE2) /* (V14) gpmc_a1.rgmii2_rctl */
			AM33XX_IOPAD(0x858, PIN_OUTPUT | MUX_MODE2) /* (U15) gpmc_a6.rgmii2_tclk */
			AM33XX_IOPAD(0x85c, PIN_INPUT | MUX_MODE2) /* (T15) gpmc_a7.rgmii2_rclk */
			AM33XX_IOPAD(0x854, PIN_OUTPUT | MUX_MODE2) /* (V15) gpmc_a5.rgmii2_td0 */
			AM33XX_IOPAD(0x850, PIN_OUTPUT | MUX_MODE2) /* (R14) gpmc_a4.rgmii2_td1 */
			AM33XX_IOPAD(0x84c, PIN_OUTPUT | MUX_MODE2) /* (T14) gpmc_a3.rgmii2_td2 */
			AM33XX_IOPAD(0x848, PIN_OUTPUT | MUX_MODE2) /* (U14) gpmc_a2.rgmii2_td3 */
			AM33XX_IOPAD(0x86c, PIN_INPUT | MUX_MODE2) /* (V17) gpmc_a11.rgmii2_rd0 */
			AM33XX_IOPAD(0x868, PIN_INPUT | MUX_MODE2) /* (T16) gpmc_a10.rgmii2_rd1 */
			AM33XX_IOPAD(0x864, PIN_INPUT | MUX_MODE2) /* (U16) gpmc_a9.rgmii2_rd2 */
			AM33XX_IOPAD(0x860, PIN_INPUT | MUX_MODE2) /* (V16) gpmc_a8.rgmii2_rd3 */
		>;
	};

	/* Optional sleep pin settings. Must manually enter values in the below skeleton. */
	rgmii_switch_pins_sleep: rgmii_switch_pins_sleep {
		pinctrl-single,pins = <
			AM33XX_IOPAD(0x840, PIN_OUTPUT | MUX_MODE2) /* (R13) gpmc_a0.rgmii2_tctl */
			AM33XX_IOPAD(0x844, PIN_INPUT | MUX_MODE2) /* (V14) gpmc_a1.rgmii2_rctl */
			AM33XX_IOPAD(0x858, PIN_OUTPUT | MUX_MODE2) /* (U15) gpmc_a6.rgmii2_tclk */
			AM33XX_IOPAD(0x85c, PIN_INPUT | MUX_MODE2) /* (T15) gpmc_a7.rgmii2_rclk */
			AM33XX_IOPAD(0x854, PIN_OUTPUT | MUX_MODE2) /* (V15) gpmc_a5.rgmii2_td0 */
			AM33XX_IOPAD(0x850, PIN_OUTPUT | MUX_MODE2) /* (R14) gpmc_a4.rgmii2_td1 */
			AM33XX_IOPAD(0x84c, PIN_OUTPUT | MUX_MODE2) /* (T14) gpmc_a3.rgmii2_td2 */
			AM33XX_IOPAD(0x848, PIN_OUTPUT | MUX_MODE2) /* (U14) gpmc_a2.rgmii2_td3 */
			AM33XX_IOPAD(0x86c, PIN_INPUT | MUX_MODE2) /* (V17) gpmc_a11.rgmii2_rd0 */
			AM33XX_IOPAD(0x868, PIN_INPUT | MUX_MODE2) /* (T16) gpmc_a10.rgmii2_rd1 */
			AM33XX_IOPAD(0x864, PIN_INPUT | MUX_MODE2) /* (U16) gpmc_a9.rgmii2_rd2 */
			AM33XX_IOPAD(0x860, PIN_INPUT | MUX_MODE2) /* (V16) gpmc_a8.rgmii2_rd3 */
		>;
	};

I have the following entries in my device tree (dts)

&davinci_mdio {
	pinctrl-names = "default", "sleep";
	pinctrl-0 = <&davinci_mdio_default>;
	pinctrl-1 = <&davinci_mdio_sleep>;
	status = "okay";
	/*  The expander comes up long after mdio probe */
	reset-gpios = <&tca6424 3 GPIO_ACTIVE_LOW>;
	reset-delay-us = <10000>;
};


&cpsw_emac0 {
	status = "disabled";
	phy_id = <&davinci_mdio>, <0>;
	phy-mode = "rgmii-id";
	dual_emac_res_vlan = <1>;
};

/*1788 connected to port 1 (RGMII2)*/
&cpsw_emac1 {
	status = "okay";
	phy_id = <&davinci_mdio>, <1>;
	phy-mode = "rgmii-id";
	dual_emac_res_vlan = <2>;
};

&mac {
	status = "okay";
	pinctrl-names = "default", "sleep";
	pinctrl-0 = <&rgmii_switch_pins_default>;
	pinctrl-1 = <&rgmii_switch_pins_sleep>;
    active_slave = <1>;
    /* This shouldnt be needed but i get odd issues without it...*/
    dual_emac = <1>;
};

During startup I have the following output.

[    8.218342] mdio_bus 4a101000.mdio: GPIO lookup for consumer reset
[    8.218363] mdio_bus 4a101000.mdio: using lookup tables for GPIO lookup
[    8.218379] mdio_bus 4a101000.mdio: lookup for GPIO reset failed
[    8.276467] davinci_mdio 4a101000.mdio: davinci mdio revision 1.6, bus freq 1000000
[    8.284518] davinci_mdio 4a101000.mdio: detected phy mask fffffffd
[    8.309085] libphy: 4a101000.mdio: probed
[    8.313321] davinci_mdio 4a101000.mdio: phy[1]: device 4a101000.mdio:01, driver Marvell 88E1510
[    8.323832] cpsw 4a100000.ethernet: Detected MACID = 60:b6:e1:66:94:11
[    8.333132] cpsw 4a100000.ethernet: cpsw: Random MACID = da:fc:6a:49:c2:e5



[    8.739230] net eth0: initializing cpsw version 1.12 (0)
[    8.744807] cpsw 4a100000.ethernet: initialized cpsw ale version 1.4
[    8.751584] cpsw 4a100000.ethernet: ALE Table size 1024
[    8.858112] Marvell 88E1510 4a101000.mdio:01: attached PHY driver [Marvell 88E1510] (mii_bus:phy_addr=4a101000.mdio:01, irq=POLL)

I've put the phy in loopback and run the loopback test (from octavo) and that appears to work.  However no ping, etc.  Not sure what is going on and hoping someone has some tips.

One thing I had issues with was when I didn't configure the mac in dual mode, I get the initial probe to work but then it seemed confused when ever i tried to communicate with the phy; so after that so I set it to dual mac mode.

Anyway any help appreciated!

Thanks!

Jeff

  • 0
    TI__Mastermind 40080 points

    Hi,

    Which TI SDK are you using? Is the only the RGMII2 port is use? If so you will have to set a DTS field to make the RGMII2 the primary port.

    Best Regards,

    Schuyler

  • +1 in reply to Schuyler Patton
    Prodigy 10 points

    Hi,

    We're using buildroot and it fetches an older ti kernel 4.14.18.  We only use port two and it was set correctly.

    I just got it working but required a patch to cpsw.c where it supports when only one port was used.   I got this patch internally form another project, but never really found anything online addressing this.  So I don't know the background story yet.  I've attached the patch in case others run into this issue.

    --- a/drivers/net/ethernet/ti/cpsw.c	2018-08-28 14:03:00.187259415 -0500
+++ b/drivers/net/ethernet/ti/cpsw.c	2018-08-28 14:05:36.401690844 -0500
@@ -1277,6 +1277,12 @@
 
 	soft_reset_slave(slave);
 
+	/* Don't initialize slaves with no associated PHY. */
+	if (!slave->data->phy_node) {
+		pr_err("cpsw: no PHY for slave %d\n", slave->slave_num);
+		return;
+	}
+
 	/* setup priority mapping */
 	__raw_writel(RX_PRIORITY_MAPPING, &slave->sliver->rx_pri_map);
 
@@ -1317,7 +1323,7 @@
 		cpsw_ale_add_mcast(cpsw->ale, priv->ndev->broadcast,
 				   1 << slave_port, 0, 0, ALE_MCAST_FWD_2);
 
-	if (slave->data->phy_node) {
+	{
 		phy = of_phy_connect(priv->ndev, slave->data->phy_node,
 				 &cpsw_adjust_link, 0, slave->data->phy_if);
 		if (!phy) {
@@ -1326,16 +1332,6 @@
 				slave->slave_num);
 			return;
 		}
-	} else {
-		phy = phy_connect(priv->ndev, slave->data->phy_id,
-				 &cpsw_adjust_link, slave->data->phy_if);
-		if (IS_ERR(phy)) {
-			dev_err(priv->dev,
-				"phy \"%s\" not found on slave %d, err %ld\n",
-				slave->data->phy_id, slave->slave_num,
-				PTR_ERR(phy));
-			return;
-		}
 	}
 
 	slave->phy = phy;
@@ -2669,40 +2665,9 @@
 							"phy-handle", 0);
 		parp = of_get_property(slave_node, "phy_id", &lenp);
 		if (slave_data->phy_node) {
-			dev_dbg(&pdev->dev,
+			dev_err(&pdev->dev,
 				"slave[%d] using phy-handle=\"%pOF\"\n",
 				i, slave_data->phy_node);
-		} else if (of_phy_is_fixed_link(slave_node)) {
-			/* In the case of a fixed PHY, the DT node associated
-			 * to the PHY is the Ethernet MAC DT node.
-			 */
-			ret = of_phy_register_fixed_link(slave_node);
-			if (ret) {
-				if (ret != -EPROBE_DEFER)
-					dev_err(&pdev->dev, "failed to register fixed-link phy: %d\n", ret);
-				return ret;
-			}
-			slave_data->phy_node = of_node_get(slave_node);
-		} else if (parp) {
-			u32 phyid;
-			struct device_node *mdio_node;
-			struct platform_device *mdio;
-
-			if (lenp != (sizeof(__be32) * 2)) {
-				dev_err(&pdev->dev, "Invalid slave[%d] phy_id property\n", i);
-				goto no_phy_slave;
-			}
-			mdio_node = of_find_node_by_phandle(be32_to_cpup(parp));
-			phyid = be32_to_cpup(parp+1);
-			mdio = of_find_device_by_node(mdio_node);
-			of_node_put(mdio_node);
-			if (!mdio) {
-				dev_err(&pdev->dev, "Missing mdio platform device\n");
-				return -EINVAL;
-			}
-			snprintf(slave_data->phy_id, sizeof(slave_data->phy_id),
-				 PHY_ID_FMT, mdio->name, phyid);
-			put_device(&mdio->dev);
 		} else {
 			dev_err(&pdev->dev,
 				"No slave[%d] phy_id, phy-handle, or fixed-link property\n",