AM5728: dra7-pcie: probe of 51800000.pcie_ep failed with error -22

Hello Sujan,

My initial recommendation is to reach out to Phytec through their support channel at http://support.phytec.com/ as the quickest path to resolution.

From the TI viewpoint, we are not very familiar with their software, nor do we have the HW to attempt to reproduce issue.

From a glance at the traces you have provided, maybe you could look into what changes were made the PCIe driver 

dra7-pcie

I hope that helps!

Best,

Josue

Hi Josue,
Thanks for responding,

We have contacted PHYTEC support & they are working on it.

Meanwhile I found that in Documentation/devicetree/bindings/pci/ti-pci.txt , The compatible field shows that

TI PCI Controllers

PCIe DesignWare Controller
 - compatible: Should be "ti,dra7-pcie" for RC (deprecated)
               Should be "ti,dra7-pcie-ep" for EP (deprecated)
               Should be "ti,dra746-pcie-rc" for dra74x/dra76 in RC mode
               Should be "ti,dra746-pcie-ep" for dra74x/dra76 in EP mode
               Should be "ti,dra726-pcie-rc" for dra72x in RC mode
               Should be "ti,dra726-pcie-ep" for dra72x in EP mode

The "ti,dra7-pcie-ep"  has been depreciated, but in our device tree we are still using this value only by default.

Here is our device tree : 

/* NOTE: support added for pcie2 in endpoint mode
 *       additionally, setting axi1 { status = "okay" };
 *       is necessary for any pcie2 use.
 *
 *       pcie2_rc/ep are incompatible with PCM-948
 */
&axi1 {
        status = "okay";
        pcie2_ep: pcie_ep@51800000 {
                compatible = "ti,dra7-pcie-ep"; // default value - unchanged 
                reg = <0x51800000 0x28>, <0x51802000 0x14c>,
                      <0x51801000 0x28>, <0x1000 0x10000000>;
                reg-names = "ep_dbics", "ti_conf", "ep_dbics2", "addr_space";
                interrupts = <0 355 0x4>;
                num-lanes = <1>;
                num-ib-windows = <4>;
                num-ob-windows = <16>;
                ti,hwmods = "pcie2";
                phys = <&pcie2_phy>; //since we are using pcie lane 2
                //phy-names = "pcie-phy1";
                phy-names = "pcie-phy0";
                syscon-legacy-mode = <&scm_conf1 0x14 1>;

                reset-delay-us = <20000>;
                status = "okay";
        };
};

Any thoughts ?

Best Regards,
Sujan

Hello Sujan,

Possibly using the the newer driver would help but its hard to say what the effort would be. It seems BSP (20.1.2) corresponds to our SDK release 06.02.00.81 so you could look into that one and the following release as a resource. 

Hope that helps.

-Josue

Hello Josue,

We noticed that the probe error is being registered when : 

phy-names = "pcie-phy0"; 

and not 

phy-names = "pcie-phy1";

Although from ti_pci.txt, its mentioned that : 

- phy-names : must be "pcie-phy0", "pcie-phy1", "pcie-phyN".. based on the
number of PHYs as specified in *phys* property. 

as our *phys* property does consist of only one &pcie2_phy, so it should have been pcie-phy0 and not pcie-phy1 by default.

Also Note that setting the phy-names = "pcie-phy1";  does eliminate the probe error, but its not creating a 51800000.pcie_ep  device in /sys/kernel/config/pci_ep/controllers/. 
Which is required to bind the controller.

Any Suggestions ?

Regards,
Sujan

Hi Takuma,

Sorry for opening two threads,

We were previously getting dra7-pcie: probe of 51800000.pcie_ep failed with error -22

I thought it was resolved, from the reply I had given before this. So I just wanted to continue where we left off.

I will close the thread and we can continue in the other thread.

Thanks,

Sujan