• State Resolved
  • Locked Locked
  • Replies 4 replies
  • Subscribers 98 subscribers
  • Views 155 views
  • Users 0 members are here
Support feedback
Options
Options
Related

This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

TDA4VM: SDK 9.0: Missing ?= in vision_apps makefile

FredC_LT
Intellectual 796 points
Part Number: TDA4VM

Hi,

The file "/ti-processor-sdk-rtos-j721s2-evm-09_00_00_02/vision_apps/tools_path.mak" has the following line at the start:

PSDK_PATH = $(abspath ..)
However, most of the other makefiles use the operator ?= instead to allow path injection.
PSDK_PATH ?= $(abspath ..)
This is useful when building a vision_apps folder that's not in the sdk tree.
 
Can this be fixed in a future release?
  • 0
    TI__Guru* 85296 points

    Hi Fred,

    I see that only tools_path.mak has ?= missing. And this is being used only to point to the sdk_builder repo.

    The build_flags.mak has ?= included.

    May I know why is this needed in tools_path?

    Regards,

    Nikhil

  • 0 in reply to Nikhil Dasan
    Intellectual 796 points

    We maintain a copy of the released vision_apps folder with a few addons and patches for our application.

    Let's say we have these paths:

    • /opt/ti-processor-sdk-rtos-j721e-evm-09_00_00_02/
    • /opt/custom_vision_apps

    To build our vision_apps, we do

    # export PSDKR_PATH=/opt/ti-processor-sdk-rtos-j721e-evm-09_00_00_02
# cd $PSDKR_PATH/sdk_builder
# make vision_apps -j VISION_APPS_PATH=/opt/custom_vision_apps PSDK_PATH=$PSDKR_PATH

    The makefile flow is then

    $PSDKR_PATH/sdk_builder/Makefile
    include tools_path.mak
        PSDK_PATH ?= $(abspath ..)      # Still stays to $PSDKR_PATH
    include vision_apps_build_flags.mak
        PSDK_PATH ?= $(abspath ..)      # Still stays to $PSDKR_PATH
    include makerules/makefile_vision_apps.mak
        $(MAKE) -C $(VISION_APPS_PATH)
            /opt/custom_vision_apps/Makefile
                include tools_path.mak
                    PSDK_PATH = $(abspath ..)   # PSDK_PATH gets reassigned

    If I add

    $(error "PSDK_PATH=$(PSDK_PATH)")

    in my custom_vision_apps/tools_path.mak, it indeed prints

    tools_path.mak:5: *** "PSDK_PATH=/opt/my_custom_vision_apps ".  Stop.
    So the fix is to change the '=' operator to '?='. It's not a big fix, but we try to minimize vision_apps differences with the SDK to facilitate new SDK integrations. Also, it seems weird that all other .mak use ?= and this one is the only one that uses '='.
    Thanks,
    Fred
  • +1 in reply to FredC_LT
    TI__Guru* 85296 points

    Hi Fred,

    Thank you for the explaination. 

    I have filed JIRA for this. 
    Placing the JIRA link here for internal tracking purpose.

    jira.itg.ti.com/browse/ADASVISION-6097

    This should be resolved in the upcoming release. If any updates, I shall let you know.

    Regards,

    Nikhil