How to insert Comment Marker in JPEG encoder

Gennadiy Kiryukhin

What is the proper way to insert a comment marker?

I get errors

CMEMK Error: get_phys: Unable to find phys addr for 0x00000018
CMEMK Error: get_phys: get_user_pages() failed: -14
CMEMK Error: GETPHYS: Failed to convert virtual 0x18 to physical.

when calling IMGENC1_process:

memset(&jpegInargs, 0, sizeof(jpegInargs));
memset(&jpegOutargs, 0, sizeof(jpegOutargs));
jpegInargs.imgencInArgs.size = sizeof(jpegInargs);
jpegInargs.sliceNum = 0;
jpegOutargs.imgencOutArgs.size = sizeof(jpegOutargs);
jpegOutargs.imgencOutArgs.bytesGenerated = 0;
inbufdesc.numBufs = 1;
inbufdesc.descs[0].buf = encoder_output_buffer; // no input buffer (generating header only)
inbufdesc.descs[0].bufSize = JPEG_BUF_SIZE;
outbufdesc.numBufs = 1;
outbufdesc.descs[0].buf = encoder_output_buffer;
outbufdesc.descs[0].bufSize = JPEG_BUF_SIZE;

jpegInargs.insertCommentMarker = 1;
jpegInargs.commentSegLen = strlen(comments);

res = IMGENC1_process(ieh, &inbufdesc, &outbufdesc, (IIMGENC1_InArgs*)&jpegInargs, (IIMGENC1_OutArgs*)&jpegOutargs) ;

Update:

When insertCommentMarker = 1and commentSegLen = strlen() lines in the code above are removed, the encoder runs without any errors and the picture is encoded properly.

over 14 years ago

0 Pramod Kumar Swami over 14 years ago

TI__Genius 14090 points

Can you please specify the platform and codec version number being used?

Thanks,
With Regards,
Pramod

0 Gennadiy Kiryukhin over 14 years ago in reply to Pramod Kumar Swami

Expert 2800 points

Codec is from DVSDK 3.1 (I think it is 2.0) on DM355.

0 Akshay Panday over 14 years ago in reply to Gennadiy Kiryukhin

Expert 1640 points

Hi Gennadiy,

Can you confirm the exact codec version, 2.00.00.xx?

What is the length of the comment marker that you are specifying here?

Regards,

Akshay

0 Gennadiy Kiryukhin over 14 years ago in reply to Akshay Panday

Expert 2800 points

pegenc 02.00.00.03

Comment marker is a short text string about 20-30 characters long.

0 Gennadiy Kiryukhin over 14 years ago in reply to Gennadiy Kiryukhin

Expert 2800 points

Any progress ?

0 Gennadiy Kiryukhin over 14 years ago in reply to Gennadiy Kiryukhin

Expert 2800 points

Anybody, please?

0 Gennadiy Kiryukhin over 14 years ago in reply to Gennadiy Kiryukhin

Expert 2800 points

I was able to insert comments marker without using the "feature" of the encoder. After generating the header (and before encoding the picture) I saved first 20 bytes of data into a file. Then I wrote 0xFF, 0xFE, followed by two bytes representing the size of my comments data + 2 (MSB first). After that, I wrote my text string. Then, I wrote the rest of the generated data. That did it.

Processors

Processors forum

How to insert Comment Marker in JPEG encoder