• State Resolved
  • Locked Locked
  • Replies 2 replies
  • Subscribers 98 subscribers
  • Views 441 views
  • Users 0 members are here
Support feedback
Options
Options
Related

This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

Oops in ti81xxvid_main.c in vidioc_streamon()

robert schulman
Prodigy 220 points

I am on a 8148 EVM using Linux PSP 04.01.00.07.

If one opens /dev/video1 as a display device and neglects to do a VIDIOC_REQBUFS ioctl before performing a VIDIOC_STREAMON ioctl, one gets an Oops from the kernel.

The ti81xxvo module should be more robust than this.

Specifically, the value of (&vout->dma_queue)->next is NULL when VIDIOC_REQBUFS has not been invoked and this expression should be checked for validity before it is used in vidioc_streamon().

bob

  • 0
    TI__Guru 65750 points

    Bob,

    without calling VIDIOC_REQBUFS, v4l2 display will not work. but driver should not cause Oops.

    It is a very good capture, driver should have taken care this. we will fix this in the next release.

    Regards,

    yihe

  • 0 in reply to yihe
    Prodigy 220 points

    Yihe,

    Thanks for the quick response. Thanks for pointing out that a STREAMON without a REQBUFS is pretty useless...I should have saved you the trouble of pointing that out in my original note as I knew I was being a Bad Dog in doing so. 

    bob