This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

Submitting patches for linux-am33x git repo

Dear TI Linux Kernel team,

could you please backport this patch?

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=b8e3995af4c7da7707b1710332a31f66e06b74dc

I'm using ICPlus phy and it also needs PHY_INTERFACE_MODE_RGMII flag:

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index e5598a2..2c2da04 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -20,6 +20,7 @@
 #include <linux/of.h>
 #include <linux/davinci_emac.h>
 #include <linux/cpsw.h>
+#include <linux/phy.h>
 #include <linux/etherdevice.h>
 #include <linux/dma-mapping.h>
 #include <linux/can/platform/d_can.h>
@@ -1309,6 +1310,8 @@ int am33xx_cpsw_init(enum am33xx_cpsw_mac_mode mode, unsigned char *phy_id0,
                break;
        case AM33XX_CPSW_MODE_RGMII:
                gmii_sel = AM33XX_RGMII_MODE_EN;
+               am33xx_cpsw_slaves[0].phy_if = PHY_INTERFACE_MODE_RGMII;
+               am33xx_cpsw_slaves[1].phy_if = PHY_INTERFACE_MODE_RGMII;
                break;
        default:
                return -EINVAL;

What is the official way to submit patches to http://arago-project.org/git/projects/?p=linux-am33x.git;a=summary?

Best regards,

Yegor

  • Yegor

    You can send the patch in this forum itself either with public repository on top of arago git repo or as attachment in the post so that we can review the patch and pull in the code to arago git repo.

    Regards
    Mugunthan V N

  • Mugunthan

    thanks for the info. Then I'm waiting for review.

    Yegor

  • Yegor

    The diff is fine. Can you submit the same as a patch, so that i can pull in the same to am335x git repo

    Regards
    Mugunthan V N

  • Here you are. Thanks for review

    Yegor

    From ca107d6fa5199f627c1df850a899020fb8ad32bc Mon Sep 17 00:00:00 2001
    From: Yegor Yefremov <yegorslists@googlemail.com>
    Date: Tue, 11 Dec 2012 10:01:49 +0100
    Subject: [PATCH] net: specify phy_if for RGMII mode
    
    Some phys like ICPlus IP1001 require this flag to be set
    in order to setup proper clock delay.
    
    Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
    ---
     arch/arm/mach-omap2/devices.c |    3 +++
     1 files changed, 3 insertions(+), 0 deletions(-)
    
    diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
    index e5598a2..2c2da04 100644
    --- a/arch/arm/mach-omap2/devices.c
    +++ b/arch/arm/mach-omap2/devices.c
    @@ -20,6 +20,7 @@
     #include <linux/of.h>
     #include <linux/davinci_emac.h>
     #include <linux/cpsw.h>
    +#include <linux/phy.h>
     #include <linux/etherdevice.h>
     #include <linux/dma-mapping.h>
     #include <linux/can/platform/d_can.h>
    @@ -1309,6 +1310,8 @@ int am33xx_cpsw_init(enum am33xx_cpsw_mac_mode mode, unsigned char *phy_id0,
     		break;
     	case AM33XX_CPSW_MODE_RGMII:
     		gmii_sel = AM33XX_RGMII_MODE_EN;
    +		am33xx_cpsw_slaves[0].phy_if = PHY_INTERFACE_MODE_RGMII;
    +		am33xx_cpsw_slaves[1].phy_if = PHY_INTERFACE_MODE_RGMII;
     		break;
     	default:
     		return -EINVAL;
    -- 
    1.7.7
    
    

    From ca107d6fa5199f627c1df850a899020fb8ad32bc Mon Sep 17 00:00:00 2001
    From: Yegor Yefremov <yegorslists@googlemail.com>
    Date: Tue, 11 Dec 2012 10:01:49 +0100
    Subject: [PATCH] net: specify phy_if for RGMII mode

    Some phys like ICPlus IP1001 require this flag to be set
    in order to setup proper clock delay.

    Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
    ---
     arch/arm/mach-omap2/devices.c |    3 +++
     1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
    index e5598a2..2c2da04 100644
    --- a/arch/arm/mach-omap2/devices.c
    +++ b/arch/arm/mach-omap2/devices.c
    @@ -20,6 +20,7 @@
     #include <linux/of.h>
     #include <linux/davinci_emac.h>
     #include <linux/cpsw.h>
    +#include <linux/phy.h>
     #include <linux/etherdevice.h>
     #include <linux/dma-mapping.h>
     #include <linux/can/platform/d_can.h>
    @@ -1309,6 +1310,8 @@ int am33xx_cpsw_init(enum am33xx_cpsw_mac_mode mode, unsigned char *phy_id0,
                    break;
            case AM33XX_CPSW_MODE_RGMII:
                    gmii_sel = AM33XX_RGMII_MODE_EN;
    +               am33xx_cpsw_slaves[0].phy_if = PHY_INTERFACE_MODE_RGMII;
    +               am33xx_cpsw_slaves[1].phy_if = PHY_INTERFACE_MODE_RGMII;
                    break;
            default:
                    return -EINVAL;
    --
    1.7.7

  • Could you please backport this patch: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=898f08e159bb63eaa5843f8dc0dab9592d4bae4c

    Discussion: http://e2e.ti.com/support/dsp/sitara_arm174_microprocessors/f/791/p/189862/708431.aspx

    The patch below is fixed for 3.2, because AM33XX macro was changed in the later kernels:

    From 690ed5a8c5240115b7655a65f450f01ae649f203 Mon Sep 17 00:00:00 2001
    From: Yegor Yefremov <yegorslists@googlemail.com>
    Date: Tue, 11 Dec 2012 16:37:47 +0100
    Subject: [PATCH] arm: increase FORCE_MAX_ZONEORDER for TI AM33XX
    
    FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
    of consistent DMA memory (da8xx frame buffer driver).
    
    Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
    Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
    ---
     arch/arm/Kconfig |    1 +
     1 files changed, 1 insertions(+), 0 deletions(-)
    
    diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
    index f44d5a0..870350e 100644
    --- a/arch/arm/Kconfig
    +++ b/arch/arm/Kconfig
    @@ -1700,6 +1700,7 @@ source "mm/Kconfig"
     config FORCE_MAX_ZONEORDER
     	int "Maximum zone order" if ARCH_SHMOBILE
     	range 11 64 if ARCH_SHMOBILE
    +	default "12" if  SOC_OMAPAM33XX
     	default "9" if SA1111
     	default "11"
     	help
    -- 
    1.7.7
    
    

    Thanks.

    Yegor

  • Yegor

    Will apply the network related patches to arago am335x git repo.
    Will check the other patch internally and will try to apply the patch.

    Regards
    Mugunthan V N