memory leak when reading EDID in DM814x EZSDK 5.05?

Daniel70334

In board-support/linux-2.6.37-psp04.04.00.01/drivers/video/ti81xx/ti81xxhdmi/hdmi.c, in hdmi_get_edid(): if HDMI_CORE_DDC_READEDID() fails, then the buffers allocated by kzalloc() are all lost, right? It seems like HDMI_CORE_DDC_READEDID() should be done first ...

over 12 years ago

0 Renjith Thomas over 12 years ago

Guru 31670 points

Daniel,

You are right. There is a memory leak if EDID read fails. It has to be handled properly by freeing the allocated buffers, if read fails.

0 Daniel70334 over 12 years ago in reply to Renjith Thomas

Expert 1745 points

Renjith,

Can you ask the SDK team to fix this?

Thanks,

Dan -

0 Renjith Thomas over 12 years ago in reply to Daniel70334

Guru 31670 points

Daniel,

Will report this to the PSP team.

0 Sujith over 12 years ago in reply to Renjith Thomas

TI__Genius 12455 points

Hi Daniel,

This issue is addressed and the next version of PSP will have a proper fix for it.

Thanks,

Sujith

Processors

Processors forum

memory leak when reading EDID in DM814x EZSDK 5.05?