ADC DTS file

You already have opened at least two threads on this topic. Please post on the original threads, so that you can reach people who replied to you. I am closing this thread now.

Hi Naven,

The firs error message, reporting fail to map registers:

p naveen kumar said:

ADC_DRIVER 44e0d000.tscadc: failed to map registers.

Indicates that your kernel still uses the drivers/mfd/ti_am335x_tscadc.c driver (default ti touchscreen_adc controller driver) the message comes from the bellow fragment of code:
    tscadc->tscadc_base = devm_ioremap(&pdev->dev,
            res->start, resource_size(res));
    if (!tscadc->tscadc_base) {
        dev_err(&pdev->dev, "failed to map registers.\n");
        return -ENOMEM;
    }

Can you put some debug printks in your driver to be sure that it is built in the kernel? If not, try adding it to tisdk_am335x-evm_defconfig file.

Also can you post the modified device tree structures for the ADC?

Best Regards,

Yordan

Hi Yordan,

  ***********  am33xx.dtsi ********************************

 tscadc: tscadc@44e0d000 {
            compatible = "ti,adcsample";
             reg = <0x44e0d000 0x1000>;
             interrupt-parent = <&intc>;
             interrupts = <16>;
             ti,hwmods = "adc_tsc";
             clocks = <&adc_tsc_fck>;
             clock-names = "fck";
             status = "disabled";

           am335x_adc: adc {
                   #io-channel-cells = <1>;
                   compatible = "ti,adcsample";
             };
       };

**************************   am335x-evm.dts ***************************************

&tscadc {
    status = "okay";
    tsc {
        ti,wires = <4>;
        ti,x-plate-resistance = <200>;
        ti,coordinate-readouts = <5>;
        ti,wire-config = <0x00 0x11 0x22 0x33>;
    };

    adc {
         ti,adc-channels = <4 5 6 7>;
    };

};

******************** my driver *******************************************

 static const struct of_device_id ti_tscadc_dt_ids[] = {
         { .compatible = "ti,adcsample",  },
             { }
 };
*****************************************************************************

but the problem is not created proper dts file ,

my quistion is sample character driver enable all adc registers etc ,but how my character driver add with dts file ??

u told that change in dts file according my driver so same way i change but it not work properly

may be iam doing any mistake ,please give me sujestion and is the way is correct and any changes need ??

Thanks & Regards,

Naven

Hi Yordan,

Thanks for reply and i solve the interrupt problem ,i hard coded 32 number in request_irq first argument,

so the handler will call . but the problem is reading data from fifo is not proper values the only channel 7 value will be

correct but remaining values will get wrong but i did not understand wats problem my register configuration

i sending my registers  configuration and log file check once .

Register Configuration :

clk_div = 0x4;
iowrite32(clk_div, base_addr + ADC_CLKDIV);

cntl = ioread32(base_addr + CTRL);
cntl = cntl | (1 << 1);                       //TSC ADC tags
cntl = cntl | (1 << 2);                       //disable write protect
iowrite32(cntl,base_addr + CTRL);

stpcnfg = stpcnfg |(0x8 << 15);               // SEL_INM pin
stpcnfg = stpcnfg |(0x6 << 19);               // SEL_INP pins SW configuration
stpcnfg = stpcnfg |(0x4 << 2);                // average 16 samples
iowrite32(stpcnfg,base_addr + STEPCONFIG1);   //stepconfig 1

cntl = cntl | 1;                          // enable TSC_ADC_SS
iowrite32(cntl,base_addr + CTRL);

iowrite32(0x2, base_addr + STEPENABLE); //step enable

printk("FIF_DATA = %d\n",((ioread32(base_addr + 0x100)& 0xFFF)));

Log File :

root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   61.536156] FIF_DATA = 3390
val =0 t=:3.459583 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   63.836797] FIF_DATA = 1161
val =0 t=:3.458542 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   65.466063] FIF_DATA = 337
val =0 t=:3.372791 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   66.535943] FIF_DATA = 3522
val =0 t=:3.449333 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   67.805611] FIF_DATA = 1009
val =0 t=:3.499917 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   69.105865] FIF_DATA = 3890
val =0 t=:3.445125 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   70.975969] FIF_DATA = 3911
val =0 t=:3.461083 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   72.246909] FIF_DATA = 404
val =0 t=:3.389166 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   73.865814] FIF_DATA = 3930
val =0 t=:3.458708 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   75.016007] FIF_DATA = 675
val =0 t=:3.363375 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   76.426743] FIF_DATA = 3773
val =0 t=:3.572292 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   77.895956] FIF_DATA = 64
val =0 t=:3.273667 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   79.055918] FIF_DATA = 736
val =0 t=:3.359708 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   80.205874] FIF_DATA = 1591
val =0 t=:3.455333 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   81.185897] FIF_DATA = 2934
val =0 t=:3.449542 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   82.605838] FIF_DATA = 2273
val =0 t=:3.452458 ms
root@am335x-evm:/lib/modules/3.12.10-ti2013.12.01# ./adc_test
[   83.985919] FIF_DATA = 3764

Thanks & Regards,

Naven

Hi,

I checked the register values, and my initial comments are:

- Read at address 0x44E0D024 (0xb6ff7024): 0x00000112:  Means that you have End_of_Sequence, FIFO0_Underflow & Out_of_Range interrupt events pending. See description of the raw status register (IRQSTATUS_RAW).

- On the other hand  

 Read at address 0x44E0D028 (0xb6f4f028): 0x00000000  (IRQSTATUS register)

 Read at address 0x44E0D02C (0xb6f2502c): 0x00000000  (IRQENABLE_SET register)

Show that neither of these interrupt events (indicated in IRQSTATUS_RAW)  are enabled in your setup. Try using IRQENABLE_SET to enable the corresponding interrupt events & see Section 12.3.5 Interrupts in AM335x TRM for description on how to process them.

- Read at address 0x44E0D040 (0xb6fe9040): 0x00000007

  Try writing 0x00000027 in CTRL register.  This should utilize the AFE (in 4 wire mode).  Note that when setting bits [6:5]AFE_Pen_Ctrl User also needs to make sure the ground path is connected properly for pen interrupt to occur (using the StepConfig registers).

- Read at address 0x44E0D044 (0xb6fb1044): 0x00000010: indicates that ADCSTAT[4:0]STEP_ID = 0x10 =>  Idle. Again check Section 12.3.5 Interrupts in TRM.  Reading Idle means that you need to restart the ADC.

- Read at address 0x44E0D04C (0xb6feb04c): 0x00000004 => Try using lower clock, i.e. ADC_CLKDIV[15:0] ADC_ClkDiv is set to 0x7 in TI SDK8.0

- Read at address 0x44E0D064 (0xb6f73064): 0x002C0010: means that you've set your adc in HW synchronized, one-shot mode.  Try using continuous mode (SW or HW), see Section 12.3.4 One-Shot (Single) or Continuous Mode in AM335x TRM.  

- Read at address 0x44E0D0E8 (0xb6fdb0e8): 0x00000000: Program some FIFO Threshold. 0x0 means that your adc module will immediately start sending interrupts. Again see  Section 12.3.5 Interrupts for details.

Hope this helps.

Best Regards,

Yordan