"Semaphore.c", line 234: remark #2142-D: comparison between signed and unsigned operands

Eric Wilbur

Other Parts Discussed in Thread: OMAPL138, SYSBIOS

I am upgrading the TI-RTOS workshop labs/solutions files from CCSv6.10 to CCSv6.2.0 and the associated XDC and compiler version upgrades since last July. I am currently working on the C6000 files. When I re-build the proven solutions from CCSv6.1.0 and the XDC/compiler versions available in July to the latest tools, everything builds fine, but I get two REMARKS like the above, both flagging if statements in semaphore.c and timer.c (not my code, but BIOS's code).

In the same project as of Jul 2016 using the latest tools available then, the build was clean with no Remarks. Did something change? Is there an easy way to build without these remarks? What do I need to change?

FYI - if I create a new project with the latest tools, copy over my source files and build, these Remarks do NOT show up.

Thanks,

Eric

over 9 years ago

0 Sasha Slijepcevic over 9 years ago

TI__Mastermind 37985 points

Eric,
can you show the command line for those different cases? I would like to see compiler versions and all the options.

0 Eric Wilbur over 9 years ago in reply to Sasha Slijepcevic

Intellectual 770 points

Thanks Sasha.

Here is the command line for the previous example using CCSv6.1.0:

-mv6740 --abi=eabi --include_path="C:/TI/ccsv6/tools/compiler/ti-cgt-c6000_8.1.1/include" --include_path="C:/TI/pdk_OMAPL138_1_01_00_02/packages" -g --define=c6748 --diag_warning=225 --diag_wrap=off --display_error_number

Here is the command line for the same project using CCSv6.2.0:

-mv6740 --include_path="C:/TI/ccsv6/tools/compiler/ti-cgt-c6000_8.1.2/include" --include_path="C:/TI/pdk_OMAPL138_1_01_00_02/packages" -g --define=c6748 --diag_warning=225 --diag_wrap=off --display_error_number

Looks like the only diff is --abi=eabi, but both are set to use elf in the properties. One other difference is that the previous project, once built, has add'l repositories listed that were not there before:

In the newer project, only the ccs_base repository is referenced. Not sure why these others show up because they should all be selected by choosing the TI-RTOS for C6000 path.

Thanks for looking into this.

0 Sasha Slijepcevic over 9 years ago in reply to Eric Wilbur

TI__Mastermind 37985 points

How about the third case when you create a new project from scratch and copy the sources? What is the command line in that case?
Also, I don't see any TI-RTOS related options in the command line, but it seems you are compiling Semaphore.c from ti.sysbios.knl package, so there has to be more options in that command line.

Either way, the comparison as exists in these files in unsafe so please let me know the line for Timer.c and full path to that file so we can fix it.

I don't think "--abi=eabi" flag matters because for 8.1 tools, "--abi=eabi" is the default and shouldn't make any difference, but we can look into it more if we can't find any other cause.

0 Sasha Slijepcevic over 9 years ago in reply to Sasha Slijepcevic

TI__Mastermind 37985 points

Eric,
I asked around and it seems the issue was fixed in SYS/BIOS 6.46.02. If you switch to a newer SYS/BIOS or TI-RTOS including a newer SYS/BIOS, you shouldn't see these warnings anymore.

0 Eric Wilbur over 9 years ago in reply to Sasha Slijepcevic

Intellectual 770 points

Sorry Sasha, I copied that command line from the Compiler tab under Properties. You probably want the actual build output.

Update - now the projects are building the same way - two remarks - both flagging BIOS files (semaphore.c and timer.c).

Case #1 (no remarks) was CCSv6.1.0 with project X. Case #2 (remarks) was project X built with CCSv6.2.0 and latest tools. Case #3 is creating a new project in the latest tools and copying over my source files. I am attempting to avoid creating 125 new projects. There are 25 lab and solution files per architecture times 5 architectures. It is great when I can just take a project, update to new tools and then re-build and go. But I often find 3-4 problems every three months like this that causes me to have to re-create all the projects over again. It isn't hard. Just a pain.

Lots of text coming next - three output build windows. Again, thanks for looking into this...

I don't have CCSv6.1.0 installed anything, so I can't show you Case #1. Unless I re-install it which I can. After creating three new projects for Case #3, now I continue to NOT get a clean build - same two remarks. So, at least it is consistent.

NOW, the question is "why is the compiler flagging semaphore.c and timer.c" - code that I didn't write, but coming from the bios library source code??

Ok, so here are the dumps of every build:

CASE #2 - Old project, new tools (where the remarks on semaphore.c and timer.c are shown):

**** Build of configuration Debug for project blink_C6000_HWI_SOL ****

"C:\\TI\\ccsv6\\utils\\bin\\gmake" -k all

making ../src/sysbios/sysbios.ae674 ...

gmake[1]: Entering directory 'C:/Users/Eric Wilbur/workspace_v6_2/blink_C6000_HWI_SOL/src/sysbios'

cle674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/BIOS.c ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/Hwi_disp_always.s64P ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/Hwi_asm.s62 ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/Hwi_asm_switch.s62 ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/Clobber_asm.s62 ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/Exception_asm.s64P ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c64p/MemoryProtect_asm.s64P ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/family/c62/TaskSupport_asm.s62 ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/timers/timer64/Timer_asm.s64P ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/timers/gptimer/Timer_asm.s64P ...

asme674 C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages/ti/sysbios/timers/dmtimer/Timer_asm.s64P ...

are674 BIOS.obj c64p_Hwi_disp_always.obj c64p_Hwi_asm.obj c64p_Hwi_asm_switch.obj c64p_Clobber_asm.obj c64p_Exception_asm.obj c64p_MemoryProtect_asm.obj c62_TaskSupport_asm.obj timer64_Timer_asm.obj gptimer_Timer_asm.obj dmtimer_Timer_asm.obj ...

gmake[1]: Leaving directory 'C:/Users/Eric Wilbur/workspace_v6_2/blink_C6000_HWI_SOL/src/sysbios'

'Building file: ../app.cfg'

'Invoking: XDCtools'

"C:/TI/xdctools_3_32_01_22_core/xs" --xdcpath="C:/TI/tirtos_c6000_2_00_01_23/packages;C:/TI/tirtos_c6000_2_00_01_23/products/bios_6_40_01_15/packages;C:/TI/tirtos_c6000_2_00_01_23/products/ipc_3_10_01_11/packages;C:/TI/tirtos_c6000_2_00_01_23/products/ndk_2_23_01_01/packages;C:/TI/tirtos_c6000_2_00_01_23/products/uia_2_00_00_28/packages;C:/TI/ccsv6/ccs_base;" xdc.tools.configuro -o configPkg -t ti.targets.elf.C674 -p ti.platforms.evm6748 -r release -c "C:/TI/ccsv6/tools/compiler/ti-cgt-c6000_8.1.2" --compileOptions "-g --optimize_with_debug" "../app.cfg"

making package.mak (because of package.bld) ...

generating interfaces for package configPkg (because package/package.xdc.inc is older than package.xdc) ...

configuring app.xe674 from package/cfg/app_pe674.cfg ...

generating custom ti.sysbios library makefile ...

Starting build of library sources ...

making C:/Users/ERICWI~1/workspace_v6_2/blink_C6000_HWI_SOL/src/sysbios/sysbios.ae674 ...

gmake[1]: Entering directory `C:/Users/ERICWI~1/workspace_v6_2/blink_C6000_HWI_SOL/src/sysbios'