Linux/AM5718: U-Boot does not see more than one I2C

Hi Kemal

Thanks for the patch, your patch switch on the clocks for the i2c but it wont mae the MLO to discover the i2c.

I am not sure how the MLO sets ups it internal device tree (where it only adds the i2c1, I need to add i2c4 as well)

The problem manifests it like this

We changed the function call from 

 ret = i2c_get_chip_for_busnum(0, chip_no, 1, &dev);

to

 ret = i2c_get_chip_for_busnum(3, chip_no, 1, &dev);

in the function "int palmas_i2c_read_u8(u8 chip_no, u8 reg, u8 *valp)" in file palmas.c

This will make palmas to look for i2c bus 3 (i2c4) but if you follow the code deeper down

-> i2c_get_chip_for_busnum in i2c-uclass.c

-> uclass_get_device_by_seq in uclass.c

-> uclass_find_device_by_seq in uclass.c

This function will iterate over all aviable i2c's via the macro "uclass_foreach_dev"

This maco will only find one i2c, that is i2c1 (dev->name'i2c@48070000)

I guess the MLO adds i2c1 somewhere, so I guess i2c4 should be added at the same place as well.

Regards Stefan

Hello Stefan,

Thank you for providing the solution, but unfortunately I cannot find the palmas_i2c_read_u8 within drivers/power/palmas.c and also cannot find &i2c1 defined within the arch/arm/dts/omap5-u-boot.dtsi. Which Processor SDK version you are using? If you are fine with that, can you attach the changes you made as a patch?

cd <Processor SDK>/board-support/u-boot-<version>/
git diff > 0001-AM57xx-PMIC-on-i2c4.patch

Best regards,
Kemal

Hi

I have some difficult to give you a patch at the moment, all our other Changes will be included, or is it possible to create patches on specific files ?

$ pwd
/home/bomill/project/u-boot

$ find . | grep "palmas\.c"
./drivers/power/palmas.c
./drivers/power/pmic/palmas.c

It is the first file

$ pwd
/home/bomill/project/u-boot

$ find . | grep "omap5-u-boot\.dtsi"
./arch/arm/dts/omap5-u-boot.dtsi

Compiler

export CROSS_COMPILE=arm-linux-gnueabihf-
export ARCH=arm

u-boot

downloaded from (www.denx.de/.../ ) 3 weeks ago

Here it is

I hope I got everything in it, I did not include the .dtsi file change because it is so custom specific

Regards

PS

I had to add the patch as text, the texas "insert file" tool refuxes to add a file attachement with the file ending .patch

diff --git a/arch/arm/dts/omap5-u-boot.dtsi b/arch/arm/dts/omap5-u-boot.dtsi
index 1b1d765fae..035199b684 100644
--- a/arch/arm/dts/omap5-u-boot.dtsi
+++ b/arch/arm/dts/omap5-u-boot.dtsi
@@ -104,3 +104,15 @@
 &i2c1 {
 	u-boot,dm-spl;
 };
+
+&i2c2 {
+	u-boot,dm-spl;
+};
+
+&i2c3 {
+	u-boot,dm-spl;
+};
+
+&i2c4 {
+	u-boot,dm-spl;
+};
diff --git a/arch/arm/mach-omap2/omap5/hw_data.c b/arch/arm/mach-omap2/omap5/hw_data.c
index c4a41db92a..25d122a13f 100644
--- a/arch/arm/mach-omap2/omap5/hw_data.c
+++ b/arch/arm/mach-omap2/omap5/hw_data.c
@@ -416,10 +416,14 @@ void enable_basic_clocks(void)
 		(*prcm)->cm_wkup_gptimer1_clkctrl,
 		(*prcm)->cm_l3init_hsmmc1_clkctrl,
 		(*prcm)->cm_l3init_hsmmc2_clkctrl,
 		(*prcm)->cm_l4per_gptimer2_clkctrl,
 		(*prcm)->cm_wkup_wdtimer2_clkctrl,
 		(*prcm)->cm_l4per_uart3_clkctrl,
 		(*prcm)->cm_l4per_i2c1_clkctrl,
+		(*prcm)->cm_l4per_i2c2_clkctrl,
+		(*prcm)->cm_l4per_i2c3_clkctrl,
+		(*prcm)->cm_l4per_i2c4_clkctrl,
 #ifdef CONFIG_DRIVER_TI_CPSW
 		(*prcm)->cm_gmac_gmac_clkctrl,
 #endif
diff --git a/drivers/power/palmas.c b/drivers/power/palmas.c
index 2584bea38d..98737e082f 100644
--- a/drivers/power/palmas.c
+++ b/drivers/power/palmas.c
@@ -182,14 +182,14 @@ int palmas_i2c_write_u8(u8 chip_no, u8 reg, u8 val)
 	struct udevice *dev;
 	int ret;
 
-	ret = i2c_get_chip_for_busnum(0, chip_no, 1, &dev);
+	ret = i2c_get_chip_for_busnum(3, chip_no, 1, &dev);
 	if (ret) {
-		pr_err("unable to get I2C bus. ret %d\n", ret);
+		pr_err("%s: unable to get I2C bus. ret %d\n", __func__, ret);
 		return ret;
 	}
 	ret = dm_i2c_reg_write(dev, reg, val);
 	if (ret) {
-		pr_err("writing to palmas failed. ret %d\n", ret);
+		pr_err("%s: writing to palmas failed. ret %d\n", __func__, ret);
 		return ret;
 	}
 	return 0;
@@ -200,14 +200,14 @@ int palmas_i2c_read_u8(u8 chip_no, u8 reg, u8 *valp)
 	struct udevice *dev;
 	int ret;
 
-	ret = i2c_get_chip_for_busnum(0, chip_no, 1, &dev);
+	ret = i2c_get_chip_for_busnum(3, chip_no, 1, &dev);
 	if (ret) {
-		pr_err("unable to get I2C bus. ret %d\n", ret);
+		pr_err("%s: unable to get I2C bus. ret %d\n", __func__, ret);
 		return ret;
 	}
 	ret = dm_i2c_reg_read(dev, reg);
 	if (ret < 0) {
-		pr_err("reading from palmas failed. ret %d\n", ret);
+		pr_err("%s: reading from palmas failed. ret %d\n", __func__, ret);
 		return ret;
 	}
 	*valp = (u8)ret;