Linux/DRA77P: Changes required for mmc3 in kernel version 4.14

Hi Padmesh,

The MMC controller driver switched from omap_hsmmc (Kernel 4.4) to sdhci-omap (Kernel 4.14) driver.
What changes did you do to dts files in Kernel 4.4? 

Regards,
Vishal

Hi Vishal,

I have implemented a dummy vmmc_aux-supply regulator (wlan_regulator) as supply and added pinmux details and other setup in mmc3 node,

wlan_regulator: fixedregulator-wlan_regulator {
		compatible = "regulator-fixed";
		regulator-name = "wlan_regulator";
		regulator-min-microvolt = <1800000>;
		regulator-max-microvolt = <1800000>;
		regulator-always-on;
		regulator-boot-on;
		/*gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
		enable-active-high;*/

	};

&dra7_pmx_core {	
		
	mmc3_pins_default: mmc3_pins_default {
		pinctrl-single,pins = <
			DRA7XX_CORE_IOPAD(0x377c, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
			DRA7XX_CORE_IOPAD(0x3780, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
			DRA7XX_CORE_IOPAD(0x3784, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
			DRA7XX_CORE_IOPAD(0x3788, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
			DRA7XX_CORE_IOPAD(0x378c, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
			DRA7XX_CORE_IOPAD(0x3790, (PIN_INPUT_PULLUP | MODE_SELECT | MUX_MODE0))
		>;
	};
	
};
 

&mmc3{	
	status = "okay";
	vmmc-supply = <&vio_3v3>;
	vmmc_aux-supply = <&wlan_regulator>; 
	bus-width = <4>;
	ti,non-removable;
	max-frequency = <50000000>;
	/*cap-sdio-irq;*/
	cap-power-off-card;
	keep-power-in-suspend;
	/*enable-sdio-wakeup;*/
	pinctrl-names = "default";
	pinctrl-0 = <&mmc3_pins_default &mmc3_iodelay_manual1_conf>;

};

With this configuration for mmc3 node I get the log as,

[  545.000344] mlan: module license 'Marvell Proprietary' taints kernel.
[  545.000353] Disabling lock debugging due to kernel taint
[  548.655718] wlan: Loading MWLAN driver
[  548.758316] vendor=0x02DF device=0x9135 class=0 function=1
[  548.758746] SDIO: max_segs=128 max_seg_size=524288
[  548.758751] rx_work=1 cpu_num=2
[  548.760629] wlan: Enable TX SG mode
[  548.760634] wlan: Enable RX SG mode
[  548.786045] Request firmware: mrvl/sduart8887_combo_a2.bin
[  549.927780] Wlan: FW download over, firmwarelen=615340 downloaded 615340
[  550.430070] WLAN FW is active
[  555.445035] Driver version = SD8887-0.0.0.p0-C4X15C620-GPL-(FP44) 
[  555.445042] main_state = 1
[  555.445047] ioctl_pending = 0
[  555.445051] tx_pending = 0
[  555.445056] rx_pending = 0
[  555.445061] lock_count = 28
[  555.445066] malloc_count = 35
[  555.445070] mbufalloc_count = 0
[  555.445074] hs_skip_count = 0
[  555.445079] hs_force_count = 0
[  555.445198] woal_request_fw failed
[  555.445203] Firmware Init Failed

After which there would no response in the console.

From ssh of console I find,

root@dra7xx-evm:~# cat /sys/kernel/debug/mmc2/ios 
clock:		48000000 Hz
vdd:		21 (3.3 ~ 3.4 V)
bus mode:	2 (push-pull)
chip select:	0 (don't care)
power mode:	2 (on)
bus width:	2 (4 bits)
timing spec:	0 (legacy)
signal voltage:	0 (3.30 V)
driver type:	0 (driver type B)
root@dra7xx-evm:~# 

I have attached the entire boot log.5556.bootlog.txt

Regards,

Padmesh

Hi Padmesh,

Would you know what these lines mean, was this seen with Kernel 4.4 also?
These are not from MMC driver.

[ 555.445198] woal_request_fw failed
[ 555.445203] Firmware Init Failed


Regards,
Vishal

Hi Vishal,

This issue hasn't occurred in kernel version 4.4

Could you check with WLAN module vendor for Kernel 4.14 support of this module?

Hi Vishal,

Does the attached log mean anythingwifilog.txt

Can usage of sdhci driver (in kernel ver 4.14) affect the working of the wlan card. Previous version 4.4 with hsmmc workerd fine.

No difference can be inferred from the logs, as to why the firmware is not initialized.

Regards,

Padmesh

Hi Padmesh,

Did you have a look a the device tree documentation and check to see what dt fields have been updated for 4.14? Can you check?

regards,

Praveen

Hi Padmesh,

SDHCI driver should be functional for SDIO cards also.

The log you attached does not show any errors from SDHCI driver. The log talks about particular command timeout, could you check with the WLAN vendor about these logs? that would help in understanding what operations were complete and what operation timed out.


Regards,
Vishal

Hi Vishal,

When inserting and removing the cfg80211 module i used to find some logs in prev kernel version. Here no such messages occur.

Can that be the issue here ?

The firmware we have is the updated version.

Regards,
Padmesh