D3-3P-TDA3X-SK: DHCP Discover MAC source address is zero

Simon Sigurdhsson

Hi,

We have a setup on the TDA3XX-RVP board using NDK 4.16.01.01 with dual MAC enabled, running only on the second MAC (i.e. using PORT_MASK_MAC_2 in the GMACSW configuration) and enabling the DHCP client on the corresponding interface (interface 2). This seems to cause the NDK to emit DHCP Discover messages where the source ethernet MAC address is all-zero, which is a problem.

After some investigation we have concluded that the issue is probably the following piece of code in NIMU_NDK_start (nimu_ndk.c), which incorrectly copies the MAC address from MAC port 0 to all NETIF devices (even those that use MAC port 1):

mmCopy(&pNETIFDevice->mac_address[0], &hNDK2NSP->bMacAddr[0], (uint)6U);

Here, pNETIFDevice->mac_address is an uint8_t[6] while hNDK2NSP->bMacAddr is an uint8_t[2][6]. We believe the correct code would instead be the following:

mmCopy(&pNETIFDevice->mac_address[0], &hNDK2NSP->bMacAddr[devIdx][0], (uint)6U);

This would correctly copy the MAC address from MAC port 1 to the NETIF device corresponding to interface 2.

We have a workaround, which consists of using PORT_MASK_MAC_BOTH in the GMACSW configuration and copying the same (correct) MAC address to both macInitCfg entries in this configuration. Are there any immediate drawbacks of using such a workaround? We would prefer not having to patch the NDK ourselves.

Regards,
Simon

over 6 years ago

0 Anand Mahadevan SS over 6 years ago

TI__Expert 8165 points

Hi Simon,

Yes, this is a known bug. There is a fix and further improvements to support multiple macs which is planned on the next release of NSP. Rather than the work around, it is better to change the code as you have suggested. It is the correct fix. You won't have to patch/re-build the "NDK". The change you mentioned will be part of NSP, the driver. You can just rebuild the NSP driver after the change, which should be simple enough.

But if you don't want to do that, and stick with the workaround, I don't see any drawbacks as long as you are not using the first port(Which in your case, you are not).

0 Simon Sigurdhsson over 6 years ago in reply to Anand Mahadevan SS

Prodigy 240 points

Hi,

Thanks for the quick reponse! May I ask when the next release of NDK/NSP is planned?

Regards,
Simon

0 Anand Mahadevan SS over 6 years ago in reply to Simon Sigurdhsson

TI__Expert 8165 points

Hi Simon,

Currently I am not sure of the release date. It is usually aligned with a subsequent vision sdk release. Will let you know if there are any updates.

Processors

Processors forum

D3-3P-TDA3X-SK: DHCP Discover MAC source address is zero