TDA2E: TDA2E： Loss of image brightnes，in OPENGL api from YUV to RGB.

user6175115

Part Number: TDA2E

Hi,

in Vision SDK version : 2.8,

The input format is YUV420, the pixels are full range (0~255), we need to use GPU OpenGL API System_eglSetupYuvTexSurface, the expected output is RGB format pixels with full range (0~255).

that means : range was cutted when yuv witch to rgb.

we check it by this way:

After the function wraps YUV image into an external texture in the GL_TEXTURE_EXTERNAL_OES format,
The color sampled by the texture sampler is abnormal.

Channels with input values greater than 235 are sampled to 255 after sampling, and values less than 15 are clipped to 0.

function shows below:

static GLuint System_eglSetupYuvTexSurface(System_EglObj *pObj, System_EglTexProperty *pProp, void *bufAddr, int texIndex)
{
    EGLint attr[32];
    int attrIdx;
    PFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;
    PFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;

attrIdx = 0;

attr[attrIdx++] = EGL_GL_VIDEO_FOURCC_TI;
attr[attrIdx++] = FOURCC_STR("NV12");

attr[attrIdx++] = EGL_GL_VIDEO_WIDTH_TI;
attr[attrIdx++] = pProp->width;

attr[attrIdx++] = EGL_GL_VIDEO_HEIGHT_TI;
attr[attrIdx++] = pProp->height;

attr[attrIdx++] = EGL_GL_VIDEO_BYTE_STRIDE_TI;
attr[attrIdx++] = pProp->pitch[0];

    attr[attrIdx++] = EGL_GL_VIDEO_BYTE_SIZE_TI;
    if(pProp->dataFormat==SYSTEM_DF_YUV420SP_UV)
    {
        attr[attrIdx++] = (pProp->pitch[0] * pProp->height * 3)/2;
    }
    else
    {
        INFO(" EGL: ERROR: Unsupported data format (%d) !!!\n", pProp->dataFormat);
        assert(0);
    }

attr[attrIdx++] = EGL_GL_VIDEO_YUV_FLAGS_TI;
attr[attrIdx++] = EGLIMAGE_FLAGS_YUV_CONFORMANT_RANGE | EGLIMAGE_FLAGS_YUV_BT601;

attr[attrIdx++] = EGL_NONE;

    eglCreateImageKHR =
        (PFNEGLCREATEIMAGEKHRPROC)eglGetProcAddress("eglCreateImageKHR");
    glEGLImageTargetTexture2DOES =
        (PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)eglGetProcAddress("glEGLImageTargetTexture2DOES");

    pObj->texImg[texIndex] = eglCreateImageKHR(
                                pObj->display,
                                EGL_NO_CONTEXT,
                                EGL_RAW_VIDEO_TI,
                                bufAddr,
                                attr
                              );

   System_eglCheckEglError("eglCreateImageKHR", EGL_TRUE);
   if (pObj->texImg[texIndex] == EGL_NO_IMAGE_KHR) {
       INFO(" EGL: ERROR: eglCreateImageKHR failed !!!\n");
       return -1;
   }

glGenTextures(1, &pObj->texYuv[texIndex]);
System_eglCheckGlError("eglCreateImageKHR");

glBindTexture(GL_TEXTURE_EXTERNAL_OES, pObj->texYuv[texIndex]);
System_eglCheckGlError("glBindTexture");

   glTexParameteri(GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
   glTexParameteri(GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
   System_eglCheckGlError("glTexParameteri");

glEGLImageTargetTexture2DOES(GL_TEXTURE_EXTERNAL_OES, (GLeglImageOES)pObj->texImg[texIndex]);
System_eglCheckGlError("glEGLImageTargetTexture2DOES");

pObj->bufAddr[texIndex] = bufAddr;

return 0;
}

we will have a test changing EGLIMAGE_FLAGS_YUV_CONFORMANT_RANGE to EGLIMAGE_FLAGS_YUV_FULL_RANGE, it is on going..

can it solve this probelm? have some other code need to be edit??

Thanks

over 5 years ago

0 user6175115 over 5 years ago

Intellectual 350 points

bad news：

we use EGLIMAGE_FLAGS_YUV_FULL_RANGE , but it dose not work.

now probelm become easy:

opengl get a 255 fullrange image. how cam we make it put a fullrange image too.

0 Gowtham Tammana over 5 years ago in reply to user6175115

TI__Expert 3430 points

Hi user6175115,

Is the issue that you are not seeing the YUV_FULL_RANGE color conversion when doing through YUV->RGB through eglimage texture?

Is the release here VISION SDK 2.8?

Thanks,

Gowtham

0 Ramprasad over 5 years ago in reply to Gowtham Tammana

TI__Mastermind 30480 points

Hi Fan,

Can you check the commit-ID of the omap5-sgx-ddk-um-linux used in your system?

I guess , this is 5603bbaba7b8a88173f3652c8e949c0458601e6b(from meta-glsdk/recipes-graphics/libgles/omap5-sgx-ddk-um-linux_1.9.0.12.bbappend).

Sgx-um binaries have been updated with the YUV full range support in in DDK1.9 but note that Full range is the default one and you can not configure for CONFORMANT range.

Please refer this commit

https://git.ti.com/cgit/graphics/omap5-sgx-ddk-um-linux/commit/?h=dra7/k3.14&id=7ac19e76160b132bc3d2c3024d9711e594013e2a

Please upgrade the sgx-um to the latest commit.

Thanks

RamPrasad

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

we replace the libs as the commit show, but it also dosen't work.
we keep the func System_eglSetupYuvTexSurface. Does it really need not to be changed?

0 Ramprasad over 5 years ago in reply to user6175115

TI__Mastermind 30480 points

Hi Fan,

Is this issue still exist? We are currently on visionSDK3.08 and I don't have a setup for visionSDK2.8(kernel 3.14).

I need some time to setup this and text your usecase.

The fix I suggested seems to be available only for wayland display type and visionSDK2.8 doesn't seem to support weston.

Thanks

Ramprasad

Processors

Processors forum

TDA2E: TDA2E： Loss of image brightnes，in OPENGL api from YUV to RGB.