CCS/TDA2EX17EVM: in Vision SDK version 3.6 , OPENGL api from YUV to RGB , image brightnes ( 0-15 235-255) lost

user6175115

Part Number: TDA2EX17EVM

Tool/software: Code Composer Studio

we use vsdk2.8 and replace sgx libs as you supported, but it dosen't work, so we want to resolve it in vsdk3.6

the probelm is that:

The input format is YUV420, the pixels are full range (0~255), we need to use GPU OpenGL API System_eglSetupYuvTexSurface, the expected output is RGB format pixels with full range (0~255).

that means : range was cutted when yuv witch to rgb.

the function is:

#ifdef QNX_BUILD
static GLuint System_eglSetupYuvTexSurface(System_EglObj *pObj, System_EglTexProperty *pProp, void *bufAddr, int texIndex)
#else
static GLuint System_eglSetupYuvTexSurface(System_EglObj *pObj, System_EglTexProperty *pProp, int dmaBufFd, int texIndex)
#endif
{
#ifdef QNX_BUILD                                                                                                                                                                                              
    EGLCompatBuffer eglCBuf;
#else
    EGLint attr[32];
    int attrIdx;
#endif
    PFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;
    PFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;

#ifndef QNX_BUILD
    attrIdx = 0;

    attr[attrIdx++] = EGL_LINUX_DRM_FOURCC_EXT;
    attr[attrIdx++] = FOURCC_STR("NV12");

    attr[attrIdx++] = EGL_WIDTH;
    attr[attrIdx++] = pProp->width;

    attr[attrIdx++] = EGL_HEIGHT;
    attr[attrIdx++] = pProp->height;

    attr[attrIdx++] = EGL_DMA_BUF_PLANE0_PITCH_EXT;
    attr[attrIdx++] = pProp->pitch[0];

    attr[attrIdx++] = EGL_DMA_BUF_PLANE1_PITCH_EXT;
    attr[attrIdx++] = pProp->pitch[0];

    attr[attrIdx++] = EGL_DMA_BUF_PLANE0_OFFSET_EXT;
    attr[attrIdx++] = 0;

    attr[attrIdx++] = EGL_DMA_BUF_PLANE1_OFFSET_EXT;
    attr[attrIdx++] = 0;

    attr[attrIdx++] = EGL_DMA_BUF_PLANE0_FD_EXT;
    attr[attrIdx++] = dmaBufFd;

    attr[attrIdx++] = EGL_DMA_BUF_PLANE1_FD_EXT;
    attr[attrIdx++] = dmaBufFd;

    attr[attrIdx++] = EGL_NONE;
#endif

    eglCreateImageKHR =
        (PFNEGLCREATEIMAGEKHRPROC)eglGetProcAddress("eglCreateImageKHR");
    glEGLImageTargetTexture2DOES =
        (PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)eglGetProcAddress("glEGLImageTargetTexture2DOES");

#ifdef QNX_BUILD                                                                                                                                                                                              
    eglCBuf = pObj->eglInfo.get_egl_attach_buffer(pProp->width, pProp->height, SYSTEM_DF_YUV420SP_UV, bufAddr);
    pObj->eglPixmap[texIndex] = eglCBuf.eglPixmap;

    pObj->texImg[texIndex] = eglCreateImageKHR(
                            pObj->display,
                            EGL_NO_CONTEXT,
                            EGL_NATIVE_PIXMAP_KHR,
                            (EGLNativePixmapType)(pObj->eglPixmap[texIndex]),
                            NULL
                          );
#else
    pObj->texImg[texIndex] = eglCreateImageKHR(
                                pObj->display,
                                EGL_NO_CONTEXT,
                                EGL_LINUX_DMA_BUF_EXT,
                                NULL,
                                attr
                              );
#endif

    System_eglCheckEglError("eglCreateImageKHR", EGL_TRUE);
    if (pObj->texImg[texIndex] == EGL_NO_IMAGE_KHR) {
        Vps_printf(" EGL: ERROR: eglCreateImageKHR failed !!!\n");
        return -1;
    }

    glGenTextures(1, &pObj->texYuv[texIndex]);
    System_eglCheckGlError("eglCreateImageKHR");

    glBindTexture(GL_TEXTURE_EXTERNAL_OES, pObj->texYuv[texIndex]);
    System_eglCheckGlError("glBindTexture");

    glTexParameteri(GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
    glTexParameteri(GL_TEXTURE_EXTERNAL_OES, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
    System_eglCheckGlError("glTexParameteri");

    glEGLImageTargetTexture2DOES(GL_TEXTURE_EXTERNAL_OES, (GLeglImageOES)pObj->texImg[texIndex]);
    System_eglCheckGlError("glEGLImageTargetTexture2DOES");

#ifdef QNX_BUILD
    pObj->bufAddr[texIndex] = bufAddr;
#else
    pObj->dmaBufFd[texIndex] = dmaBufFd;
#endif
    return 0;
}

yuv420 picture show below, it dump from memory:

yuv420.rar

over 5 years ago

0 user6175115 over 5 years ago

Intellectual 350 points

like yuv420.rar we know it is video range and full range probelm, but how can we adjust it ???

0 Ramprasad over 5 years ago in reply to user6175115

TI__Mastermind 30480 points

Hi fan,

In visionsdk3.06, commitID of sgx-um to be used is 32ad0237d69eb190d5b702a0bb4fac060e4995f2

Please update this to 5471ae49524ea662ecd089d10ba389a466382ab0 and then try.

This has YUV full range support by default for the wlegl.

RamPrasad

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

i have clone it :

commit b86e15a4f2087e2114adc8a812fbc505031e634c
Merge: bce94b5 5471ae4
Author: Anand Balagopalakrishnan <anandb@ti.com>
Date:   Fri Jan 25 05:02:33 2019 -0600

    Merge pull request #14 in GRAPHICS/omap5-sgx-ddk-um-linux from GFXFORK/ramprasad-omap5-sgx-ddk-um-linux:feature/x0038811/wlegl-yuv-fullrange_4.4k_vision_sdk to ti-img-sgx/1.14.3699939_k4.4_vision_sdk
    
    * commit '5471ae49524ea662ecd089d10ba389a466382ab0':
      um: wlegl: add apphint to configure yuv CSC range

commit 5471ae49524ea662ecd089d10ba389a466382ab0
Author: Ramprasad N <x0038811@ti.com>
Date:   Fri Jan 25 10:19:05 2019 +0530

    um: wlegl: add apphint to configure yuv CSC range
    
    Signed-off-by: Ramprasad N <x0038811@ti.com>

i instead all of them (lib bin include), but it also dose not work. i do not rebuild, as it is Dynamic Link Library.

are you test it? or what is wrong during I did.

0 Ramprasad over 5 years ago in reply to user6175115

TI__Mastermind 30480 points

Hi Fan,

I guess this solution was added for wayland display only, so you are not seeing the expected results.

Did you try with EGL_SAMPLE_RANGE_HINT_EXT attribute?

Please refer this solution

https://e2e.ti.com/support/proces sors/f/791/p/718983/2678353?tisearch=e2e-sitesearch&keymatch=DRA72#2678353

You need to use attribute EGL_SAMPLE_RANGE_HINT_EXT and value EGL_YUV_FULL_RANGE_EXT for full range, EGL_YUV_NARROW_RANGE_EXT for conformant range.

Thanks

RamPrasad

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

we add attribute EGL_SAMPLE_RANGE_HINT_EXT, EGL_YUV_FULL_RANGE_EXT but it dose not work.

need i replace egl libs and set it at same time??

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

sorry, it dosen't work can you have a look it again? i'm sure i changed it and build it in. dose it have been test?

0 Ramprasad over 5 years ago in reply to user6175115

TI__Mastermind 30480 points

Hi Fan,

I analyzed sgx-um source code and confirming that HINT_RANGE setting should work.

EGL_SAMPLE_RANGE_HINT_EXT attribute for EGL_LINUX_DMA_BUF_EXT is validated for EGL_YUV_FULL_RANGE_EXT and EGL_YUV_NARROW_RANGE_EXT and for any other value, it would return EGL_BAD_ATTRIBUTE.

Can you set different value to to this attrbute (other than EGL_YUV_NARROW_RANGE_EXT and EGL_YUV_FULL_RANGE_EXT ) to confirm this is being respected and it returns error now?

Currently I don't have visionSDK 3DSRV setup to conclude this. I will have to use some application like kmscube to verify this. I will do this.

Thanks

RamPrasad

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

thanks a lot，i will try it.

0 user6175115 over 5 years ago in reply to Ramprasad

Intellectual 350 points

by the way, it maybe needn't 3dsrv case, just dispaly is enough. we fucos on yuv to rgb. i don't know what I said is correct or not.

Processors

Processors forum

CCS/TDA2EX17EVM: in Vision SDK version 3.6 , OPENGL api from YUV to RGB , image brightnes ( 0-15 235-255) lost