AM4372: eMMC - SPL -> u-boot

One thing which does not resolve the problem but which I noticed when checking voltages:

The eMMC in our case is connected to dcdc4 of the TPS65218. However, your tps65218_voltage_update function in pmic_tps65218.c only supports updates on registers dcdc1 to dcdc3. Also, it checks at the beginning if one of these 3 registers is called which does not make much sense as all voltage registers are password protected but then it does not check for these registers for the GO command where it would actually make sense as this only applies up to dcdc3.

May I suggest the following change to that function:

 int tps65218_voltage_update(uchar dc_cntrl_reg, uchar volt_sel)
 {
-       if ((dc_cntrl_reg != TPS65218_DCDC1) &&
-           (dc_cntrl_reg != TPS65218_DCDC2) &&
-           (dc_cntrl_reg != TPS65218_DCDC3))
-               return 1;
-
        /* set voltage level */
        if (tps65218_reg_write(TPS65218_PROT_LEVEL_2, dc_cntrl_reg, volt_sel,
                               TPS65218_DCDC_VSEL_MASK))
                return 1;

-       /* set GO bit to initiate voltage transition */
-       if (tps65218_reg_write(TPS65218_PROT_LEVEL_2, TPS65218_SLEW,
-                              TPS65218_DCDC_GO, TPS65218_DCDC_GO))
-               return 1;
+               if ((dc_cntrl_reg == TPS65218_DCDC1) ||
+               (dc_cntrl_reg == TPS65218_DCDC2) ||
+               (dc_cntrl_reg == TPS65218_DCDC3))
+       {
+               /* set GO bit to initiate voltage transition */
+               if (tps65218_reg_write(TPS65218_PROT_LEVEL_2, TPS65218_SLEW,
+                                       TPS65218_DCDC_GO, TPS65218_DCDC_GO))
+                       return 1;
+       }

        return 0;
 }

Hi Peter,
>>>>
spl: could not find mmc device 1. error: -19
<<<<
The above error (#define ENODEV 19 /* No such device */) is triggered in spl_mmc_find_device() in "/common/spl/spl_mmc.c" when SPL is trying to load u-boot.img. In newer SDK releases, Driver Model (DM) is used for mmc ports in SPL/u-boot. I'm listing u-boot "dm tree" log I captured on AM437x GP EVM (note that only MMC is enabled on AM437x GP EVM dtb file => mmc@48060000). You may need to add "CONFIG_CMD_DM=y" in your u-boot am43xx_xyz_defconfig if not set to enable "dm ..." cmd.

=> dm tree
 Class    index  Probed  Driver                Name
-----------------------------------------------------------
 root        0  [ + ]   root_driver           root_driver
 simple_bus  0  [ + ]   generic_simple_bus    |-- ocp
 simple_bus  1  [   ]   generic_simple_bus    |   |-- l4_wkup@44c00000
 simple_bus  2  [   ]   generic_simple_bus    |   |   `-- scm@210000
 syscon      0  [   ]   syscon                |   |       `-- scm_conf@0
 serial      0  [ + ]   omap_serial           |   |-- serial@44e09000
 serial      1  [   ]   omap_serial           |   |-- serial@481a6000
 timer       0  [ + ]   omap_timer            |   |-- timer@48040000
 gpio        0  [ + ]   gpio_omap             |   |-- gpio@44e07000
 gpio        1  [   ]   gpio_omap             |   |-- gpio@4804c000
 gpio        2  [   ]   gpio_omap             |   |-- gpio@481ae000
 gpio        3  [   ]   gpio_omap             |   |-- gpio@48320000
 gpio        4  [   ]   gpio_omap             |   |-- gpio@48322000
 i2c         0  [ + ]   i2c_omap              |   |-- i2c@44e0b000
 i2c_generi  0  [ + ]   i2c_generic_chip_drv  |   |   `-- generic_24
 i2c         1  [   ]   i2c_omap              |   |-- i2c@4802a000
 mmc         0  [ + ]   omap_hsmmc            |   |-- mmc@48060000
 blk         0  [ + ]   mmc_blk               |   |   `-- mmc@48060000.blk
 eth         0  [ + ]   eth_cpsw              |   |-- ethernet@4a100000
 syscon      1  [   ]   syscon                |   |-- control-phy@44e10620
 syscon      2  [   ]   syscon                |   |-- control-phy@0x44e10628
 simple_bus  3  [   ]   generic_simple_bus    |   |-- ocp2scp@483a8000
 phy         0  [   ]   omap_usb2_phy         |   |   `-- phy@483a8000
 simple_bus  4  [   ]   generic_simple_bus    |   |-- ocp2scp@483e8000
 phy         1  [   ]   omap_usb2_phy         |   |   `-- phy@483e8000
 nop         0  [   ]   dwc3-generic-wrapper  |   |-- omap_dwc3@48380000
 usb         0  [   ]   dwc3-generic-periphe  |   |   `-- usb@48390000
 nop         1  [   ]   dwc3-generic-wrapper  |   `-- omap_dwc3@483c0000
 usb         0  [   ]   dwc3-generic-host     |       `-- usb@483d0000
 clk         0  [ + ]   fixed_rate_clock      `-- oscillator
=>

Hi Hong,

Below my dm tree output:

=> dm tree
 Class    index  Probed  Driver                Name
-----------------------------------------------------------
 root        0  [ + ]   root_driver           root_driver
 simple_bus  0  [ + ]   generic_simple_bus    |-- ocp
 simple_bus  1  [   ]   generic_simple_bus    |   |-- l4_wkup@44c00000
 simple_bus  2  [   ]   generic_simple_bus    |   |   `-- scm@210000
 syscon      0  [   ]   syscon                |   |       `-- scm_conf@0
 serial      0  [ + ]   omap_serial           |   |-- serial@44e09000
 timer       0  [ + ]   omap_timer            |   |-- timer@48040000
 gpio        0  [ + ]   gpio_omap             |   |-- gpio@481ae000
 i2c         0  [ + ]   i2c_omap              |   |-- i2c@44e0b000
 i2c_generi  0  [ + ]   i2c_generic_chip_drv  |   |   `-- generic_24
 mmc         0  [ + ]   omap_hsmmc            |   |-- mmc@48060000
 blk         0  [ + ]   mmc_blk               |   |   `-- mmc@48060000.blk
 mmc         1  [ + ]   omap_hsmmc            |   |-- mmc@481d8000
 blk         1  [   ]   mmc_blk               |   |   `-- mmc@481d8000.blk
 syscon      1  [   ]   syscon                |   |-- control-phy@44e10620
 syscon      2  [   ]   syscon                |   |-- control-phy@0x44e10628
 simple_bus  3  [   ]   generic_simple_bus    |   |-- ocp2scp@483a8000
 simple_bus  4  [   ]   generic_simple_bus    |   |-- ocp2scp@483e8000
 phy         0  [   ]   omap_usb2_phy         |   |   `-- phy@483e8000
 nop         0  [   ]   dwc3-generic-wrapper  |   |-- omap_dwc3@48380000
 usb         0  [   ]   dwc3-generic-periphe  |   |   `-- usb@48390000
 nop         1  [   ]   dwc3-generic-wrapper  |   `-- omap_dwc3@483c0000
 usb         0  [   ]   dwc3-generic-host     |       `-- usb@483d0000
 clk         0  [ + ]   fixed_rate_clock      `-- oscillator

=> mmc dev 1
switch to partitions #0, OK
mmc1(part 0) is current device
=> mmc info
Device: OMAP SD/MMC
Manufacturer ID: fe
OEM: 14e
Name: MMC02
Bus Speed: 48000000
Mode : MMC High Speed (52MHz)
Rd Block Len: 512
MMC version 4.4.1
High Capacity: No
Capacity: 1.8 GiB
Bus Width: 8-bit
Erase Group Size: 512 KiB
HC WP Group Size: 0 Bytes
User Capacity: 1.8 GiB
Boot Capacity: 1 MiB ENH
RPMB Capacity: 128 KiB ENH

From the u-boot command I can perfectly access the eMMC memory. I just have no clue to to convince SPL to do the same.

Regards
Peter

I had no idea that spl used parts of the dts. With u-boot,dm-spl; it is just working great, thank you so much.