AM2434: AM2434: INDUSTRIAL-COMMUNICATIONS-SDK-AM243X v11.x, EthertNet/IP, bug in drv_uart.c

Vit Triska

Part Number: AM2434

Tool/software:

Hello,

I see a bug in function
"void DRV_UART_printf(void* pContext, const char* pFormat, va_list arg);"
present in
"c:\ti\ind_comms_sdk_am243x_11_00_00_13\examples\industrial_comms\ethernetip_adapter_demo\drivers\uart\drv_uart.c"

The temporary buffer
"static char localString[256] = {0};"
cannot be static because many FreeRTOS tasks can log a message and rewrites data in this buffer!

Because it is only a temporary string output buffer, it should be placed just on stack (no static) in each call of this function invocation:
"char localString[256];" // suggestion
as well as in the Profinet example.
But than a stack problem happens in EtherNet/IP precompiled libraries (FreeRTOS task name "packet").

Please correct your libraries and example to not rewrite logged data.

Wrong EtherNet/IP solution versus correct Profinet solution attached.

Regards,
Vit Triska

5 days ago

0 Pourya Eskandari 5 days ago

TI__Intellectual 1710 points

Hello Vit Triska,

Thank you for your feedback. We will correct that variable declaration in the next release.
Please elaborate on what you mean by the statement:

Vit Triska said:
But than a stack problem happens in EtherNet/IP precompiled libraries (FreeRTOS task name "packet").

Please correct your libraries and example to not rewrite logged data.

Since this change is at the application layer, it has nothing to do with precompiled libraries.

Best regards,
Pourya

0 Vit Triska 5 days ago in reply to Pourya Eskandari

Prodigy 30 points

Hello,

„… Since this change is at the application layer, it has nothing to do with precompiled libraries….“

Not the truth. Apply the non-static variable (application layer).

And test it – try to communicate (any EtherNet/IP PLC) and you will see .

Be aware of a stack issue that happens in the EtherNet/IP precompiled libraries (FreeRTOS task name "packet").

The logged issue:
https://e2e.ti.com/support/microcontrollers/arm-based-microcontrollers-group/arm-based-microcontrollers/f/arm-based-microcontrollers-forum/1570506/am2434-industrial-communications-sdk-am243x-v11-x-ethertnet-ip-unsufficient-stack-size

Regards,
Vit

0 Pourya Eskandari 5 days ago in reply to Vit Triska

TI__Intellectual 1710 points

Hi Vit,

Vit Triska said:
Not the truth. Apply the non-static variable (application layer).

And test it – try to communicate (any EtherNet/IP PLC) and you will see .

As previously mentioned, the precompiled library does not have any dependencies on the application layer. I have recently tested the corrected UART driver, and it functions properly, including when communicating with a PLC and exchanging both I/O and Explicit messages. Could you please provide specific details about the issue you're experiencing on your end?

Best regards,
Pourya

0 Vit Triska 5 days ago in reply to Pourya Eskandari

Prodigy 30 points

drivers\uart\drv_uart.c
in function DRV_UART_printf(...)

/*static*/ char localString[256] = {0}; // removed static

---

Then FreeRTOS stack overflow in task "packet" (created by EtherNet/IP communication...)

This is screenshot before overflow, remaining 16 bytes is desperately little...

0 Pourya Eskandari 5 days ago in reply to Vit Triska

TI__Intellectual 1710 points

Ok, then it is because of not having sufficient stack size for the caller of OSAL_printf (which in this case is "packet" task).
This relates to your other question, if the caller task's stack size is big enough, you won't face issue with OSAL_printf.
Which means, the printf has nothing to do with precompiled stack, the root cause of the problem is not having enough stack size from the caller.

Best regards,
Pourya

0 Vit Triska 5 days ago in reply to Pourya Eskandari

Prodigy 30 points

Well, application issue is to remove static from temporary buffer.

And right, the "packet" task needs to have bigger stack - but its creation is hidden in EtherNet/IP precompiled libraries!

So please fix both issues.

+1 Pourya Eskandari 5 days ago in reply to Vit Triska

TI__Intellectual 1710 points

Hi Vit,

as the UART driver issue is clarified, I'll close the issue, we can follow up regarding 'packet' task issue on the other thread.

Regards,
Pourya

Arm-based microcontrollers

Arm-based microcontrollers forum

AM2434: AM2434: INDUSTRIAL-COMMUNICATIONS-SDK-AM243X v11.x, EthertNet/IP, bug in drv_uart.c