MSP430FR2355: MSP430FR2355

ming

Prodigy 250 points

Part Number: MSP430FR2355
Other Parts Discussed in Thread: MSP-TS430PT48, , BQ76940

we are using msp-ts430pt48 with mcu MSP430FR2355.

on the other end, there is bq76940 evm.

two evms use i2c to interconnected by external wire.

on the msp-ts430pt48, it use p4.6 and p4.7 for the i2c ping.

I port a sample program and it block on the first data send from MSP430FR2355.

it keep looping in the following in I2CSendBytes() function line 226

========================================================

HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTR + UCTXSTT;

while(!(HWREG16(baseAddress + OFS_UCBxIFG) & UCTXIFG))

========================================================

I check UCBxIE and it all turn on and all registers value all make sense to me.

Not sure why the flag is always 0

please advise

Thanks

Fullscreen

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
*
 * main.c
 *
 * This module demonstrates operation of CRC with the bq769x0 family
 * AFE devices using a MSP430G2553 
 *
 * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/ 
 * 
 * 
 *  Redistribution and use in source and binary forms, with or without 
 *  modification, are permitted provided that the following conditions 
 *  are met:
 *
 *    Redistributions of source code must retain the above copyright 
 *    notice, this list of conditions and the following disclaimer.
 *
 *    Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the 
 *    documentation and/or other materials provided with the   
 *    distribution.
 *
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

*
 * main.c
 *
 * This module demonstrates operation of CRC with the bq769x0 family
 * AFE devices using a MSP430G2553 
 *
 * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/ 
 * 
 * 
 *  Redistribution and use in source and binary forms, with or without 
 *  modification, are permitted provided that the following conditions 
 *  are met:
 *
 *    Redistributions of source code must retain the above copyright 
 *    notice, this list of conditions and the following disclaimer.
 *
 *    Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the 
 *    documentation and/or other materials provided with the   
 *    distribution.
 *
 *    Neither the name of Texas Instruments Incorporated nor the names of
 *    its contributors may be used to endorse or promote products derived
 *    from this software without specific prior written permission.
 *
 *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
 *  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
 *  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 *  A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
 *  OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
 *  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
 *  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 *  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 *  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
 *  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
 *  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
*/

#include <driverlib.h>
#include <stdbool.h>
#include <bqMaximo_Ctrl_G2553.h>
#include <math.h>
#include <float.h>
#include <stdlib.h>
/*
 * main.c
 */

#define LPI_BYTE_COUNT 20

RegisterGroup Registers;

const unsigned int OVPThreshold = 4300;
const unsigned int UVPThreshold = 2500;
const unsigned char SCDDelay = SCD_DELAY_100us;
const unsigned char SCDThresh = SCD_THRESH_89mV_44mV;
const unsigned char OCDDelay = OCD_DELAY_320ms;
const unsigned char OCDThresh = OCD_THRESH_22mV_11mV;
const unsigned char OVDelay = OV_DELAY_2s;
const unsigned char UVDelay = UV_DELAY_8s;

unsigned int CellVoltage[15];
float Gain = 0;
int iGain = 0;

void ClockInitialise()
{
    /*
	DCOCTL = 0xE0;	//DCO = 7, MOD = 0

	BCSCTL1 &= 0x8F;  //RSEL = 0, DCOR = 0, 20MHz Clock

	BCSCTL2 = 0x0;

	BCSCTL3 = 0;
	*/
    HWREG8(CS_BASE + OFS_CSCTL1) = DCORSEL_3;   // 8MHz clock
    HWREG8(CS_BASE + OFS_CSCTL2) = 0;
    HWREG8(CS_BASE + OFS_CSCTL3) = 0;
}

void TimerAInit(uint16_t baseAddress)
{
    /*
	TA0CTL |= TASSEL1;
	TA0CTL &= ~TASSEL0;

	TA0CTL |= MC1;
	TA0CTL &= ~MC0;

	TA0CTL &= ~TAIE;
    */
}

void I2CInitialise(uint16_t baseAddress)
{
    /*
	P1SEL |= BIT6 + BIT7;                     // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA
	P1SEL2|= BIT6 + BIT7;                     // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA

	ADC10AE0 &= 0x3F;
	CAPD &= 0x3F;

	UCB0CTL1 |= UCSWRST;                      // Enable SW reset, hold USCI logic in reset state
	UCB0CTL0 = UCMODE_3 + UCSYNC;			//set to I2C mode, sync=1
	UCB0BR0 = 20;
	UCB0BR1 = 0;

	UCB0I2CIE = 0;
    IE2 &= ~(UCB0TXIE + UCB0RXIE);	//disable interrupts

    UCB0CTL1 |= UCSSEL_2;
    UCB0CTL1 &= ~UCSWRST;
    */


    uint16_t mask;

    P4SEL0 |= BIT6 + BIT7;                     // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA
    P4SEL1 |= BIT6 + BIT7;                     // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA

    HWREG16(baseAddress + OFS_UCBxCTLW0) = UCSWRST;

    //Configure Automatic STOP condition generation
    HWREG16(baseAddress + OFS_UCBxCTLW1) &= ~UCASTP_3;
    HWREG16(baseAddress + OFS_UCBxCTLW1) |= UCASTP_2;

    HWREG16(baseAddress + OFS_UCBxTBCNT) = LPI_BYTE_COUNT;

    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCMST + UCMODE_3 + UCSYNC;

    HWREG16(baseAddress + OFS_UCBxBRW) = 0x8;

    HWREG16(baseAddress + OFS_UCBxIE) = 0;

    mask = UCRXIE0 | UCTXIE0 | UCSTPIE | UCNACKIE;
    HWREG16(baseAddress + OFS_UCBxIE) &= ~mask;

    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCSSEL_2;

    HWREG16(baseAddress + OFS_UCBxCTLW0) &= ~UCSWRST;

    //HWREG16(baseAddress + OFS_UCBxIE) |= mask;
    HWREG16(baseAddress + OFS_UCBxIE) |= ~0;
}

int I2CSendByte(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char data)
{
	unsigned long int DelayCounter = 0;

	//UCB0CTL0 |= UCMST;
	HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCMST;

	//UCB0I2CSA = I2CSlaveAddress;
	EUSCI_B_I2C_setSlaveAddress(baseAddress, I2CSlaveAddress);

	//UCB0CTL1 |= UCTR; //data in transmit direction
    //UCB0CTL1 |= UCTXSTT; //Generate Start Condition
	 	 	 	 	 	  //Send Start Byte

	HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTR + UCTXSTT;

	//while(!(IFG2 & UCB0TXIFG))  //if UCB0TXIFG != 0, wait here
	while(!(HWREG16(baseAddress + OFS_UCBxIFG) & UCTXIFG))
	{
		 DelayCounter ++;
		 if (DelayCounter >= DELAY_LIMIT)
			 break;
	}

	if (DelayCounter >= DELAY_LIMIT)
		 return -1;

	//UCB0TXBUF = data;				// send the data
	HWREG16(baseAddress + OFS_UCBxTXBUF) = data;

	DelayCounter = 0;

	//while(DelayCounter < DELAY_LIMIT && !(IFG2 & UCB0TXIFG))
	while(DelayCounter < DELAY_LIMIT && !(HWREG16(baseAddress + OFS_UCBxIFG) & UCTXIFG))
	{
		 DelayCounter++;
	}

	if (DelayCounter >= DELAY_LIMIT)
		 return -1;

	//UCB0CTL1 |= UCTXSTP;			//send stop bit
	HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTP;

	DelayCounter = 0;

	//while(DelayCounter < DELAY_LIMIT && (UCB0CTL1 & UCTXSTP))
	while(DelayCounter < DELAY_LIMIT && (HWREG16(baseAddress + OFS_UCBxCTLW0) & UCTXSTP))
	{
		DelayCounter++;
	}

	if (DelayCounter >= DELAY_LIMIT)	//check if NACK condition occurred
		return -1;
	else
		return 0;

}

int I2CSendBytes(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char *DataBuffer, unsigned int ByteCount, unsigned int *SentByte)
{
	unsigned long int DelayCounter = 0;
    unsigned int NumberOfBytesSent = 0;
    unsigned char *DataPointer;

	//UCB0CTL0 |= UCMST;
    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCMST;
	//UCB0I2CSA = I2CSlaveAddress;
    EUSCI_B_I2C_setSlaveAddress(baseAddress, I2CSlaveAddress);

    DataPointer = DataBuffer;

	//UCB0CTL1 |= UCTR; //data in transmit direction
	//UCB0CTL1 |= UCTXSTT; //Generate Start Condition
	 	 	 	 	 	  //Send Start Byte
	HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTR + UCTXSTT;

	//while(!(IFG2 & UCB0TXIFG))  //if UCTXSTT != 0, wait here
	while(!(HWREG16(baseAddress + OFS_UCBxIFG) & UCTXIFG))
	{
		DelayCounter ++;
		if (DelayCounter > DELAY_LIMIT)
			break;
	}

	if (DelayCounter >= DELAY_LIMIT)   //check if NACK condition occurred
	{
		 *SentByte = NumberOfBytesSent;
		 //UCB0CTL1 |= UCTXSTP;
		 HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTP;
		 return -1;
	}

	for(NumberOfBytesSent = 0; NumberOfBytesSent < ByteCount; NumberOfBytesSent++)
	{
		//UCB0TXBUF= *DataPointer;
	    HWREG16(baseAddress + OFS_UCBxTXBUF) = *DataPointer;
		DelayCounter = 0;

		//while(DelayCounter < DELAY_LIMIT && (!(IFG2 & UCB0TXIFG) || (UCB0CTL1 & UCTXSTT)))	//check if the byte has been sent
		while(DelayCounter < DELAY_LIMIT && (!(HWREG16(baseAddress + OFS_UCBxIFG) & UCTXIFG) ||
		                                    (HWREG16(baseAddress + OFS_UCBxCTLW0) & UCTXSTT)))
		{
			DelayCounter++;
		}

		if (DelayCounter >= DELAY_LIMIT)	//check if NACK condition occurred
		{
			 *SentByte = NumberOfBytesSent;
			 //UCB0CTL1 |= UCTXSTP;				//send stop condition
			 HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTP;
			 return -1;
		}

		DataPointer++;
	}

	 //IFG2 &= ~UCB0TXIFG;
	HWREG16(baseAddress + OFS_UCBxIFG) &= ~UCTXIFG;
	//UCB0CTL1 |= UCTXSTP;		//send stop bit
	HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTP;

	DelayCounter = 0;

	//while(DelayCounter < DELAY_LIMIT && ((UCB0CTL1 & UCTXSTP)))
	while(DelayCounter < DELAY_LIMIT && ((HWREG16(baseAddress + OFS_UCBxCTLW0) & UCTXSTP)))
	{
		DelayCounter++;
	}

	*SentByte =  NumberOfBytesSent;

	if (DelayCounter >= DELAY_LIMIT)	//check if NACK condition occurred
	{
		//UCB0CTL1 |= UCSWRST;
	    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCSWRST;
		return -1;
	}
	else
		return 0;
}

int I2CWriteRegisterByte(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned char Data)
{
	unsigned char DataBuffer[2];
	unsigned int SentByte = 0;


	DataBuffer[0] = Register;
	DataBuffer[1] = Data;

	return(I2CSendBytes(baseAddress, I2CSlaveAddress, DataBuffer, 2, &SentByte));
}

int I2CWriteRegisterByteWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned char Data)
{
	unsigned char DataBuffer[4];
	unsigned int SentByte = 0;

    DataBuffer[0] = I2CSlaveAddress << 1;
	DataBuffer[1] = Register;
	DataBuffer[2] = Data;
	DataBuffer[3] = CRC8(DataBuffer, 3, CRC_KEY);

	return(I2CSendBytes(baseAddress, I2CSlaveAddress, DataBuffer + 1, 3, &SentByte));
}

int I2CWriteRegisterWordWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned int Data)
{
	unsigned char DataBuffer[6];
	unsigned int SentByte = 0;

    DataBuffer[0] = I2CSlaveAddress << 1;
	DataBuffer[1] = Register;
	DataBuffer[2] = LOW_BYTE(Data);
	DataBuffer[3] = CRC8(DataBuffer, 3, CRC_KEY);
	DataBuffer[4] = HIGH_BYTE(Data);
	DataBuffer[5] = CRC8(DataBuffer + 4, 1, CRC_KEY);

	return(I2CSendBytes(baseAddress, I2CSlaveAddress, DataBuffer + 1, 5, &SentByte));
}

int I2CWriteBlockWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char StartAddress, unsigned char *Buffer, unsigned char Length)
{
	unsigned char *BufferCRC, *Pointer;
	int i;
	unsigned int SentByte = 0;
	int result;

	BufferCRC = (unsigned char*)malloc(2*Length + 2);
	if (NULL == BufferCRC)
		return -1;

	Pointer = BufferCRC;
	*Pointer = I2CSlaveAddress << 1;
	Pointer++;
	*Pointer = StartAddress;
	Pointer++;
	*Pointer = *Buffer;
	Pointer++;
	*Pointer = CRC8(BufferCRC, 3, CRC_KEY);

	for(i = 1; i < Length; i++)
	{
        Pointer++;
        Buffer++;
        *Pointer = *Buffer;
		*(Pointer + 1) = CRC8(Pointer, 1, CRC_KEY);
		Pointer++;
	}

	result = I2CSendBytes(baseAddress, I2CSlaveAddress, BufferCRC + 1, 2*Length + 1, &SentByte);

	free(BufferCRC);
	BufferCRC = NULL;

	return result;
}

int I2CWriteRegisterWord(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned int Data)
{
	unsigned char DataBuffer[3];
	unsigned int SentByte = 0;

	DataBuffer[0] = Register;
	DataBuffer[1] = LOWBYTE(Data);
	DataBuffer[2] = HIGHBYTE(Data);

	return(I2CSendBytes(baseAddress, I2CSlaveAddress, DataBuffer, 3, &SentByte));
}

int I2CReadBytes(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char *DataBuffer, unsigned int ExpectedByteNumber, unsigned int *NumberOfReceivedBytes)
{
	unsigned long int DelayCounter = 0;
    unsigned char *DataPointer;
    unsigned int *NumberOfReceivedBytesPointer;

    NumberOfReceivedBytesPointer = NumberOfReceivedBytes;
    *NumberOfReceivedBytesPointer = 0;

    //UCB0CTL0 |= UCMST;
    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCSWRST;

    DataPointer = DataBuffer;
	//UCB0I2CSA = I2CSlaveAddress;
    EUSCI_B_I2C_setSlaveAddress(baseAddress, I2CSlaveAddress);

	//UCB0CTL1 &= ~(UCTR); //data in receive direction
    HWREG16(baseAddress + OFS_UCBxCTLW0) &= ~UCTR;

	//UCB0CTL1 |= UCTXSTT; //Generate Start Condition
    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTT;

	//while((UCB0CTL1 & UCTXSTT))  //if UCTXSTT != 0, wait here
    while (HWREG16(baseAddress + OFS_UCBxCTLW0) & UCTXSTT)
	{
		 DelayCounter ++;
		 if (DelayCounter >= DELAY_LIMIT)
			 break;
	}

	//if (DelayCounter >= DELAY_LIMIT || UCB0STAT & UCNACKIFG)   //check if NACK condition occurred
    if (DelayCounter >= DELAY_LIMIT || HWREG16(baseAddress + OFS_UCBxIFG) & UCNACKIFG)
		 return -1;

	for(*NumberOfReceivedBytesPointer = 0; *NumberOfReceivedBytesPointer < ExpectedByteNumber; (*NumberOfReceivedBytesPointer)++)
	{
		if(*NumberOfReceivedBytesPointer + 1 == ExpectedByteNumber)
			//UCB0CTL1 |= UCTXSTP;
		    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCTXSTP;

		DelayCounter = 0;

		//while(DelayCounter < DELAY_LIMIT && !(IFG2 & UCB0RXIFG))
		while(DelayCounter < DELAY_LIMIT && !(HWREG16(baseAddress + OFS_UCBxIFG) & UCRXIFG))
		{
			DelayCounter++;
		}

		if(DelayCounter == DELAY_LIMIT)
		{
			//UCB0CTL1 |= UCSWRST;   //if I2C overtime condition occurred, reset I2C engine
		    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCSWRST;
			return -1;
		}

		*DataPointer = UCB0RXBUF;

		DataPointer++;
	}

	DelayCounter = 0;
	//while(DelayCounter < DELAY_LIMIT && (UCB0CTL1 & UCTXSTP))
	while(DelayCounter < DELAY_LIMIT && (HWREG16(baseAddress + OFS_UCBxCTLW0) & UCTXSTP))
	{
		DelayCounter++;
	}

	if(DelayCounter >= DELAY_LIMIT)
	{
		//UCB0CTL1 |= UCSWRST;
	    HWREG16(baseAddress + OFS_UCBxCTLW0) |= UCSWRST;
		return -1;
	}

	return 0;

}

int I2CReadRegisterByte(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned char *Data)
{
	unsigned char TargetRegister = Register;
	unsigned int SentByte = 0;
	unsigned int ReadDataCount = 0;
    int ReadStatus = 0;
    int WriteStatus = 0;

	WriteStatus = I2CSendBytes(baseAddress, I2CSlaveAddress, &TargetRegister, 1, &SentByte);

	ReadStatus = I2CReadBytes(baseAddress, I2CSlaveAddress, Data, 1, &ReadDataCount);

	if (ReadStatus != 0 || WriteStatus != 0)
	{
		return -1;
	}

	return 0;
}

int I2CReadBlock(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char StartRegisterAddress, unsigned char *Buffer, unsigned int BlockSize, unsigned int *NumberOfBytes)
{
	unsigned char TargetRegister = StartRegisterAddress;
	unsigned int SentByte = 0;
	int ReadStatus = 0;
	int WriteStatus = 0;

	WriteStatus = I2CSendBytes(baseAddress, I2CSlaveAddress, &TargetRegister, 1, &SentByte);

	ReadStatus = I2CReadBytes(baseAddress, I2CSlaveAddress, Buffer, BlockSize, NumberOfBytes);

	if(ReadStatus != 0 || WriteStatus != 0)
	{
		return -1;
	}

	return 0;
}

unsigned char CRC8(unsigned char *ptr, unsigned char len,unsigned char key)
{
	unsigned char i;
	unsigned char crc=0;
	while(len--!=0)
	{
		for(i=0x80; i!=0; i/=2)
		{
			if((crc & 0x80) != 0)
			{
				crc *= 2;
				crc ^= key;
			}
			else
				crc *= 2;

			if((*ptr & i)!=0)
				crc ^= key;
		}
		ptr++;
	}
	return(crc);
}

int I2CReadRegisterByteWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned char *Data)
{
	unsigned char TargetRegister = Register;
	unsigned int SentByte = 0;
	unsigned char ReadData[2];
	unsigned int ReadDataCount = 0;
	unsigned char CRCInput[2];
	unsigned char CRC = 0;
    int ReadStatus = 0;
    int WriteStatus = 0;

	WriteStatus = I2CSendBytes(baseAddress, I2CSlaveAddress, &TargetRegister, 1, &SentByte);

	ReadStatus = I2CReadBytes(baseAddress, I2CSlaveAddress, ReadData, 2, &ReadDataCount);

	if (ReadStatus != 0 || WriteStatus != 0)
	{
		return -1;
	}

	CRCInput[0] = (I2CSlaveAddress << 1) + 1;
	CRCInput[1] = ReadData[0];

	CRC = CRC8(CRCInput, 2, CRC_KEY);

	if (CRC != ReadData[1])
		return -1;

	*Data = ReadData[0];
	return 0;
}

int I2CReadRegisterWordWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned int *Data)
{
	unsigned char TargetRegister = Register;
	unsigned int SentByte = 0;
	unsigned char ReadData[4];
	unsigned int ReadDataCount = 0;
	unsigned char CRCInput[2];
	unsigned char CRC = 0;
    int ReadStatus = 0;
    int WriteStatus = 0;

	WriteStatus = I2CSendBytes(baseAddress, I2CSlaveAddress, &TargetRegister, 1, &SentByte);

	ReadStatus = I2CReadBytes(baseAddress, I2CSlaveAddress, ReadData, 4, &ReadDataCount);

	if (ReadStatus != 0 || WriteStatus != 0)
	{
		return -1;
	}

	CRCInput[0] = (I2CSlaveAddress << 1) + 1;
	CRCInput[1] = ReadData[0];

	CRC = CRC8(CRCInput, 2, CRC_KEY);

	if (CRC != ReadData[1])
		return -1;

	CRC = CRC8(ReadData + 2, 1, CRC_KEY);

	if (CRC != ReadData[3])
		return -1;

	*Data = ReadData[0];

	*Data = (*Data << 8) + ReadData[2];

	return 0;
}

int I2CReadBlockWithCRC(uint16_t baseAddress, unsigned char I2CSlaveAddress, unsigned char Register, unsigned char *Buffer, unsigned char Length)
{
	unsigned char TargetRegister = Register;
	unsigned int SentByte = 0;
	unsigned char *ReadData = NULL, *StartData = NULL;
	unsigned int ReadDataCount = 0;
	unsigned char CRCInput[2];
	unsigned char CRC = 0;
    int ReadStatus = 0;
    int WriteStatus = 0;
    int i;

    StartData = (unsigned char *)malloc(2 * Length);

    if (NULL == StartData)
    	return -1;

    ReadData = StartData;

	WriteStatus = I2CSendBytes(baseAddress, I2CSlaveAddress, &TargetRegister, 1, &SentByte);

	ReadStatus = I2CReadBytes(baseAddress, I2CSlaveAddress, ReadData, 2 * Length, &ReadDataCount);

	if (ReadStatus != 0 || WriteStatus != 0)
	{
		free(StartData);
		StartData = NULL;

		return -1;
	}

	CRCInput[0] = (I2CSlaveAddress << 1) + 1;
	CRCInput[1] = *ReadData;

	CRC = CRC8(CRCInput, 2, CRC_KEY);

	ReadData++;
	if (CRC != *ReadData)
	{
		free(StartData);
		StartData = NULL;
		return -1;
	}
	else
		*Buffer = *(ReadData - 1);

	for(i = 1; i < Length; i++)
	{
		ReadData++;
		CRC = CRC8(ReadData, 1, CRC_KEY);
		ReadData++;
		Buffer++;

		if (CRC != *ReadData)
		{
			free(StartData);
			StartData = NULL;

			return -1;
		}
		else
			*Buffer = *(ReadData - 1);
	}

	free(StartData);
	StartData = NULL;

	return 0;
}

int GetADCGainOffset(uint16_t baseAddress)
{
	int result;

	result = I2CReadRegisterByteWithCRC(baseAddress, BQMAXIMO, ADCGAIN1, &(Registers.ADCGain1.ADCGain1Byte));
	result = I2CReadRegisterByteWithCRC(baseAddress, BQMAXIMO, ADCGAIN2, &(Registers.ADCGain2.ADCGain2Byte));
	result = I2CReadRegisterByteWithCRC(baseAddress, BQMAXIMO, ADCOFFSET, &(Registers.ADCOffset));

	return result;
}

int ConfigureBqMaximo(uint16_t baseAddress)
{
	int result = 0;
	unsigned char bqMaximoProtectionConfig[5];

	result = I2CWriteBlockWithCRC(baseAddress, BQMAXIMO, PROTECT1, &(Registers.Protect1.Protect1Byte), 5);

	result = I2CReadBlockWithCRC(baseAddress, BQMAXIMO, PROTECT1, bqMaximoProtectionConfig, 5);

	if(bqMaximoProtectionConfig[0] != Registers.Protect1.Protect1Byte
			|| bqMaximoProtectionConfig[1] != Registers.Protect2.Protect2Byte
			|| bqMaximoProtectionConfig[2] != Registers.Protect3.Protect3Byte
			|| bqMaximoProtectionConfig[3] != Registers.OVTrip
			|| bqMaximoProtectionConfig[4] != Registers.UVTrip)
	{
		result = -1;
	}

	return result;
}

int InitialisebqMaximo(uint16_t baseAddress)
{
	int result = 0;

	Registers.Protect1.Protect1Bit.SCD_DELAY = SCDDelay;
	Registers.Protect1.Protect1Bit.SCD_THRESH = SCDThresh;
	Registers.Protect2.Protect2Bit.OCD_DELAY = OCDDelay;
	Registers.Protect2.Protect2Bit.OCD_THRESH = OCDThresh;
	Registers.Protect3.Protect3Bit.OV_DELAY = OVDelay;
	Registers.Protect3.Protect3Bit.UV_DELAY = UVDelay;

	result = GetADCGainOffset(baseAddress);

	Gain = (365 + ((Registers.ADCGain1.ADCGain1Byte & 0x0C) << 1) + ((Registers.ADCGain2.ADCGain2Byte & 0xE0)>> 5)) / 1000.0;
	iGain = 365 + ((Registers.ADCGain1.ADCGain1Byte & 0x0C) << 1) + ((Registers.ADCGain2.ADCGain2Byte & 0xE0)>> 5);

    Registers.OVTrip = (unsigned char)((((unsigned short)((OVPThreshold - Registers.ADCOffset)/Gain + 0.5) - OV_THRESH_BASE) >> 4) & 0xFF);
    Registers.UVTrip = (unsigned char)((((unsigned short)((UVPThreshold - Registers.ADCOffset)/Gain + 0.5) - UV_THRESH_BASE) >> 4) & 0xFF);

    result = ConfigureBqMaximo(baseAddress);

    return result;
}

int UpdateVoltageFromBqMaximo(uint16_t baseAddress)
{
	int Result = 0, i = 0;
	unsigned char *pRawADCData = NULL;
	unsigned int iTemp = 0;
	unsigned long lTemp = 0;

	Result = I2CReadBlockWithCRC(baseAddress, BQMAXIMO, \
			VC1_HI_BYTE, \
			&(Registers.VCell1.VCell1Byte.VC1_HI), \
			30);

	pRawADCData = &Registers.VCell1.VCell1Byte.VC1_HI;
	for (i = 0; i < 15; i++)
	{
		iTemp = (unsigned int)(*pRawADCData << 8) + *(pRawADCData + 1);
		lTemp = ((unsigned long)iTemp * iGain)/1000;
		lTemp += Registers.ADCOffset;
		CellVoltage[i] = lTemp;
		pRawADCData += 2;
	}

	return Result;
}

int main(void)
{
	int Result;


    //WDTCTL = WDTPW | WDTHOLD;	// Stop watchdog timer

    DISABLE_INT;

    ClockInitialise();

    I2CInitialise(EUSCI_B1_BASE);

    InitialisebqMaximo(EUSCI_B1_BASE);

    while(1)
    {
    	Result = UpdateVoltageFromBqMaximo(EUSCI_B1_BASE);
    }

	return Result;
}

over 3 years ago

0 Bruce McKenney over 3 years ago

Guru 95555 points

>P4SEL0 |= BIT6 + BIT7; // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA
>P4SEL1 |= BIT6 + BIT7; // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA

To get UCB1SDA/SCL on P4.6/7 you need PSEL=01, i.e. the PSEL1 bits should be =0 [Ref FR2355 data sheet (SLASEC4D) Table 6-66].

Remove the second of these lines.

--------------

Did you install the I2C pullups? [Ref EVM data sheet (SLVU925C) Sec 6.6]

If your wires are very short and you don't run the bus too fast (try BRW=80 instead of BRW=8) you might succeed with the internal pullups:

>P4OUT |= (BIT6|BIT7);

>P4REN |= (BIT6|BIT7);

+1 ming over 3 years ago in reply to Bruce McKenney

Prodigy 250 points

change the configuration in the following

1> pull up I2C on both side

P4SEL0 |= BIT6 + BIT7; // Assign I2C pins to USCI_B0, P1.6 for SCL and P1.7 for SDA
P4SEL1 = 0;
P4OUT |= BIT6 + BIT7;
P4REN |= BIT6 + BIT7;

When I try the same steps, I do see UCTXIFG set to 1.

However, it is in the B0 module .

My setting is on B1 module.

Does this make sense and how can i fix this?

please advise

Thanks

0 Bruce McKenney over 3 years ago in reply to ming

Guru 95555 points

This does seem unusual. What is the value of EUSCI_B1_BASE? (It should be 0x05C0) [Right-click on the name and "Go To Definition".]

Do the other UCB0 registers show your settings as well? An uninitialized EUSCI_B has UCTXIFG=1 [Ref User Guide (SLAU445I) Table 23-18].

0 Jace H over 3 years ago in reply to Bruce McKenney

TI__Guru 56685 points

Hello,

Please see the following resources for debugging I2C issues with MSP430.

MSP Academy: I2C Concepts

Solutions to Common issues of eUSCI and USCI Serial Communications

+1 ming over 3 years ago

Prodigy 250 points

I think this issue is not even related to I2C.

we just found out that msp-ts430pt48 has no crystal.

I will mark this issue solved.

Thanks

**Attention** This is a public forum

MSP low-power microcontrollers

MSP low-power microcontroller forum

MSP430FR2355: MSP430FR2355