We have an imx390 sensor with an internal isp. Connect to imx390-- >ds90ub953-- >ds90ub954--> am62a processor, I used name_overlays= k3-am62a7-fpdlink-sk-funition. dtbo k3-J721e-fpdlink-imx390-rcm-0-dtbo, but I couldn't debug it. Is there any changes I need to make?
media-ctl -p as follow：
Now I have debug the raw imx390 sensor successful，could get the frame
return to the internal isp imx390 sensor，it does not require a driver，The sensor is configured automatically by the build-in ISP in the camera
I did this step as： https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1162037/tda4vm-some-errors-when-using-imx390-from-otobrite-on-linux
but the following error occurs：
do i need modify imx390_dummy.c？ and how i modify?
the following is imx390_dummy.c co
de// SPDX-License-Identifier: GPL-2.0
/*
* Dummy driver for IMX390 self streaming cameras
*
*/
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/v4l2-mediabus.h>
#include <linux/videodev2.h>
#include <media/v4l2-subdev.h>
struct imx390_dummy {
struct device *dev;
struct i2c_client *client;
struct v4l2_subdev subdev;
struct media_pad pad;
};
static inline struct imx390_dummy *to_imx390(struct v4l2_subdev *sd)
{
return container_of(sd, struct imx390_dummy, subdev);
}
static void imx390_dummy_init_formats(struct v4l2_subdev_state *state)
{
struct v4l2_mbus_framefmt *format;
format = v4l2_state_get_stream_format(state, 0, 0);
format->code = MEDIA_BUS_FMT_SRGGB12_1X12;
//format->code = MEDIA_BUS_FMT_UYVY8_2X8;
format->width = 1936;
format->height = 1100;
//format->width = 1920;
//format->height = 1080;
format->field = V4L2_FIELD_NONE;
format->colorspace = V4L2_COLORSPACE_SMPTE170M;
}
static int _imx390_dummy_set_routing(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state)
{
struct v4l2_subdev_route routes[] = {
{
.source_pad = 0,
.source_stream = 0,
.flags = V4L2_SUBDEV_ROUTE_FL_IMMUTABLE |
V4L2_SUBDEV_ROUTE_FL_SOURCE |
V4L2_SUBDEV_ROUTE_FL_ACTIVE,
},
{
.source_pad = 0,
.source_stream = 1,
.flags = V4L2_SUBDEV_ROUTE_FL_IMMUTABLE |
V4L2_SUBDEV_ROUTE_FL_SOURCE,
}
};
struct v4l2_subdev_krouting routing = {
.num_routes = ARRAY_SIZE(routes),
.routes = routes,
};
int ret;
ret = v4l2_subdev_set_routing(sd, state, &routing);
if (ret < 0)
return ret;
imx390_dummy_init_formats(state);
return 0;
}
static int imx390_dummy_init_cfg(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state)
{
int ret;
v4l2_subdev_lock_state(state);
ret = _imx390_dummy_set_routing(sd, state);
v4l2_subdev_unlock_state(state);
return ret;
}
static int imx390_dummy_enum_mbus_code(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state,
struct v4l2_subdev_mbus_code_enum *code)
{
code->code = MEDIA_BUS_FMT_SRGGB12_1X12;
//code->code = MEDIA_BUS_FMT_UYVY8_2X8;
return 0;
}
static int imx390_dummy_enum_frame_sizes(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state,
struct v4l2_subdev_frame_size_enum *fse)
{
fse->min_width = 1936;
//fse->min_width = 1920;
fse->max_width = fse->min_width;
fse->max_height = 1100;
//fse->max_height = 1080;
fse->min_height = fse->max_height;
return 0;
}
static int imx390_dummy_set_fmt(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state,
struct v4l2_subdev_format *fmt)
{
struct v4l2_mbus_framefmt *format;
u32 code;
int ret = 0;
code = MEDIA_BUS_FMT_SRGGB12_1X12;
//code = MEDIA_BUS_FMT_UYVY8_2X8;
v4l2_subdev_lock_state(state);
/* Update the stored format and return it. */
format = v4l2_state_get_stream_format(state, fmt->pad, fmt->stream);
format->code = code;
format->width = 1936;
format->height = 1100;
//format->width = 1920;
//format->height = 1080;
fmt->format = *format;
v4l2_subdev_unlock_state(state);
return ret;
}
static int imx390_dummy_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
struct v4l2_mbus_frame_desc *fd)
{
struct v4l2_subdev_state *state;
struct v4l2_mbus_framefmt *fmt;
u32 bpp;
int ret = 0;
if (pad != 0)
return -EINVAL;
state = v4l2_subdev_lock_active_state(sd);
fmt = v4l2_state_get_stream_format(state, 0, 0);
if (!fmt) {
ret = -EPIPE;
goto out;
}
memset(fd, 0, sizeof(*fd));
fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
/* pixel stream */
bpp = 12;
fd->entry[fd->num_entries].stream = 0;
fd->entry[fd->num_entries].flags = V4L2_MBUS_FRAME_DESC_FL_LEN_MAX;
fd->entry[fd->num_entries].length = fmt->width * fmt->height * bpp / 8;
fd->entry[fd->num_entries].pixelcode = fmt->code;
fd->entry[fd->num_entries].bus.csi2.vc = 0;
fd->entry[fd->num_entries].bus.csi2.dt = 0x2c; /* SRGGB12 */
fd->num_entries++;
out:
v4l2_subdev_unlock_state(state);
return ret;
}
static int imx390_dummy_set_routing(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state,
enum v4l2_subdev_format_whence which,
struct v4l2_subdev_krouting *routing)
{
int ret;
if (routing->num_routes == 0 || routing->num_routes > 1)
return -EINVAL;
v4l2_subdev_lock_state(state);
ret = _imx390_dummy_set_routing(sd, state);
v4l2_subdev_unlock_state(state);
return ret;
}
static int imx390_dummy_get_frame_interval(struct v4l2_subdev *sd,
struct v4l2_subdev_frame_interval *fi)
{
fi->interval.numerator = 1;
fi->interval.denominator = 30;
return 0;
}
static int imx390_dummy_set_frame_interval(struct v4l2_subdev *sd,
struct v4l2_subdev_frame_interval *fi)
{
int ret = 0;
fi->interval.numerator = 1;
fi->interval.denominator = 30;
return ret;
}
static int imx390_dummy_set_stream(struct v4l2_subdev *sd, int enable)
{
return 0;
}
static const struct v4l2_subdev_video_ops imx390_dummy_subdev_video_ops = {
.g_frame_interval = imx390_dummy_get_frame_interval,
.s_frame_interval = imx390_dummy_set_frame_interval,
.s_stream = imx390_dummy_set_stream,
};
static const struct v4l2_subdev_pad_ops imx390_dummy_subdev_pad_ops = {
.init_cfg = imx390_dummy_init_cfg,
.enum_mbus_code = imx390_dummy_enum_mbus_code,
.enum_frame_size = imx390_dummy_enum_frame_sizes,
.get_fmt = v4l2_subdev_get_fmt,
.set_fmt = imx390_dummy_set_fmt,
.set_routing = imx390_dummy_set_routing,
.get_frame_desc = imx390_dummy_get_frame_desc,
};
static const struct v4l2_subdev_ops imx390_dummy_subdev_ops = {
.video = &imx390_dummy_subdev_video_ops,
.pad = &imx390_dummy_subdev_pad_ops,
};
static int imx390_dummy_probe(struct i2c_client *client)
{
struct imx390_dummy *imx390;
struct v4l2_subdev *sd;
int ret;
imx390 = devm_kzalloc(&client->dev, sizeof(*imx390), GFP_KERNEL);
if (!imx390)
return -ENOMEM;
imx390->dev = &client->dev;
/* Initialize the subdev and its controls. */
sd = &imx390->subdev;
v4l2_i2c_subdev_init(sd, client, &imx390_dummy_subdev_ops);
sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
V4L2_SUBDEV_FL_HAS_EVENTS |
V4L2_SUBDEV_FL_MULTIPLEXED;
/* Initialize the media entity. */
imx390->pad.flags = MEDIA_PAD_FL_SOURCE;
sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
ret = media_entity_pads_init(&sd->entity, 1, &imx390->pad);
if (ret < 0) {
dev_err(imx390->dev,
"%s: media entity init failed %d\n", __func__, ret);
return ret;
}
ret = v4l2_subdev_init_finalize(sd);
if (ret < 0)
goto err_subdev_cleanup;
/* Finally, register the subdev. */
ret = v4l2_async_register_subdev(sd);
if (ret < 0) {
dev_err(imx390->dev,
"%s: v4l2 subdev register failed %d\n", __func__, ret);
goto err_subdev_cleanup;
}
dev_info(imx390->dev, "imx390 dummy probed\n");
return 0;
err_subdev_cleanup:
v4l2_subdev_cleanup(&imx390->subdev);
media_entity_cleanup(&imx390->subdev.entity);
return ret;
}
static int imx390_dummy_remove(struct i2c_client *client)
{
struct v4l2_subdev *sd = i2c_get_clientdata(client);
struct imx390_dummy *imx390 = to_imx390(sd);
v4l2_async_unregister_subdev(sd);
v4l2_subdev_cleanup(&imx390->subdev);
media_entity_cleanup(&sd->entity);
return 0;
}
struct of_device_id imx390_dummy_dt_id[] = {
{ .compatible = "ottobrite,imx390dummy" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, imx390_dummy_dt_id);
static struct i2c_driver imx390_dummy_i2c_driver = {
.driver = {
.name = "imx390dummy",
.of_match_table = of_match_ptr(imx390_dummy_dt_id),
},
.probe_new = imx390_dummy_probe,
.remove = imx390_dummy_remove,
};
module_i2c_driver(imx390_dummy_i2c_driver);
MODULE_DESCRIPTION("Dummy Driver for self streaming IMX390");
MODULE_AUTHOR("Vaishnav Achath <vaishnav.a@ti.com>");
MODULE_LICENSE("GPL v2");
