• State
  • Locked Locked
  • Replies 5 replies
  • Subscribers 99 subscribers
  • Views 229 views
  • Users 0 members are here
Support feedback
Options
Options
Similar topics

This thread has been locked.

If you have a related question, please click the "Ask a related question" button in the top right corner. The newly created question will be automatically linked to this question.

TDA4VM: Don't fetch DCC info from FS if DCC is disabled

Keelung Yang
Expert 1786 points
Part Number: TDA4VM

Hi,

If DCC is not supported in sensor driver, then apps shouldn't loading it from FS.

In app_single_cam_main.c in PDKR v8.0

Fullscreen
1
2
3
4
5
6
7
8
9
#ifdef A72
#if defined(LINUX)
appDccUpdatefromFS(obj->sensor_name, obj->sensor_wdr_mode,
obj->node_aewb, 0,
obj->node_viss, 0,
obj->node_ldc, 0,
obj->context);
#endif
#endif
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

AGAIN. We, as one of Ti users. Need a public place to report issuse as in GitHub. Forum is not a good place.

  • 0
    TI__Guru**** 450265 points

    Hi Keelung Yang,

    Do you mean for YUV sensor? For YUV sensor, there is no VISS, so DCC is not required. 

    For RAW sensor, since VISS is used in the path, DCC is required. 

    I did not get your question related to fetching of DCC. Where do you want to load DCC from? is it from sensor or FS?

    Regards,

    Brijesh

  • 0 in reply to Brijesh Jadav
    Expert 1786 points

    Hi Brijesh,

    For YUV sensor, if DCC is not required, why loading it from FS?

    The loading conditions are A72 & LINUX, no matter there is a YUV or RAW sensor, or DCC is supported in IssSensor_Features

  • 0 in reply to Keelung Yang
    TI__Guru**** 450265 points

    Hi Keelung Yang,

    I agree that this should be included for YUV sensor or if DCC is not supported. But i could not understand exactly what's issue you are facing. Is the usecase not running fine for YUV sensor? There is no return error check for this API, so even if it fails, the usecase should continue..

    Regards,

    Brijesh

  • 0 in reply to Brijesh Jadav
    Expert 1786 points

    Hi Brijesh,

    Brijesh Jadav said:
    There is no return error check for this API, so even if it fails, the usecase should continue.

    That's the ISSUE, a generic ISSUE: Please take care for USERS and their CLIENTS.

    When you, as one of Ti's official programmers, output an error log which shouldn't be outputed, then HOW MANY USERS and their CLIENTS will take care this error message? Why this error happens? Is it caused by me or Ti? Is it an application/middleware/driver issuse? Should I confirm it from Ti?

    You're wasting the time of Ti‘s USERS and their CLIENTS, by a minimal bug, and more such bugs.

  • 0 in reply to Keelung Yang
    TI__Guru**** 450265 points

    Hi Keelung Yang,

    But what's the error you are seeing? Do you see usecase stop running because of this error? 

    As i said, this is an issue, and it will report an error when FS does not contain DCC binary file, but it does not affect running of usecase, isn't it?

    Regards,

    Brijesh